Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0016543
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2011-03-29 16:432011-05-12 13:30
ReporterAinhoaPagolaView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision36fe7542df64
ProjectionnoneETAnoneTarget Version3.0MP0
OSLinux 32 bitDatabasePostgreSQLJava version1.5
OS VersionUbuntu 8.4Database version8.3Ant version1.7
Product Version3.0RC5SCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0016543: Window created with error on module

DescriptionAfter creating a new window, with a new table in a new module. It is not properly build as an error is displayed when accessing it.
Steps To Reproduce1.-Create the table attached in the issue in the database.
2.-Create a new module. Java data package: org.openbravo.hotel. Check it as in development. Create a dependency to core. Create a Data package: org.openbravo.hotel.data.
3.-Create the table in the application dictionary. Name = hotel_guest, DB Table name = hotel_guest and JavaClass: hotelguest. Data access = Client/Organization. Create the columns.
4.-Run Synchronize Terminology
5.-Create the window, the tab and the fields for the table.
6.-Create the menu
7.-Compile the window
8.-Restart tomcat
9.-Login the application and try and access the window. The error attached is shown the first time it is accessed. The second time, it is not possible to insert data on it. Reloading the page, the error is displayed.
TagsNo tags attached.
Attached Files? file icon Hotel_guest [^] (1,055 bytes) 2011-03-29 16:43 [Show Content]
png file icon Error.png [^] (63,529 bytes) 2011-03-29 16:43

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0035387)
alostale (viewer)
2011-03-31 09:02

 The problem is caused because the table has not identifier.

When compiling this message is got:

[WADValidation] 53 [main] ERROR org.openbravo.wad.validation.WADValidationResult - +++++++++++++++++++++++++++++++++++++++++++++++++++
[WADValidation] 58 [main] ERROR org.openbravo.wad.validation.WADValidationResult - Errors for Validation type: Missing Identifier
[WADValidation] 65 [main] ERROR org.openbravo.wad.validation.WADValidationResult - +++++++++++++++++++++++++++++++++++++++++++++++++++
[WADValidation] 67 [main] ERROR org.openbravo.wad.validation.WADValidationResult - Table Hotel_guest has not identifier.

This is the error obtained when trying to fetch data:
581283 [http-8881-4] ERROR org.hibernate.hql.PARSER - line 1:393: unexpected token: null
581292 [http-8881-4] ERROR org.openbravo.base.exception.OBException - Exception when creating query select e from Hotel_guest as e where e.organization.id in ('0', '4F68EB1C1B734E79B27DE9D2DF56089F', '0D8E225ADA6E425E98EAA0F34E5912D7', 'B9C7088AB859483A9B1FB342AC2BE17A', '90A1F59849E84AFABD04814B3D15A691', '378AF0EAE1A2479EAAA33436645E9433', '3C816D72B14D4BBCB8571404B794AB84', '7A8E888A4B4C4E638CD5EB3A41A3289A') and e.client.id in ('FF8080812AFBCB14012AFBD3E373001F', '0')order by
org.hibernate.hql.ast.QuerySyntaxException: unexpected token: null near line 1, column 393 [select e from Hotel_guest as e where e.organization.id in ('0', '4F68EB1C1B734E79B27DE9D2DF56089F', '0D8E225ADA6E425E98EAA0F34E5912D7', 'B9C7088AB859483A9B1FB342AC2BE17A', '90A1F59849E84AFABD04814B3D15A691', '378AF0EAE1A2479EAAA33436645E9433', '3C816D72B14D4BBCB8571404B794AB84', '7A8E888A4B4C4E638CD5EB3A41A3289A') and e.client.id in ('FF8080812AFBCB14012AFBD3E373001F', '0')order by ]

Problem is in DefaultDataSource, it receives 'identifier' as sort parameter but it is not present in table definition.

Martin: should we do some checks (the ones done in WAD validations??) before trying to build a window?
(0035388)
alostale (viewer)
2011-03-31 09:03

 Lowered priority: the problem was in the table definition.

TBD: which kind of validations should be done to show a more user friendly message.
(0036518)
hgbot (developer)
2011-05-06 15:16

 Repository: erp/devel/pi
Changeset: 36fe7542df646c1cc04fcf3978c17919793bb69d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri May 06 15:16:32 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/36fe7542df646c1cc04fcf3978c17919793bb69d [^]

Fixes issue 16543: Window created with error on module

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
---
(0036692)
AinhoaPagola (viewer)
2011-05-11 17:24

 Tested and working fine.
(0036847)
hudsonbot (viewer)
2011-05-12 13:30

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c40e579fcd38 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2011-03-29 16:43 AinhoaPagola New Issue
2011-03-29 16:43 AinhoaPagola Assigned To => alostale
2011-03-29 16:43 AinhoaPagola File Added: Hotel_guest
2011-03-29 16:43 AinhoaPagola Modules => Core
2011-03-29 16:43 AinhoaPagola OBNetwork customer => Yes
2011-03-29 16:43 AinhoaPagola File Added: Error.png
2011-03-30 08:52 alostale Target Version => 3.0RC6
2011-03-30 08:52 alostale Status new => scheduled
2011-03-30 08:52 alostale fix_in_branch => pi
2011-03-31 09:02 alostale Note Added: 0035387
2011-03-31 09:03 alostale Note Added: 0035388
2011-03-31 09:03 alostale Assigned To alostale => mtaal
2011-03-31 09:03 alostale Priority urgent => normal
2011-03-31 09:03 alostale Target Version 3.0RC6 => 3.0
2011-03-31 09:03 alostale fix_in_branch pi =>
2011-04-26 16:09 dalsasua Issue Monitored: networkb
2011-05-02 12:00 AinhoaPagola Severity major => minor
2011-05-06 15:16 hgbot Checkin
2011-05-06 15:16 hgbot Note Added: 0036518
2011-05-06 15:16 hgbot Status scheduled => resolved
2011-05-06 15:16 hgbot Resolution open => fixed
2011-05-06 15:16 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/36fe7542df646c1cc04fcf3978c17919793bb69d [^]
2011-05-11 17:24 AinhoaPagola Note Added: 0036692
2011-05-11 17:24 AinhoaPagola Status resolved => closed
2011-05-12 13:30 hudsonbot Checkin
2011-05-12 13:30 hudsonbot Note Added: 0036847

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker