0016352: Problem in getBalance method of Financial Account Transactions

Description

When one payment is divided into several invoices, method org.openbravo.erpCommon.ad_forms.DocFINFinAccTransaction.getBalance() for
each DocLine attempts to subtract the PaymentAmount from the DepositAmount.

Due to the fact that the DepositAmount comprised the whole PaymentAmount for each
transaction the result is always unbalanced when we have more than only one invoice.

Steps To Reproduce

Go to Financial Management || Accounting || Setup || Accounting Schema || Accounting Schema >> General Ledger
set Suspense Balancing Use = false
create a payment out paying 2 invoices
create a transaction in financial account for the previous payment
post it
Not Balenced error is shown

Proposed Solution

e.g. use:
> BigDecimal lineBalance = new BigDecimal(((DocLine_FINFinAccTransaction)
p_lines[i]).getAmount());
instead of
> BigDecimal lineBalance = new BigDecimal(((DocLine_FINFinAccTransaction)
p_lines[i]).DepositAmount);

or when the filling the FieldProviderFactory in
org.openbravo.erpCommon.ad_forms.DocFINFinAccTransaction.loadLinesPaymentDetailsFieldProvider(FIN_FinaccTransaction)
you might write the Amount into the data-field "DepositAmount":

e.g.: use
> FieldProviderFactory.setField(data[i], "DepositAmount",
paymentDetails.get(i).getAmount().toString());
instead of
> FieldProviderFactory.setField(data[i], "DepositAmount",
transaction.getDepositAmount().toString());

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0016351

2.50MP28

closed

eduardo_Argal

Problem in getBalance method of Financial Account Transactions

Notes
(0034987) hgbot (developer) 2011-03-17 11:29	Repository: erp/stable/2.50 Changeset: a211843dff1ee701b6f0aebc7628f01584c69451 Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com> Date: Thu Mar 17 11:31:28 2011 +0100 URL: http://code.openbravo.com/erp/stable/2.50/rev/a211843dff1ee701b6f0aebc7628f01584c69451 [^] Fixes bug 16352: Problem in getBalance method of Financial Account Transactions --- M src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java ---

Issue History
Date Modified	Username	Field	Change
2011-03-17 11:19	eduardo_Argal	Type	defect => backport
2011-03-17 11:19	eduardo_Argal	fix_in_branch	=> 2.50
2011-03-17 11:25	eduardo_Argal	Steps to Reproduce Updated	View Revisions
2011-03-17 11:29	hgbot	Checkin
2011-03-17 11:29	hgbot	Note Added: 0034987
2011-03-17 11:29	hgbot	Status	scheduled => resolved
2011-03-17 11:29	hgbot	Resolution	open => fixed
2011-03-17 11:29	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/stable/2.50/rev/a211843dff1ee701b6f0aebc7628f01584c69451 [^]
2011-03-17 12:06	maite	Status	resolved => closed
2011-03-17 12:06	maite	Fixed in Version	=> 2.50MP28
2011-03-17 12:54	maite	Issue Monitored: networkb