Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0015888

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] 07. Sales management

major

always

2011-02-09 10:11

2011-04-05 00:00

Reporter

maite

View Status

public

Assigned To

jonalegriaesarte

Priority

urgent

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

pi

Fixed in SCM revision

Projection

none

ETA

none

Target Version

2.50MP27

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

2.50MP26

SCM revision

Review Assigned To

Web browser

Modules

Core

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0015888: Wrong "adjusted price" when using price adjustments

Description

"Adjusted price" of Price Adjustments tab is recalculated by m_get_offer_std_price function when saving order line. If working with decimals "adjusted price" could be different to order line price due to rounding.
"Adjusted price" should be directly copy from order line instead of recalculated again to avoid this difference

Steps To Reproduce

1. Master Data Management || Pricing || Price Adjustments || Adjustments:
  starting date= 08/02/2011
  Discount %= 30
  Included Business Partners= Only those defined --> Add "mafalda" in BP tab
  Included Products = Only those defined --> Add "hammer" in BP tab
2. Master Data Management || Product || Product >> Price : search for hammer and set 3 prices for "Mafalda price list" to 3.75
3. Sales Management || Transactions || Sales Order || Header : create order for mafalda
4. Sales Management || Transactions || Sales Order || Header >> Lines : add line for hammer and save.
5. Navigate to Sales Management || Transactions || Sales Order || Header >> Lines >> Price Adjustments : realize that "Adjusted Price" is 3.76 instead of 3.75

Problem is in function m_get_offer_std_price (which is called from c_orderline_trg2): it performs arithmetic operation and return number with several decimals, which is again rounded causing the error.

Tags

No tags attached.

15888.diff [^] (774 bytes) 2011-03-22 11:48 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/erpCommon/ad_callouts/SL_Order_Amt.java b/src/org/openbravo/erpCommon/ad_callouts/SL_Order_Amt.java
--- a/src/org/openbravo/erpCommon/ad_callouts/SL_Order_Amt.java
+++ b/src/org/openbravo/erpCommon/ad_callouts/SL_Order_Amt.java
@@ -162,7 +162,7 @@
         // Do not do anything.
         if (!priceActual.equals(expectedPriceActual)) {
           priceStd = new BigDecimal(SLOrderProductData.getOffersStdPrice(this,
-              dataOrder[0].cBpartnerId, priceActual.toString().replace("\"", ""), strProduct,
+              dataOrder[0].cBpartnerId, expectedPriceActual.toString().replace("\"", ""), strProduct,
               dataOrder[0].dateordered, strQty, dataOrder[0].mPricelistId, dataOrder[0].id));
         }
         // priceList

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

3.0RC6

closed

jonalegriaesarte

Wrong "adjusted price" when using price adjustments

Notes
(0035140) jonalegriaesarte (reporter) 2011-03-22 11:48	Attached the diff file to the issue because the repository is frozen.

(0035481) hgbot (developer) 2011-04-01 18:06	Repository: erp/stable/2.50 Changeset: 944b0da4c10e03877b2ce01709e0031e84212830 Author: Egoitz Castillo <egoitz.castillo <at> openbravo.com> Date: Fri Apr 01 18:05:39 2011 +0200 URL: http://code.openbravo.com/erp/stable/2.50/rev/944b0da4c10e03877b2ce01709e0031e84212830 [^] Fixes issue 0015888: Wrong "adjusted price" when using price adjustments Now the difference is calculated based on the price standard. --- M src-db/database/model/triggers/C_ORDERLINE_TRG2.xml M src/org/openbravo/erpCommon/ad_callouts/SL_Order_Amt.java ---

(0035512) maite (developer) 2011-04-04 10:34	verified

Issue History
Date Modified	Username	Field	Change
2011-02-09 10:11	maite	New Issue
2011-02-09 10:11	maite	Assigned To	=> adrianromero
2011-02-09 10:11	maite	Modules	=> Core
2011-03-18 09:32	jonalegriaesarte	Assigned To	adrianromero => jonalegriaesarte
2011-03-18 09:33	jonalegriaesarte	Status	new => scheduled
2011-03-18 09:33	jonalegriaesarte	fix_in_branch	=> pi
2011-03-22 11:48	jonalegriaesarte	File Added: 15888.diff
2011-03-22 11:48	jonalegriaesarte	Note Added: 0035140
2011-03-22 11:48	jonalegriaesarte	Status	scheduled => resolved
2011-03-22 11:48	jonalegriaesarte	Fixed in Version	=> 2.50MP29
2011-03-22 11:48	jonalegriaesarte	Fixed in SCM revision	=> in attached diff
2011-03-22 11:48	jonalegriaesarte	Resolution	open => fixed
2011-04-01 18:00	jonalegriaesarte	Relationship added	related to 0016613
2011-04-01 18:06	hgbot	Checkin
2011-04-01 18:06	hgbot	Note Added: 0035481
2011-04-01 18:06	hgbot	Fixed in SCM revision	in attached diff => http://code.openbravo.com/erp/stable/2.50/rev/944b0da4c10e03877b2ce01709e0031e84212830 [^]
2011-04-04 10:34	maite	Note Added: 0035512
2011-04-04 10:35	maite	Status	resolved => closed
2011-04-04 10:35	maite	Fixed in Version	2.50MP29 =>
2011-04-05 00:00	anonymous	sf_bug_id	0 => 3274924

Copyright © 2000 - 2009 MantisBT Group