Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0015871

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] I. Performance

major

always

2011-02-07 12:05

2011-05-18 11:25

Reporter

jonalegriaesarte

View Status

public

Assigned To

mirurita

Priority

urgent

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

pi

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

2.50MP26

SCM revision

Review Assigned To

Web browser

Modules

Advanced Payables and Receivables Mngmt

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0015871: Performace problem when launching update.database -Dforce=true due to the module script

Description

There is a performance problem when launching update.database -Dforce=true due to the APRM's module script.

Steps To Reproduce

The problem appears when you define a big number of organizations (400 in this case) and you open periods to each organization (the problem appears when you open 5 periods to 5 organizations). The problem is in the insertPeriod method in file modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/CreateAccountingConfiguration_data.xsql, because this method is trying to insert a big amount of data, and the select to obtain the data takes much time.

Proposed Solution

We think that the insert could be changed as follows:

INSERT INTO c_periodcontrol(
                c_periodcontrol_id, ad_client_id, ad_org_id, isactive,
     created,
                createdby, updated, updatedby, c_period_id, docbasetype,
     periodstatus,
                periodaction, processing)
     select c_period.ad_client_id as ad_client_id, a.ad_org_id, 'Y',
     now(),
          '100', now(), '100', c_period.c_period_id, ad_ref_list.value
          , 'C' as status
          ,'N', 'N'
     from c_period
     , c_year,
     (select ad_org_id from ad_org where isperiodcontrolallowed = 'Y') a,
     ad_ref_list
     where c_period.c_year_id = c_year.c_year_id
     and c_year.c_calendar_id in (select c_calendar_id from ad_org
                where ad_org_id = ad_org_getcalendarowner(a.ad_org_id))
     and ad_ref_list.isactive='Y'
     and ad_ref_list.ad_reference_id = '183'
     and not exists (select 1
                from c_periodcontrol
                where c_periodcontrol.c_period_id = c_period.c_period_id
                and c_periodcontrol.docbasetype = ad_ref_list.value
                and c_periodcontrol.ad_org_id = a.ad_org_id)
     group by c_period.c_period_id, c_period.ad_client_id,
     ad_ref_list.value,
     a.ad_org_id

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on

backport

closed

mirurita

Performace problem when launching update.database -Dforce=true due to the module script

Notes
(0034595) hgbot (developer) 2011-03-07 10:17	Repository: erp/devel/pi Changeset: 7da8e24d6950d7b1fd3b3b5f44e7749c5a5c2b6c Author: Mikel Irurita <mikel.irurita <at> openbravo.com> Date: Mon Mar 07 10:16:23 2011 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/7da8e24d6950d7b1fd3b3b5f44e7749c5a5c2b6c [^] [APRM] Fixes issue 15871: improve performace modulescript CreateAccountingConfiguration --- M modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/CreateAccountingConfigurationData.class M modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/CreateAccountingConfiguration_data.xsql M modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/CreateAccountingConfigurationData.java M src-db/database/model/tables/C_PERIODCONTROL.xml ---

Issue History
Date Modified	Username	Field	Change
2011-02-07 12:05	jonalegriaesarte	New Issue
2011-02-07 12:05	jonalegriaesarte	Assigned To	=> eduardo_Argal
2011-02-07 12:05	jonalegriaesarte	Modules	=> Advanced Payables and Receivables Mngmt
2011-02-07 12:09	jonalegriaesarte	Issue Monitored: networkb
2011-02-09 12:24	jonalegriaesarte	Summary	Performace problem when launching update.database -Dforce=true due to the config script => Performace problem when launching update.database -Dforce=true due to the module script
2011-02-09 12:24	jonalegriaesarte	Description Updated	View Revisions
2011-03-03 11:44	mirurita	Assigned To	eduardo_Argal => mirurita
2011-03-03 11:44	mirurita	Status	new => scheduled
2011-03-03 11:44	mirurita	fix_in_branch	=> pi
2011-03-07 10:17	hgbot	Checkin
2011-03-07 10:17	hgbot	Note Added: 0034595
2011-03-07 10:17	hgbot	Status	scheduled => resolved
2011-03-07 10:17	hgbot	Resolution	open => fixed
2011-03-07 10:17	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/7da8e24d6950d7b1fd3b3b5f44e7749c5a5c2b6c [^]
2011-05-18 11:25	eduardo_Argal	Status	resolved => closed

Copyright © 2000 - 2009 MantisBT Group