0015808: Project profitability report does not detect whether there are conversion to hours or not

Notes
(0033949) adrianromero (manager) 2011-01-28 11:30 edited on: 2011-01-28 11:31	This issue is related with issue 15630. Because when solving this issue it has been removed the piece of code that must do the check of conversion to hours. This check does not work in the current form and must be refactored and implemented. The piece of code is commented in the code.

(0048382) dmiguelez (developer) 2012-05-04 14:40	Test Plan Login as Openbravo/openbravo Define a new Salary Category: Consultant Assign it a Cost of: * Cost = 60 * Cost UOM = per Hour * Starting Date = 01-01-2012 Move to Business Partner. Select John Smith and , in the Employee tab, in the Cost Salary Category tab, assign it the previous Salary category from Starting Date = 01-01-2012 Create a new product * Name = Consultancy * UOM = Day * Product Category = Others * Tax Category = Exempt * Product Type = Service Create a new product * Name = Consultancy2 * UOM = Week * Product Category = Others * Tax Category = Exempt * Product Type = Service Create a new product * Name = Travel * UOM = Week * Product Category = Others * Tax Category = Exempt * Product Type = Expense Type Create a new Multiphase Project * Organization = F&B US * Name = My Project * Sales Representative = John Smith * Business Partner = Healthy Food Supermarkets Create a new Phase in the Project Phase tab * Name = Phase Change Project Status to Order Create an Expense Sheet * Organization = F&B US * Employee = John Smith Create a new Line * Time Sheet = Y * Product = Consultancy (UOM is changed to Day) * Quantity = 3 * Project = My Project Click on Process Expenses Report project profitability * Organization = F&B US * Project = My Project Click on HTML Format and realize that in the pop up an error message is shown telling that there is no conversion rate for a unit to hours. Create new Unit of Measure conversion rate (The tab Conversion in the Window Unit of Measure may be inactive. If that is the case, login as System Admin to activate it) In Unit of Measure window select Day. Create a new line in Conversion * To UOM = Hour * Multiple Rate By = 8 Run the previous report again with the same parameters. Now there should be no errors, and in the Services \|\| Cost column, in the Real row should be an amount shown different from 0 Create Expense sheet * Organization = F&B US * Employee = John Smith Create a new Line * Time Sheet = N * Product = Travel (UOM is changed to Week) * Quantity = 3 * Project = My Project Click on Process Expenses Run the previous report again with the same parameters. Now there should be no errors, and in the Services \|\| Cost column, in the Real row should be an amount shown different from 0 Create an Expense Sheet * Organization = F&B US * Employee = John Smith Create a new Line * Time Sheet = Y * Product = Consultancy2 (UOM is changed to Week) * Quantity = 5 * Project = My Project DO NOT click on Process Expenses Run the previous report again with the same parameters. Now there should be no errors, and in the Services \|\| Cost column, in the Real row should be an amount shown different from 0 Move back to the previous Expense Sheet and click on Proces Expenses Run the previous report again with the same parameters. An error message is shown telling that there is no conversion rate for a unit to hours.

(0052106) hgbot (developer) 2012-09-14 09:36	Repository: erp/devel/pi Changeset: ba1f0e76db040775205c9f9b8c1a3dc078ea4225 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Thu May 24 13:28:08 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/ba1f0e76db040775205c9f9b8c1a3dc078ea4225 [^] Fixes issue 0015808: Checks if there exists a conversion or not to hours if there is a time sheet. --- M src-db/database/sourcedata/AD_MESSAGE.xml M src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitabilityJR.java ---

(0052107) naiaramartinez (developer) 2012-09-14 09:39	Code review + testing OK

(0052751) hudsonbot (developer) 2012-09-26 17:19	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b780e90c6452 [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2011-01-28 11:27	adrianromero	New Issue
2011-01-28 11:27	adrianromero	Assigned To	=> adrianromero
2011-01-28 11:27	adrianromero	Modules	=> Core
2011-01-28 11:27	adrianromero	Relationship added	related to 0015630
2011-01-28 11:30	adrianromero	Note Added: 0033949
2011-01-28 11:31	adrianromero	Note Edited: 0033949	View Revisions
2011-01-28 11:31	adrianromero	Issue cloned	0015809
2011-01-28 11:31	adrianromero	Relationship added	blocks 0015809
2011-01-31 10:48	adrianromero	Status	new => scheduled
2011-01-31 10:48	adrianromero	fix_in_branch	=> pi
2011-01-31 10:49	adrianromero	Issue cloned	0015819
2011-01-31 10:49	adrianromero	Relationship added	blocks 0015819
2011-06-03 10:58	dalsasua	Assigned To	adrianromero => dalsasua
2011-07-20 18:16	dalsasua	Assigned To	dalsasua => jonalegriaesarte
2012-02-15 19:05	iciordia	Assigned To	jonalegriaesarte => vmromanos
2012-02-16 15:54	vmromanos	Tag Attached: VMA-Reviewed
2012-05-02 10:47	dmiguelez	Assigned To	vmromanos => dmiguelez
2012-05-04 14:40	dmiguelez	Note Added: 0048382
2012-09-14 09:36	hgbot	Checkin
2012-09-14 09:36	hgbot	Note Added: 0052106
2012-09-14 09:36	hgbot	Status	scheduled => resolved
2012-09-14 09:36	hgbot	Resolution	open => fixed
2012-09-14 09:36	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/ba1f0e76db040775205c9f9b8c1a3dc078ea4225 [^]
2012-09-14 09:39	naiaramartinez	Closed by	=> naiaramartinez
2012-09-14 09:39	naiaramartinez	Note Added: 0052107
2012-09-14 09:39	naiaramartinez	Status	resolved => closed
2012-09-26 17:19	hudsonbot	Checkin
2012-09-26 17:19	hudsonbot	Note Added: 0052751