Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0015808Openbravo ERP08. Project and service managementpublic2011-01-28 11:272012-09-26 17:19
adrianromero 
dmiguelez 
normalmajoralways
closedfixed 
20Ubuntu 10.04
pi 
 
naiaramartinez
Core
No
0015808: Project profitability report does not detect whether there are conversion to hours or not
In a time sheet where there are included products with a UOM that do not have a conversion to hours, the Project Profitability report does not detect this situation and just sums 0.

In this case, when launching the report it must show a message explaining that there are timesheets with products in the report that does not have conversion to hours.
VMA-Reviewed
related to defect 00156302.50MP26 closed adrianromero Project profitability report is not working under some circumstances 
blocks backport 0015809 closed mirurita Project profitability report does not detect whether there are conversion to hours or not 
blocks backport 00158192.50MP27 closed mirurita Project profitability report does not detect whether there are conversion to hours or not 
Issue History
2011-01-28 11:27adrianromeroNew Issue
2011-01-28 11:27adrianromeroAssigned To => adrianromero
2011-01-28 11:27adrianromeroModules => Core
2011-01-28 11:27adrianromeroRelationship addedrelated to 0015630
2011-01-28 11:30adrianromeroNote Added: 0033949
2011-01-28 11:31adrianromeroNote Edited: 0033949bug_revision_view_page.php?bugnote_id=0033949#r1458
2011-01-28 11:31adrianromeroIssue cloned0015809
2011-01-28 11:31adrianromeroRelationship addedblocks 0015809
2011-01-31 10:48adrianromeroStatusnew => scheduled
2011-01-31 10:48adrianromerofix_in_branch => pi
2011-01-31 10:49adrianromeroIssue cloned0015819
2011-01-31 10:49adrianromeroRelationship addedblocks 0015819
2011-06-03 10:58dalsasuaAssigned Toadrianromero => dalsasua
2011-07-20 18:16dalsasuaAssigned Todalsasua => jonalegriaesarte
2012-02-15 19:05iciordiaAssigned Tojonalegriaesarte => vmromanos
2012-02-16 15:54vmromanosTag Attached: VMA-Reviewed
2012-05-02 10:47dmiguelezAssigned Tovmromanos => dmiguelez
2012-05-04 14:40dmiguelezNote Added: 0048382
2012-09-14 09:36hgbotCheckin
2012-09-14 09:36hgbotNote Added: 0052106
2012-09-14 09:36hgbotStatusscheduled => resolved
2012-09-14 09:36hgbotResolutionopen => fixed
2012-09-14 09:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ba1f0e76db040775205c9f9b8c1a3dc078ea4225 [^]
2012-09-14 09:39naiaramartinezClosed by => naiaramartinez
2012-09-14 09:39naiaramartinezNote Added: 0052107
2012-09-14 09:39naiaramartinezStatusresolved => closed
2012-09-26 17:19hudsonbotCheckin
2012-09-26 17:19hudsonbotNote Added: 0052751

Notes
(0033949)
adrianromero   
2011-01-28 11:30   
(edited on: 2011-01-28 11:31)
This issue is related with issue 15630. Because when solving this issue it has been removed the piece of code that must do the check of conversion to hours. This check does not work in the current form and must be refactored and implemented. The piece of code is commented in the code.

(0048382)
dmiguelez   
2012-05-04 14:40   
Test Plan

Login as Openbravo/openbravo

Define a new Salary Category: Consultant

Assign it a Cost of:
* Cost = 60
* Cost UOM = per Hour
* Starting Date = 01-01-2012
Move to Business Partner.
Select John Smith and , in the Employee tab, in the Cost Salary Category tab, assign it the previous Salary category from Starting Date = 01-01-2012


Create a new product

* Name = Consultancy
* UOM = Day
* Product Category = Others
* Tax Category = Exempt
* Product Type = Service


Create a new product

* Name = Consultancy2
* UOM = Week
* Product Category = Others
* Tax Category = Exempt
* Product Type = Service


Create a new product

* Name = Travel
* UOM = Week
* Product Category = Others
* Tax Category = Exempt
* Product Type = Expense Type


Create a new Multiphase Project

* Organization = F&B US
* Name = My Project
* Sales Representative = John Smith
* Business Partner = Healthy Food Supermarkets
Create a new Phase in the Project Phase tab
* Name = Phase
Change Project Status to Order


Create an Expense Sheet

* Organization = F&B US
* Employee = John Smith
Create a new Line
* Time Sheet = Y
* Product = Consultancy (UOM is changed to Day)
* Quantity = 3
* Project = My Project
Click on Process Expenses


Report project profitability

* Organization = F&B US
* Project = My Project
Click on HTML Format and realize that in the pop up an error message is shown telling that there is no conversion rate for a unit to hours.


Create new Unit of Measure conversion rate

(The tab Conversion in the Window Unit of Measure may be inactive. If that is the case, login as System Admin to activate it)
In Unit of Measure window select Day.
Create a new line in Conversion
* To UOM = Hour
* Multiple Rate By = 8


Run the previous report again with the same parameters.
Now there should be no errors, and in the Services || Cost column, in the Real row should be an amount shown different from 0


Create Expense sheet

* Organization = F&B US
* Employee = John Smith
Create a new Line
* Time Sheet = N
* Product = Travel (UOM is changed to Week)
* Quantity = 3
* Project = My Project
Click on Process Expenses


Run the previous report again with the same parameters.
Now there should be no errors, and in the Services || Cost column, in the Real row should be an amount shown different from 0


Create an Expense Sheet

* Organization = F&B US
* Employee = John Smith
Create a new Line
* Time Sheet = Y
* Product = Consultancy2 (UOM is changed to Week)
* Quantity = 5
* Project = My Project
DO NOT click on Process Expenses


Run the previous report again with the same parameters.
Now there should be no errors, and in the Services || Cost column, in the Real row should be an amount shown different from 0


Move back to the previous Expense Sheet and click on Proces Expenses


Run the previous report again with the same parameters.
An error message is shown telling that there is no conversion rate for a unit to hours.
(0052106)
hgbot   
2012-09-14 09:36   
Repository: erp/devel/pi
Changeset: ba1f0e76db040775205c9f9b8c1a3dc078ea4225
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu May 24 13:28:08 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ba1f0e76db040775205c9f9b8c1a3dc078ea4225 [^]

Fixes issue 0015808: Checks if there exists a conversion or not
to hours if there is a time sheet.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitabilityJR.java
---
(0052107)
naiaramartinez   
2012-09-14 09:39   
Code review + testing OK
(0052751)
hudsonbot   
2012-09-26 17:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b780e90c6452 [^]

Maturity status: Test