Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0015719
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] 09. Financial managementmajoralways2011-01-11 18:002011-02-28 13:43
ReportergmauleonView Statuspublic 
Assigned Todalsasua 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branch2.50Fixed in SCM revision00c537cdbb45
ProjectionnoneETAnoneTarget Version2.50MP26
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50MP25SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0015719: Payment monitor process fails

DescriptionIn some special scenario the payment monitor is failling. See steps to reporduce
Steps To Reproduce-Create a purchase invoice. For instance with amount 100€
-Create another purchase invoinces with the same amount but negative -100€
-Create a settlement incluiding both effects.
-In the same settlement include also some "Created payments"
-So in this scenario we have a pair of callcelled payment one calcelling the other and a some entries in the "created payments" tab
-Now return to the created invoices and try to launch the payment monitor process in the invoice header tab. Error image attached
Proposed Solution-The main error come from the class payment monitor line 205 [1]. In this line is trying to divide something with cancelledNotPaidAmount (0 in this case)




[1] https://code.openbravo.com/erp/devel/main/file/67254b289f54/src/org/openbravo/erpCommon/ad_process/PaymentMonitor.java#l205 [^]
TagsNo tags attached.
Attached Filesdiff file icon fix15719.diff [^] (2,069 bytes) 2011-01-27 17:23 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 00156172.50MP26 closeddalsasua Payment monitor process fails 

-  Notes
(0033798)
dalsasua (reporter)
2011-01-20 18:36

As part of the process of the payment monitor, system needs to determine whether a settlement is a cancellation settlement, or a transformation one. In the reported case, this cannot be determined, as it has got sum of canceled payments equals to zero, but do also have some created ones.
In order to fix the issue, I will consider this case, as a cancellation settlement, so debt is over, as we have all canceled payments sums zero.
(0033930)
dalsasua (reporter)
2011-01-27 17:23

The bug is fixed since days ago, but repository is frozen. I attach the patch, just in case is useful.
(0033981)
hgbot (developer)
2011-02-01 12:12

Repository: erp/stable/2.50
Changeset: 00c537cdbb45620490b1da1ccdc3cc44fabfa30c
Author: David Alsasua <david.alsasua <at> openbravo.com>
Date: Mon Jan 24 11:22:49 2011 +0100
URL: http://code.openbravo.com/erp/stable/2.50/rev/00c537cdbb45620490b1da1ccdc3cc44fabfa30c [^]

Fixes issue 15719: Payment monitor process fails.
If a payment monitor process founds a settlement where sum of the amounts of cancelled payments is zero, will interpretate that payment is paid

---
M src/org/openbravo/erpCommon/ad_process/PaymentMonitor.java
---
(0034420)
adrianromero (manager)
2011-02-28 13:43

Verified.

- Issue History
Date Modified Username Field Change
2011-01-20 18:29 dalsasua Type defect => backport
2011-01-20 18:29 dalsasua fix_in_branch => 2.50
2011-01-20 18:36 dalsasua Note Added: 0033798
2011-01-27 17:23 dalsasua File Added: fix15719.diff
2011-01-27 17:23 dalsasua Note Added: 0033930
2011-02-01 12:12 hgbot Checkin
2011-02-01 12:12 hgbot Note Added: 0033981
2011-02-01 12:12 hgbot Status scheduled => resolved
2011-02-01 12:12 hgbot Resolution open => fixed
2011-02-01 12:12 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/stable/2.50/rev/00c537cdbb45620490b1da1ccdc3cc44fabfa30c [^]
2011-02-28 13:43 adrianromero Note Added: 0034420
2011-02-28 13:43 adrianromero Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker