0015640: you are able to add a discount in an order completed

Notes
(0034201) hgbot (developer) 2011-02-15 14:10	Repository: erp/stable/2.50 Changeset: 920404a85fd06ea29ddec86715dfaa76de8364e4 Author: Adrián Romero <adrianromero <at> openbravo.com> Date: Tue Feb 15 14:08:06 2011 +0100 URL: http://code.openbravo.com/erp/stable/2.50/rev/920404a85fd06ea29ddec86715dfaa76de8364e4 [^] Fixes issue 0015640: you are able to add a discount in an order completed It as been added the current trigger for tables C_ORDER_DISCOUNT and C_INVOICE_DISCOUNT that checks if the document has been posted to the event INSERT --- M src-db/database/model/triggers/C_INVOICEDISCOUNT_TRG.xml M src-db/database/model/triggers/C_ORDERDISCOUNT_TRG.xml ---

(0034202) adrianromero (manager) 2011-02-15 14:11	* Testing the issue Kindly follow the steps to test and verify that cannot be added discounts to purchase orders completed or posted. Because there has been modified two triggers the following tests must be performed: - Test that cannot be added discounts in completed Purchase orders, Sales orders, Purchase invoices and sales invoices. - Test that discounts can be added, updated and removed in draft Purchase orders, Sales orders, Purchase invoices and sales invoices. * Other areas affected. There can be affected other processes that creates, updates or deletes discounts in orders and invoices.

(0034221) jonalegriaesarte (reporter) 2011-02-16 11:29	Verfied

(0034233) adrianromero (manager) 2011-02-16 14:58	Changes has been backed out because it causes a regression.

(0034263) adrianromero (manager) 2011-02-18 12:00	Cannot be implemented the this because of internal database technical details. Implementing the trigger functionality to avoid to create discounts in completed orders raises a "Mutating tables" exception when saving a new order with a business partner that has discounts. In any case this is a minor issue because new added discounts to completed orders does not affects any other functionality or flow.

Issue History
Date Modified	Username	Field	Change
2011-01-13 12:33	xabiermerino	New Issue
2011-01-13 12:33	xabiermerino	Assigned To	=> adrianromero
2011-01-13 12:33	xabiermerino	Modules	=> Core
2011-01-13 12:41	xabiermerino	Issue Monitored: networkb
2011-02-10 16:19	adrianromero	Status	new => scheduled
2011-02-10 16:19	adrianromero	fix_in_branch	=> pi
2011-02-10 16:19	adrianromero	Type	defect => backport
2011-02-10 16:19	adrianromero	fix_in_branch	pi =>
2011-02-10 16:19	adrianromero	Issue cloned	0015931
2011-02-10 16:19	adrianromero	Relationship added	blocks 0015931
2011-02-15 14:10	hgbot	Checkin
2011-02-15 14:10	hgbot	Note Added: 0034201
2011-02-15 14:10	hgbot	Status	scheduled => resolved
2011-02-15 14:10	hgbot	Resolution	open => fixed
2011-02-15 14:10	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/stable/2.50/rev/920404a85fd06ea29ddec86715dfaa76de8364e4 [^]
2011-02-15 14:11	adrianromero	Note Added: 0034202
2011-02-16 11:29	jonalegriaesarte	Note Added: 0034221
2011-02-16 11:29	jonalegriaesarte	Status	resolved => closed
2011-02-16 11:29	jonalegriaesarte	Fixed in Version	=> 2.50MP27
2011-02-16 14:58	adrianromero	Note Added: 0034233
2011-02-16 14:58	adrianromero	Status	closed => new
2011-02-16 14:58	adrianromero	Resolution	fixed => open
2011-02-16 14:58	adrianromero	Fixed in Version	2.50MP27 =>
2011-02-18 12:00	adrianromero	Note Added: 0034263
2011-02-18 12:00	adrianromero	Status	new => closed
2011-02-18 12:00	adrianromero	Resolution	open => suspended
2011-02-25 12:30	adrianromero	Issue cloned	0016057
2011-02-25 12:30	adrianromero	Relationship added	related to 0016057