Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0015631
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] 08. Project and service managementmajoralways2011-01-12 12:362011-01-28 11:21
ReporterpsarobeView Statuspublic 
Assigned Toadrianromero 
PriorityimmediateResolutionfixedFixed in Version2.50MP26
StatusclosedFix in branchpiFixed in SCM revision8993462177de
ProjectionnoneETAnoneTarget Version2.50MP26
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50MP23SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0015631: Project profitability report is not working under some circumstances

DescriptionProject profitability report is not working under some circumstances

Steps To ReproduceSteps to reproduce further error on this issue:

Create a new Project (either Service or Multiphase)

Set values for:

o Value, Name

o Bus. Partner

o Sales Represetative

o Planned Service Revenue

o Planned Expenses

o Services Provided Cost

o Outsourced Cost

o Planned Reinvoiced Expenses
xecute Project Profitability Report -> Fails: Error: There is no Conversion Rate defined for Day to Hour.

If you enter a Time Sheet for this project, then the report will work.
TagsRegression
Attached Filespng file icon image.PNG [^] (25,470 bytes) 2011-01-27 14:04


png file icon image2.PNG [^] (35,721 bytes) 2011-01-27 14:05

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0010690 closedadrianromero Expense Report and Project Profitability Reports display hours even if time sheet lines are in days 
related to backport 0015809 closedmirurita Project profitability report does not detect whether there are conversion to hours or not 
blocks defect 00156302.50MP26 closedadrianromero Project profitability report is not working under some circumstances 

-  Notes
(0033629)
hgbot (developer)
2011-01-13 18:24

 Repository: erp/stable/2.50
Changeset: b4fbdd3b66a423259dc80ab8cfb07a72276cef2a
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Jan 13 18:23:22 2011 +0100
URL: http://code.openbravo.com/erp/stable/2.50/rev/b4fbdd3b66a423259dc80ab8cfb07a72276cef2a [^]

Fixes issue 0015631: Project profitability report is not working under some circumstances
It has been modified the Profitability report and Expenses report to not to raise the conversion rate error when it is not needed.

---
M src/org/openbravo/erpCommon/ad_reports/ReportExpense.java
M src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitabilityJR.java
---
(0033631)
adrianromero (manager)
2011-01-13 18:30

 * Testing the issue

Verify that now projects with no time sheets can execute the Profitability project and also the Expenses project.

Verify also that the related issue 10690 works as expected. days are properly converted to hours in both reports.

* Other areas affected

Only has been modified the Expenses report and Project Profitability report.
(0033680)
psarobe (manager)
2011-01-17 12:31

 It is still failing in this scenario:

If you add hours against a product which UOM is hours then it is not working. The error is the same: There is no conversion rate between hours and days. It makes no sense since everything is in hours
(0033685)
hgbot (developer)
2011-01-17 14:22

 Repository: erp/stable/2.50
Changeset: 62416180650ef4562c0f2beb5cb2410f6c74ab80
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Jan 17 14:21:09 2011 +0100
URL: http://code.openbravo.com/erp/stable/2.50/rev/62416180650ef4562c0f2beb5cb2410f6c74ab80 [^]

Fixes issue 0015631: Project profitability report is not working under some circumstances
It has been added the case of expenses reported in hours

---
M src/org/openbravo/erpCommon/ad_reports/ReportExpense.java
M src/org/openbravo/erpCommon/ad_reports/ReportExpense_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitabilityJR.java
---
(0033687)
adrianromero (manager)
2011-01-17 14:25

 * Testing the issue

It has to be included the case of testing the scenario described in the note c33680
(0033691)
hgbot (developer)
2011-01-17 15:51

 Repository: erp/stable/2.50
Changeset: 60e0a23acc18b6aa6e294735fd70a68fa9404014
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Jan 17 15:51:31 2011 +0100
URL: http://code.openbravo.com/erp/stable/2.50/rev/60e0a23acc18b6aa6e294735fd70a68fa9404014 [^]

Fixes issue 0015631: Project profitability report is not working under some circumstances
Fixed
Fixing sql sentence

---
M src/org/openbravo/erpCommon/ad_reports/ReportExpense_data.xsql
---
(0033911)
psarobe (manager)
2011-01-27 13:05

 The fix is not correct under this scenario:

1. I create a product H in hours
2. I create a product D in days
3. I have a conversion from hours to Days and from Days to Hours (1 day-->8 hours)
4. I create a salary cost (this is always in hours). 1 hour= 60€
5. I create a expense sheet where:
  5.1 Product H (hours) with quantity = 100
  5.2 Product D (Days) with quantity = 3 (3x8)= 24 hours
6. When you execute the profitability report it gives you this result:
  6.1 Product H 100x0.125x60=750 ->> This is wrong. It is multiplying by 0.125 which is the conversion between Hours to day and since the product is in hours it shouldn't do anything. The correct thing would be 100x60=6000
  6.2 Product D 3x8x60= 1440
(0033918)
psarobe (manager)
2011-01-27 14:04

 More things in this issue:

If I execute the project profitability report instead of summarize both lines it splits them. See image.png and image2.png
(0033946)
hgbot (developer)
2011-01-28 10:13

 Repository: erp/stable/2.50
Changeset: 8993462177de08d0de83111d27eadc221b373276
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Jan 28 10:11:23 2011 +0100
URL: http://code.openbravo.com/erp/stable/2.50/rev/8993462177de08d0de83111d27eadc221b373276 [^]

Fixes issue 0015631: Project profitability report is not working under some circumstances
It has been modified properly the UOM to convert to take always hours and has been restored the gropping on the Profitability report SQL sentence to remove the UOM. This sentence must be grouping only by project

---
M src/org/openbravo/erpCommon/ad_reports/ReportExpense_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitabilityJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitability_data.xsql
---
(0033948)
psarobe (manager)
2011-01-28 11:21

 Works fine

- Issue History
Date Modified Username Field Change
2011-01-12 12:37 psarobe Type defect => backport
2011-01-12 12:37 psarobe fix_in_branch => 2.50
2011-01-13 18:24 hgbot Checkin
2011-01-13 18:24 hgbot Note Added: 0033629
2011-01-13 18:24 hgbot Status scheduled => resolved
2011-01-13 18:24 hgbot Resolution open => fixed
2011-01-13 18:24 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/stable/2.50/rev/b4fbdd3b66a423259dc80ab8cfb07a72276cef2a [^]
2011-01-13 18:30 adrianromero Note Added: 0033631
2011-01-13 18:31 adrianromero Relationship added related to 0010690
2011-01-17 12:31 psarobe Note Added: 0033680
2011-01-17 12:31 psarobe Status resolved => new
2011-01-17 12:31 psarobe Resolution fixed => open
2011-01-17 14:22 hgbot Checkin
2011-01-17 14:22 hgbot Note Added: 0033685
2011-01-17 14:22 hgbot Status new => resolved
2011-01-17 14:22 hgbot Resolution open => fixed
2011-01-17 14:22 hgbot Fixed in SCM revision http://code.openbravo.com/erp/stable/2.50/rev/b4fbdd3b66a423259dc80ab8cfb07a72276cef2a [^] => http://code.openbravo.com/erp/stable/2.50/rev/62416180650ef4562c0f2beb5cb2410f6c74ab80 [^]
2011-01-17 14:25 adrianromero Note Added: 0033687
2011-01-17 15:51 hgbot Checkin
2011-01-17 15:51 hgbot Note Added: 0033691
2011-01-17 15:51 hgbot Fixed in SCM revision http://code.openbravo.com/erp/stable/2.50/rev/62416180650ef4562c0f2beb5cb2410f6c74ab80 [^] => http://code.openbravo.com/erp/stable/2.50/rev/60e0a23acc18b6aa6e294735fd70a68fa9404014 [^]
2011-01-26 17:20 adrianromero Tag Attached: Regression
2011-01-26 17:21 adrianromero version 2.50MP24 => 2.50MP23
2011-01-27 13:05 psarobe Note Added: 0033911
2011-01-27 13:05 psarobe Status resolved => new
2011-01-27 13:05 psarobe Resolution fixed => open
2011-01-27 14:04 psarobe Note Added: 0033918
2011-01-27 14:04 psarobe File Added: image.PNG
2011-01-27 14:05 psarobe File Added: image2.PNG
2011-01-27 14:05 psarobe Status new => scheduled
2011-01-27 14:05 psarobe fix_in_branch 2.50 => pi
2011-01-28 10:13 hgbot Checkin
2011-01-28 10:13 hgbot Note Added: 0033946
2011-01-28 10:13 hgbot Status scheduled => resolved
2011-01-28 10:13 hgbot Resolution open => fixed
2011-01-28 10:13 hgbot Fixed in SCM revision http://code.openbravo.com/erp/stable/2.50/rev/60e0a23acc18b6aa6e294735fd70a68fa9404014 [^] => http://code.openbravo.com/erp/stable/2.50/rev/8993462177de08d0de83111d27eadc221b373276 [^]
2011-01-28 11:21 psarobe Note Added: 0033948
2011-01-28 11:21 psarobe Status resolved => closed
2011-01-28 11:21 psarobe Fixed in Version => 2.50MP26
2011-01-28 11:32 adrianromero Relationship added related to 0015809

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker