Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0015255
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 01. General setupminoralways2010-11-21 22:292012-05-25 12:10
ReportertgarciaView Statuspublic 
Assigned Tomarvintm 
PriorityhighResolutionfixedFixed in Version3.0MP12
StatusclosedFix in branchFixed in SCM revision26977a15e890
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionCommunity ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0015255: erpCommon Utility class doesn't retrieve Client Documentation Image

Descriptionthis is related src.org.openbravo.erpCommon.utility.Utility.java, when invoking the getImageLogo function (line 2637 and following) with "yourcompanydoc" as 1st argument. The expected behaviour would be:
1- if there's a "org" argument, get the doc image for the organization
2- else if exists a doc image for current client, return it
3- else return default client's image

Step 2 is not implemented, so there is no way to get the client's document image from the api.
Steps To Reproducefollow the steps on this page from the wiki:

http://wiki.openbravo.com/wiki/ERP/2.50/Developers_Guide/How_to_change_an_existing_report [^]
Proposed Solutionadd the following lines to src.org.openbravo.erpCommon.utility.Utility.java, after line 2667:

        if (img == null) {
          img = OBDal.getInstance().get(ClientInformation.class,
              OBContext.getOBContext().getCurrentClient().getId()).getYourCompanyDocumentImage();
        }

(this code is syntacticly validated but was not tested in any other way)
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0048454)
hgbot (developer)
2012-05-08 15:59

 Repository: erp/devel/pi
Changeset: 26977a15e890b8db3a12014218865b5aeebb820a
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue May 08 15:57:47 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/26977a15e890b8db3a12014218865b5aeebb820a [^]

Fixed issue 15255. Client image will be retrieved if there is no org image.

---
M src/org/openbravo/erpCommon/utility/Utility.java
---
(0048513)
AugustoMauch (manager)
2012-05-09 16:21

 Code reviewed and verified in pi@e720f25cba62
(0049053)
hudsonbot (developer)
2012-05-25 12:10

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2010-11-21 22:29 tgarcia New Issue
2010-11-21 22:29 tgarcia Assigned To => adrianromero
2011-06-03 10:58 dalsasua Assigned To adrianromero => dalsasua
2011-07-20 18:13 dalsasua Assigned To dalsasua => jonalegriaesarte
2011-09-19 11:35 psarobe Priority normal => high
2011-09-19 11:35 psarobe Status new => scheduled
2012-02-15 19:04 iciordia Assigned To jonalegriaesarte => vmromanos
2012-02-16 16:20 vmromanos Assigned To vmromanos => alostale
2012-03-30 15:30 alostale Assigned To alostale => marvintm
2012-05-08 15:59 hgbot Checkin
2012-05-08 15:59 hgbot Note Added: 0048454
2012-05-08 15:59 hgbot Status scheduled => resolved
2012-05-08 15:59 hgbot Resolution open => fixed
2012-05-08 15:59 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/26977a15e890b8db3a12014218865b5aeebb820a [^]
2012-05-09 16:21 AugustoMauch Note Added: 0048513
2012-05-09 16:21 AugustoMauch Status resolved => closed
2012-05-09 16:22 AugustoMauch Fixed in Version => 3.0MP12
2012-05-25 12:10 hudsonbot Checkin
2012-05-25 12:10 hudsonbot Note Added: 0049053

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker