Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0015140
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementminoralways2010-11-09 11:422012-05-25 12:10
ReporterdalsasuaView Statuspublic 
Assigned Tovmromanos 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revision35f4310c1d25
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabaseOracleJava version1.6.0_14
OS VersionUbuntu 9.04Database version11.1.0.6.0 SEAnt version1.7.1
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0015140: C_TaxPayment_Post procedure retrieves incorrectly the GL Categories

DescriptionIn C_TaxPayment_Post we can see:
      select max(gl_category_id)
      into v_gl_category_id
      from gl_category where name='Standard';
where is not filtering by ad_client_id, so it could retrieve the gl_category_id belonging to a different client. Actually, after Initial Client Setup refactor project, this gl_category elements can be defined at an organization level.
Proposed SolutionChange mentioned sql by another one that:
1.- Tries to retrieve the gl_category elements belonging to the suitable organization.
2.- If none, then belonging to the suitable client.
3.- If none, the one defined for client with ad_client_id='0'
TagsVMA-Reviewed
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0048370)
naiaramartinez (developer)
2012-05-04 11:40

 Test Plan:
  Go to Tax Register Type window and create new record:
     Organization: F&B US, Inc.
     Sales transaction: no
     The selected G/L item has to have an accounting schema.
  Go to lines tab create new record:
     tax: NY Sales Tax - US State Sales Tax
     Document type: AP Invoice
  Create another tax regster type:
     Organization: F&B US, Inc.
     Sales transaction: yes
     The selected G/L item has to have an accounting schema.
  Go to lines tab create new record:
     tax: NY Sales Tax - US State Sales Tax
     Document type: AR Invoice

  Go to G/L Category window:
     Select the record that has 'Standard' as name.
     Chagne the Organziation and set 'F&B España - Región Norte'

  Go to Tax Payment window and create a new record:
     Organization: F&B US, Inc.
  Press Process button and notice that an error message is shown.

  Now, go back to G/L Category window:
     Select the record that has 'Standard' as name.
     Change the Organziation and set '*'
  
  Go back to Tax Payment window. Select the newly created record. Press Process button. Notice that now the tax payment is processed.
(0048478)
hgbot (developer)
2012-05-08 19:20

 Repository: erp/devel/pi
Changeset: 35f4310c1d259e49734859ac07bc71c378ce8dae
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Tue May 08 14:02:33 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/35f4310c1d259e49734859ac07bc71c378ce8dae [^]

fixed bug 15140 in c_taxPayment_post add an organization and client validation
this is done to retrieve correctly the GL Categories

---
M src-db/database/model/functions/C_TAXPAYMENT_POST.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0048480)
mirurita (developer)
2012-05-08 19:21

 code review + testing OK
(0049067)
hudsonbot (developer)
2012-05-25 12:10

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2010-11-09 11:42 dalsasua New Issue
2010-11-09 11:42 dalsasua Assigned To => dalsasua
2011-07-20 18:17 dalsasua Assigned To dalsasua => jonalegriaesarte
2011-10-29 18:28 psarobe Status new => scheduled
2011-10-29 18:28 psarobe fix_in_branch => pi
2012-02-15 19:04 iciordia Assigned To jonalegriaesarte => vmromanos
2012-02-16 17:22 vmromanos Tag Attached: VMA-Reviewed
2012-05-04 11:40 naiaramartinez Note Added: 0048370
2012-05-08 19:20 hgbot Checkin
2012-05-08 19:20 hgbot Note Added: 0048478
2012-05-08 19:20 hgbot Status scheduled => resolved
2012-05-08 19:20 hgbot Resolution open => fixed
2012-05-08 19:20 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/35f4310c1d259e49734859ac07bc71c378ce8dae [^]
2012-05-08 19:21 mirurita Note Added: 0048480
2012-05-08 19:21 mirurita Status resolved => closed
2012-05-25 12:10 hudsonbot Checkin
2012-05-25 12:10 hudsonbot Note Added: 0049067

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker