Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0015120
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajorhave not tried2010-11-05 14:532010-12-09 16:07
ReporterjonalegriaesarteView Statuspublic 
Assigned Tosivaraman 
PrioritynormalResolutionfixedFixed in Version2.50MP24
StatusclosedFix in branchFixed in SCM revision08569dbf2199
ProjectionnoneETAnoneTarget Version2.50MP25
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50MP23SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0015120: Wrong message when creating a debt payment

DescriptionA wrong message appears when you create a debt payment in a sales order.
Steps To Reproduce1- Create a new sales order:
Document type: standard order
Invoice terms: immediate

2- Create one line:
Product: hat
Quantity: 1

3- Create one line:
Product: beer
Quantity: -1

4- In debt payment tab, create a new debt payment

5- Save. The error OrderCompletelyInvoiced, appears, but it does not exist an invoice.
Proposed SolutionThe problem is in C_DEBT_PAYMENT_TRG.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0032471)
adrianromero (manager)
2010-11-08 16:50

I guess that the C_DEBT_PAYMENT_TRIGGER is not checking properly the condition when an order has been invoiced or not. It has to be reviewed that the trigger and review this condition.
(0032657)
hgbot (developer)
2010-11-17 11:39

Repository: erp/devel/pi
Changeset: 08569dbf2199b6456807a77ff8600d1970826716
Author: Sivaraman Rajagopal <sivaraman.rajagopal <at> openbravo.com>
Date: Wed Nov 17 16:07:39 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/08569dbf2199b6456807a77ff8600d1970826716 [^]

Fixes issue 15120: Wrong message when creating a debt payment

Root-cause:
C_DEBT_PAYMENT_TRG is calculating the un-invoiced order quantity by adding up all together. Since we 1 and -1, the summation results 0 which means no order is pending to be invoiced. Hence, 'OrderCompletelyInvoiced' error message is displayed.

Solution:
It seems negative quantity needs to be carefully handled. When the difference between ordered quantity and invoiced quantity is calculated, we have to consider the absolute value of quantities irrespective of its sign.

Impacts:
None

---
M src-db/database/model/triggers/C_DEBT_PAYMENT_TRG.xml
---
(0032658)
sivaraman (reporter)
2010-11-17 11:57

Steps to test:

1. Create new Sales Order
2. Add the following lines
   Product : hat
   Quantity: 1

   Product : beer
   Quantity: -1
3. Create new Payment and verify if it can be successfully saved.

*Also verify if error message is shown when we create Payment for invoiced order with above lines
(0032687)
hudsonbot (developer)
2010-11-17 19:41

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/08569dbf2199 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/b7bb18bb9d40 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18908.obx [^]
(0032700)
psarobe (manager)
2010-11-18 11:45

Works fine

- Issue History
Date Modified Username Field Change
2010-11-05 14:53 jonalegriaesarte New Issue
2010-11-05 14:53 jonalegriaesarte Assigned To => adrianromero
2010-11-05 14:54 jonalegriaesarte Issue Monitored: networkb
2010-11-05 14:54 jonalegriaesarte version pi => 2.50MP23
2010-11-08 16:50 adrianromero Note Added: 0032471
2010-11-17 11:23 sivaraman Assigned To adrianromero => sivaraman
2010-11-17 11:39 hgbot Checkin
2010-11-17 11:39 hgbot Note Added: 0032657
2010-11-17 11:39 hgbot Status new => resolved
2010-11-17 11:39 hgbot Resolution open => fixed
2010-11-17 11:39 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/08569dbf2199b6456807a77ff8600d1970826716 [^]
2010-11-17 11:57 sivaraman Note Added: 0032658
2010-11-17 19:41 hudsonbot Checkin
2010-11-17 19:41 hudsonbot Note Added: 0032687
2010-11-18 11:45 psarobe Note Added: 0032700
2010-11-18 11:45 psarobe Status resolved => closed
2010-11-18 11:45 psarobe Fixed in Version => 2.50MP23
2010-11-18 11:45 psarobe Fixed in Version 2.50MP23 => 2.50MP24
2010-12-09 16:07 anonymous sf_bug_id 0 => 3133547


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker