Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0015064 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 02. Master data management | major | always | 2010-10-28 12:38 | 2011-05-24 10:57 | |||
| Reporter | jonalegriaesarte | View Status | public | |||||
| Assigned To | adrianromero | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 19271f33c4b5 | ||||
| Projection | none | ETA | none | Target Version | 2.50MP25 | |||
| OS | Any | Database | PostgreSQL | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | 2.50MP22 | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0015064: Performance problem in role window when there are many warehouses defined | |||||||
| Description | We have an application with more that 200 warehouses defined. When the user tries to open the role window (the first link in the menu), the window takes a lot of time. | |||||||
| Steps To Reproduce | - Create some warehouses (we have more that 200). - Access to role information (first link in the menu) - Notice that it takes a lot of time. Note that the action save in this window takes a lot of time, too. | |||||||
| Tags | closingMay2011 | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0032322) adrianromero (manager) 2010-10-28 18:52 |
The performance problem described is located in the SQL sentence executed in src/org/openbravo/erpCommon/ad_formsWarehouse_data.xsql because it gets the full list of warehouses by client and by role. For example, if the logged user has 10 roles and 10 clients and 200 warehouses it gets 10x10x200 = 20000 records !!!! This window has to be refactored to load the warehouse list when client and role is selected and not to load everything when opening the window. |
|
(0032618) hgbot (developer) 2010-11-15 18:01 |
Repository: erp/devel/pi Changeset: 1b773d75b4848538fca07665a40333b136c10fc6 Author: Adrián Romero <adrianromero <at> openbravo.com> Date: Mon Nov 15 17:59:06 2010 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/1b773d75b4848538fca07665a40333b136c10fc6 [^] Fixes issue 0015064: Performance problem in role window when there are many warehouses defined It has beem modified the way warehouse selector is loaded to load only the needed elements every time the client and the role changes instead of loading all posible combinations at loading time --- M src/org/openbravo/erpCommon/ad_forms/Role.html M src/org/openbravo/erpCommon/ad_forms/Role.java M src/org/openbravo/erpCommon/ad_forms/Role.xml M src/org/openbravo/erpCommon/ad_forms/Warehouse_data.xsql --- |
|
(0032620) adrianromero (manager) 2010-11-15 18:03 |
* Testing the issue Load 200 warehouses and follow the steps to reproduce. Now, the load time of warehouses in the selector is quick. * Other areas affected Only the role window is affected. |
|
(0032626) hudsonbot (developer) 2010-11-15 22:26 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/1b773d75b484 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/109294950618 [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18901.obx [^] |
|
(0032643) hgbot (developer) 2010-11-16 19:01 |
Repository: erp/devel/pi Changeset: 7962725ee825d4e4d3416f07d178cf8336a74497 Author: Adrián Romero <adrianromero <at> openbravo.com> Date: Tue Nov 16 18:58:38 2010 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/7962725ee825d4e4d3416f07d178cf8336a74497 [^] Fixes issue 0015064: Performance problem in role window when there are many warehouses defined It has been modified the way of generating the JSON object to use the included JSON library --- M src/org/openbravo/erpCommon/ad_forms/Role.java --- |
|
(0032651) hudsonbot (developer) 2010-11-17 04:28 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/7962725ee825 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/b1b58a335fa9 [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18904.obx [^] |
|
(0032781) hgbot (developer) 2010-11-22 13:09 |
Repository: erp/devel/pi Changeset: 19271f33c4b55c7e3db3e0721b8b756a08c219f2 Author: Adrián Romero <adrianromero <at> openbravo.com> Date: Mon Nov 22 13:06:33 2010 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/19271f33c4b55c7e3db3e0721b8b756a08c219f2 [^] Fixes issue 0015064: Performance problem in role window when there are many warehouses defined Small refactory in DAL query and code reformat --- M src/org/openbravo/base/secureApp/LoginUtils.java --- |
|
(0032933) hudsonbot (developer) 2010-11-30 17:51 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/19271f33c4b5 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7c27b4b566df [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19017.obx [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-10-28 12:38 | jonalegriaesarte | New Issue | |
| 2010-10-28 12:38 | jonalegriaesarte | Assigned To | => adrianromero |
| 2010-10-28 12:38 | jonalegriaesarte | Issue Monitored: networkb | |
| 2010-10-28 12:42 | jonalegriaesarte | version | => 2.50MP22 |
| 2010-10-28 18:52 | adrianromero | Note Added: 0032322 | |
| 2010-11-05 09:02 | shuehner | Issue Monitored: shuehner | |
| 2010-11-15 18:01 | adrianromero | Issue cloned | 0015193 |
| 2010-11-15 18:01 | adrianromero | Relationship added | depends on 0015193 |
| 2010-11-15 18:01 | hgbot | Checkin | |
| 2010-11-15 18:01 | hgbot | Note Added: 0032618 | |
| 2010-11-15 18:01 | hgbot | Status | new => resolved |
| 2010-11-15 18:01 | hgbot | Resolution | open => fixed |
| 2010-11-15 18:01 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/1b773d75b4848538fca07665a40333b136c10fc6 [^] |
| 2010-11-15 18:03 | adrianromero | Note Added: 0032620 | |
| 2010-11-15 22:26 | hudsonbot | Checkin | |
| 2010-11-15 22:26 | hudsonbot | Note Added: 0032626 | |
| 2010-11-16 19:01 | hgbot | Checkin | |
| 2010-11-16 19:01 | hgbot | Note Added: 0032643 | |
| 2010-11-16 19:02 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/1b773d75b4848538fca07665a40333b136c10fc6 [^] => http://code.openbravo.com/erp/devel/pi/rev/7962725ee825d4e4d3416f07d178cf8336a74497 [^] |
| 2010-11-17 04:28 | hudsonbot | Checkin | |
| 2010-11-17 04:28 | hudsonbot | Note Added: 0032651 | |
| 2010-11-18 13:13 | psarobe | Relationship added | related to 0014048 |
| 2010-11-22 13:09 | hgbot | Checkin | |
| 2010-11-22 13:09 | hgbot | Note Added: 0032781 | |
| 2010-11-22 13:09 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/7962725ee825d4e4d3416f07d178cf8336a74497 [^] => http://code.openbravo.com/erp/devel/pi/rev/19271f33c4b55c7e3db3e0721b8b756a08c219f2 [^] |
| 2010-11-30 17:51 | hudsonbot | Checkin | |
| 2010-11-30 17:51 | hudsonbot | Note Added: 0032933 | |
| 2011-05-24 10:02 | dalsasua | Tag Attached: closingMay2011 | |
| 2011-05-24 10:57 | dalsasua | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |