Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015064Openbravo ERP02. Master data managementpublic2010-10-28 12:382011-05-24 10:57
Reporterjonalegriaesarte 
Assigned Toadrianromero 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP22 
Target Version2.50MP25Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0015064: Performance problem in role window when there are many warehouses defined
DescriptionWe have an application with more that 200 warehouses defined. When the user tries to open the role window (the first link in the menu), the window takes a lot of time.
Steps To Reproduce- Create some warehouses (we have more that 200).
- Access to role information (first link in the menu)
- Notice that it takes a lot of time.

Note that the action save in this window takes a lot of time, too.
Proposed Solution
Additional Information
TagsclosingMay2011
Relationships
related to defect 00140483.0RC6 closed marvintm Warehouse combo box in the "user pop-up" window must depend on the organization 
depends on defect 00151933.0RC4 closed marvintm Performance problem in role window when there are many warehouses defined 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-10-28 12:38jonalegriaesarteNew Issue
2010-10-28 12:38jonalegriaesarteAssigned To => adrianromero
2010-10-28 12:38jonalegriaesarteIssue Monitored: networkb
2010-10-28 12:42jonalegriaesarteversion => 2.50MP22
2010-10-28 18:52adrianromeroNote Added: 0032322
2010-11-05 09:02shuehnerIssue Monitored: shuehner
2010-11-15 18:01adrianromeroIssue cloned0015193
2010-11-15 18:01adrianromeroRelationship addeddepends on 0015193
2010-11-15 18:01hgbotCheckin
2010-11-15 18:01hgbotNote Added: 0032618
2010-11-15 18:01hgbotStatusnew => resolved
2010-11-15 18:01hgbotResolutionopen => fixed
2010-11-15 18:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1b773d75b4848538fca07665a40333b136c10fc6 [^]
2010-11-15 18:03adrianromeroNote Added: 0032620
2010-11-15 22:26hudsonbotCheckin
2010-11-15 22:26hudsonbotNote Added: 0032626
2010-11-16 19:01hgbotCheckin
2010-11-16 19:01hgbotNote Added: 0032643
2010-11-16 19:02hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/1b773d75b4848538fca07665a40333b136c10fc6 [^] => http://code.openbravo.com/erp/devel/pi/rev/7962725ee825d4e4d3416f07d178cf8336a74497 [^]
2010-11-17 04:28hudsonbotCheckin
2010-11-17 04:28hudsonbotNote Added: 0032651
2010-11-18 13:13psarobeRelationship addedrelated to 0014048
2010-11-22 13:09hgbotCheckin
2010-11-22 13:09hgbotNote Added: 0032781
2010-11-22 13:09hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/7962725ee825d4e4d3416f07d178cf8336a74497 [^] => http://code.openbravo.com/erp/devel/pi/rev/19271f33c4b55c7e3db3e0721b8b756a08c219f2 [^]
2010-11-30 17:51hudsonbotCheckin
2010-11-30 17:51hudsonbotNote Added: 0032933
2011-05-24 10:02dalsasuaTag Attached: closingMay2011
2011-05-24 10:57dalsasuaStatusresolved => closed

Notes
(0032322)
adrianromero   
2010-10-28 18:52   
The performance problem described is located in the SQL sentence executed in src/org/openbravo/erpCommon/ad_formsWarehouse_data.xsql because it gets the full list of warehouses by client and by role. For example, if the logged user has 10 roles and 10 clients and 200 warehouses it gets 10x10x200 = 20000 records !!!!

This window has to be refactored to load the warehouse list when client and role is selected and not to load everything when opening the window.
(0032618)
hgbot   
2010-11-15 18:01   
Repository: erp/devel/pi
Changeset: 1b773d75b4848538fca07665a40333b136c10fc6
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Nov 15 17:59:06 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1b773d75b4848538fca07665a40333b136c10fc6 [^]

Fixes issue 0015064: Performance problem in role window when there are many warehouses defined
It has beem modified the way warehouse selector is loaded to load only the needed elements every time the client and the role changes instead of loading all posible combinations at loading time

---
M src/org/openbravo/erpCommon/ad_forms/Role.html
M src/org/openbravo/erpCommon/ad_forms/Role.java
M src/org/openbravo/erpCommon/ad_forms/Role.xml
M src/org/openbravo/erpCommon/ad_forms/Warehouse_data.xsql
---
(0032620)
adrianromero   
2010-11-15 18:03   
* Testing the issue

Load 200 warehouses and follow the steps to reproduce. Now, the load time of warehouses in the selector is quick.

* Other areas affected

Only the role window is affected.
(0032626)
hudsonbot   
2010-11-15 22:26   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/1b773d75b484 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/109294950618 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18901.obx [^]
(0032643)
hgbot   
2010-11-16 19:01   
Repository: erp/devel/pi
Changeset: 7962725ee825d4e4d3416f07d178cf8336a74497
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Tue Nov 16 18:58:38 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7962725ee825d4e4d3416f07d178cf8336a74497 [^]

Fixes issue 0015064: Performance problem in role window when there are many warehouses defined
It has been modified the way of generating the JSON object to use the included JSON library

---
M src/org/openbravo/erpCommon/ad_forms/Role.java
---
(0032651)
hudsonbot   
2010-11-17 04:28   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/7962725ee825 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/b1b58a335fa9 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18904.obx [^]
(0032781)
hgbot   
2010-11-22 13:09   
Repository: erp/devel/pi
Changeset: 19271f33c4b55c7e3db3e0721b8b756a08c219f2
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Nov 22 13:06:33 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/19271f33c4b55c7e3db3e0721b8b756a08c219f2 [^]

Fixes issue 0015064: Performance problem in role window when there are many warehouses defined
Small refactory in DAL query and code reformat

---
M src/org/openbravo/base/secureApp/LoginUtils.java
---
(0032933)
hudsonbot   
2010-11-30 17:51   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/19271f33c4b5 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7c27b4b566df [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19017.obx [^]