Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0014995

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] A. Platform

major

always

2010-10-22 16:20

2010-12-16 22:16

Reporter

vmromanos

View Status

public

Assigned To

marvintm

Priority

normal

Resolution

fixed

Fixed in Version

2.50MP25

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Linux 32 bit

Database

PostgreSQL

Java version

1.6.0_12

OS Version

Debian 5.0

Database version

8.3.8

Ant version

1.7.0

Product Version

pi

SCM revision

Review Assigned To

Web browser

Modules

Core

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0014995: Modulescript *Data.java files are created in the same module folder

Description

I have an installation with several modules, where 2 of them have modulescripts.
I'm developing a new modulescript for my module.

When compiling the module script for my module (ant compile.modulescript -Dmodule=org.openbravo.assetsmanagement), all the modulescript *Data.java files created based on the .xsql files of the "other" modules are stored into my module folder:

? build/classes/org/openbravo/advpaymentmngt/modulescript/CreateAccountingConfigurationData.class
? build/classes/org/openbravo/advpaymentmngt/modulescript/CreateDocumentNoSequenceData.class
? build/classes/org/openbravo/advpaymentmngt/modulescript/UpdateGeneratedUsedCreditColumnsData.class
? build/classes/org/openbravo/assetsmanagement/modulescript/CreateAccountingConfiguration4Assets.class
? build/classes/org/openbravo/assetsmanagement/modulescript/CreateAccountingConfiguration4AssetsData.class
? build/classes/org/openbravo/modulescript/CreatePeriodControlConfigurationData.class
? src-util/modulescript/src/org/openbravo/assetsmanagement/modulescript/CreateAccountingConfiguration4Assets.java
? src-util/modulescript/src/org/openbravo/assetsmanagement/modulescript/CreateAccountingConfiguration4Assets_data.xsql
? src-util/modulescript/src/src/org/openbravo/accrualsanddeferrals/modulescript/CreatePeriodControlConfigurationData.java
? src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/CreateAccountingConfigurationData.java
? src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/CreateDocumentNoSequenceData.java
? src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/UpdateGeneratedUsedCreditColumnsData.java
? src-util/modulescript/src/src/org/openbravo/assetsmanagement/modulescript/CreateAccountingConfiguration4AssetsData.java

Proposed Solution

See attached file

Tags

No tags attached.

diffmodulescript.diff [^] (827 bytes) 2010-10-22 16:20 [Show Content] [Hide Content]

diff --git a/src-util/modulescript/build.xml b/src-util/modulescript/build.xml
--- a/src-util/modulescript/build.xml
+++ b/src-util/modulescript/build.xml
@@ -73,7 +73,7 @@
 
   <target name="sqlcModules" depends="init" unless="checkCore">
     <java classname="org.openbravo.data.Sqlc" jvm="${env.JAVA_HOME}/bin/java" fork="yes" maxmemory="${build.maxmemory}">
-      <arg line="'${base.config}'/Openbravo.properties .xsql '${base.modules}' '${base.modules}'/'${module}'/src-util/modulescript/src */src-util/modulescript" />
+      <arg line="'${base.config}'/Openbravo.properties .xsql '${base.modules}' '${base.modules}'/'${module}'/src-util/modulescript/src '${module}'/src-util/modulescript" />
       <classpath refid="modulescript.class.path" />
       <syspropertyset>
         <propertyref name="java.security.egd" />

Relationships [ Relation Graph ] [ Dependency Graph ]

has duplicate

defect

closed

compile.modulescript -Dmodule=[Module] compiles the files from all modules

Notes
(0032122) marvintm (developer) 2010-10-22 16:21	buildvalidations probably are also affected and should be fixed in the same way

(0032842) hgbot (developer) 2010-11-25 11:56	Repository: erp/devel/pi Changeset: 1842c1d65c817bdfbba6934fd1cb7896cda6486a Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Thu Nov 25 11:46:00 2010 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/1842c1d65c817bdfbba6934fd1cb7896cda6486a [^] Fixed issue 14995. compile.modulescript and compile.buildvalidation will no longer copy all the xsql related files of all the modules into the module you are compiling --- M src-util/buildvalidation/build.xml M src-util/modulescript/build.xml ---

(0032946) hudsonbot (developer) 2010-11-30 17:52	A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/1842c1d65c81 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7c27b4b566df [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19017.obx [^]

Issue History
Date Modified	Username	Field	Change
2010-10-22 16:20	vmromanos	New Issue
2010-10-22 16:20	vmromanos	Assigned To	=> marvintm
2010-10-22 16:20	vmromanos	File Added: diffmodulescript.diff
2010-10-22 16:21	marvintm	Note Added: 0032122
2010-10-22 16:22	vmromanos	version	=> pi
2010-10-22 16:22	vmromanos	Summary	Modulescripts Data.java are created in the compiled module => Modulescript Data.java files are created in the same module folder
2010-10-22 16:23	vmromanos	Description Updated	View Revisions
2010-10-25 08:55	alostale	Status	new => scheduled
2010-11-25 11:56	hgbot	Checkin
2010-11-25 11:56	hgbot	Note Added: 0032842
2010-11-25 11:56	hgbot	Status	scheduled => resolved
2010-11-25 11:56	hgbot	Resolution	open => fixed
2010-11-25 11:56	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/1842c1d65c817bdfbba6934fd1cb7896cda6486a [^]
2010-11-25 15:45	marvintm	Relationship added	has duplicate 0015145
2010-11-30 17:52	hudsonbot	Checkin
2010-11-30 17:52	hudsonbot	Note Added: 0032946
2010-12-14 16:40	alostale	Status	resolved => closed
2010-12-14 16:40	alostale	Fixed in Version	=> 2.50MP25
2010-12-16 22:16	anonymous	sf_bug_id	0 => 3138787

Copyright © 2000 - 2009 MantisBT Group