0014689: Translation: If you apply any translation module on top of MP21 some fields get not translated

Notes
(0031336) alostale (viewer) 2010-09-24 08:37	This bug was introduced by issue 0013178 and it is only reproducible in PostgreSQL. The problem is in the AD_Element_Trl_Trg, in this piece of code: UPDATE AD_Field_Trl SET NAME = coalesce(:NEW.PO_NAME, :new.Name), Description = coalesce(:NEW.PO_Description, :new.Description), ... For purchase windows (isSoTrx='N') it tries to set the PO names in the Field_Trl table, in order to leave it empty it sets them only in case they are not empty. The problem is the translation process is setting '' instead of null for empty strings, which in PostgreSQL is not equal to null.

(0031338) hgbot (developer) 2010-09-24 08:43	Repository: erp/devel/pi Changeset: 88428c9b2bcc460abe6d1a9a406acee891162216 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Fri Sep 24 08:42:01 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/88428c9b2bcc460abe6d1a9a406acee891162216 [^] fixed issue 14689: Tranlation does not work in PG Translation process now sets NULL instead of '' for empty strings. This makes Oracle, PostgreSQL and edition from UI behave in the same way, making also to work properly SQL code expecting null for empty strings. This last case was what made the translation to fail in AD_Element_Trl_Trg trigger. --- M src/org/openbravo/erpCommon/ad_forms/TranslationHandler.java ---

(0031339) alostale (viewer) 2010-09-24 10:28	This does not affect to instances that already had the translation installed in a previous MP and were updated to MP21. For instances that have installed the translation in MP21 it will be required to fix the translation once they are updated to a higher version, there are two possible scenarios: Translation is installed as a single module. The solution consists on deinstalling the translation and installing it again. Translation is installed within a pack or template (for example a localization pack). In this case it is not possible to deinstall just the translation. The solution would be: Execute in DB (using a DB client such as psql or pgAdmin): ''update ad_module set status ='I' where istranslationmodule='Y';'' In command line execute from the root directory of Openbravo installation: ''ant apply.module''

(0031347) hgbot (developer) 2010-09-24 12:28	Repository: erp/devel/pi Changeset: 714819270152e18bf7297340e88a09d7701d2007 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Fri Sep 24 12:27:34 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/714819270152e18bf7297340e88a09d7701d2007 [^] related to issue 14689 When updating ad_element_trl check for changes in PO* columns, this solves: -A change in a PO* column was not propagated to its trl fields if there was not also a change in any other column. -Reinstalling a language didn't made changes as data is not previously removed, so the only change after previos fix was changes in PO* from '' to null --- M src-db/database/model/triggers/AD_ELEMENT_TRL_TRG.xml ---

(0031358) psarobe (viewer) 2010-09-25 12:36	Tested in PI. Works fine

(0031461) hudsonbot (viewer) 2010-09-29 11:57	A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/88428c9b2bcc [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/51c2c2967221 [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18452.obx [^]

(0031463) hudsonbot (viewer) 2010-09-29 11:57	A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/714819270152 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/51c2c2967221 [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18452.obx [^]

Issue History
Date Modified	Username	Field	Change
2010-09-23 16:56	psarobe	New Issue
2010-09-23 16:56	psarobe	Assigned To	=> alostale
2010-09-23 16:56	psarobe	File Added: error.PNG
2010-09-23 16:56	psarobe	OBNetwork customer	=> No
2010-09-23 16:56	psarobe	Status	new => scheduled
2010-09-23 16:56	psarobe	fix_in_branch	=> pi
2010-09-23 21:36	jpabloae	Issue Monitored: jpabloae
2010-09-24 08:31	alostale	Relationship added	related to 0013178
2010-09-24 08:37	alostale	Note Added: 0031336
2010-09-24 08:43	hgbot	Checkin
2010-09-24 08:43	hgbot	Note Added: 0031338
2010-09-24 08:43	hgbot	Status	scheduled => resolved
2010-09-24 08:43	hgbot	Resolution	open => fixed
2010-09-24 08:43	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/88428c9b2bcc460abe6d1a9a406acee891162216 [^]
2010-09-24 09:15	psarobe	Tag Attached: Regression
2010-09-24 10:10	alostale	Status	resolved => new
2010-09-24 10:10	alostale	Resolution	fixed => open
2010-09-24 10:12	alostale	fix_in_branch	pi =>
2010-09-24 10:12	alostale	Description Updated	View Revisions
2010-09-24 10:12	alostale	Status	new => scheduled
2010-09-24 10:12	alostale	fix_in_branch	=> pi
2010-09-24 10:12	alostale	Status	scheduled => resolved
2010-09-24 10:12	alostale	Resolution	open => fixed
2010-09-24 10:28	alostale	Note Added: 0031339
2010-09-24 12:28	hgbot	Checkin
2010-09-24 12:28	hgbot	Note Added: 0031347
2010-09-25 12:36	psarobe	Note Added: 0031358
2010-09-25 12:36	psarobe	Status	resolved => closed
2010-09-25 12:36	psarobe	Fixed in Version	=> 2.50MP22
2010-09-26 00:00	anonymous	sf_bug_id	0 => 3075666
2010-09-29 11:57	hudsonbot	Checkin
2010-09-29 11:57	hudsonbot	Note Added: 0031461
2010-09-29 11:57	hudsonbot	Checkin
2010-09-29 11:57	hudsonbot	Note Added: 0031463
2010-09-30 11:18	alostale	Relationship added	related to 0014551