Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0014633
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2010-09-21 12:382010-12-30 13:13
ReporternetworkbView Statuspublic 
Assigned Toalostale 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionbce4bc9e881e
ProjectionnoneETAnoneTarget Version3.0RC4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50MP21SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0014633: Wrong behaviour when printing messages using OBError, when messages belong to a module whose language is different than English

DescriptionWhen developing a new java that prints an error message using OBError, if the module has been defined in Spanish, the message value of the ad_message is shown when loggin in spanish.
It seems that it tries to find a message in spanish on the ad_message_trl, but it has not been created because the module is being developed on spanish.

This error happens in the machine where the module has been development, but if you package it on a module, and install it on a different application the message is correct.
This is because when installing the module a new row for the message is created
on the ad_message_trl table for spanish language but this not happens when developing the module.

Steps To Reproduce-Define a new module in spanish
-Create a message in spanish.
-Create a process that prints the error message using OBError object
-After compile see that the error shown is the value of the ad_message when should be the messagetext.
Proposed Solution-Make the ob error to print the message of the ad_message instead of ad_message_trl table, when the message belongs to a module that is defined for a language different than english.

Tagsdev-platform-quick-wins
Attached Files? file icon BudgetConfigurationUtility.java [^] (8,024 bytes) 2010-11-17 13:00

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0015072 closedalostale The display of help of edit of help is broken for module with baseLang != en_us 
depends on backport 00154172.50MP25 closedalostale Wrong behaviour when printing messages using OBError, when messages belong to a module whose language is different than English 

-  Notes
(0031535)
alostale (manager)
2010-10-01 11:08

Please can you provide a code snippet about how to make this fail.

OBError is not in charge of translations, so from the bug description is not clear how this is used when it is not working.
(0032660)
egoitz (developer)
2010-11-17 12:55

the description has been updated because an error on the explanation.
(0032663)
shuehner (administrator)
2010-11-17 13:13
edited on: 2010-11-17 13:14

Note: Broken code is most likely the following function:

org.openbravo.erpCommon.utility.Utility, function messageBD
as it hardcoded checks for lang = 'en_US' and doesn't look into the _TRL table in that case, which is broken with modules with a different baseLanguage.

Note, needs to be fixed multiple times in that method

(0033154)
hgbot (developer)
2010-12-14 11:46

Repository: erp/devel/pi
Changeset: bce4bc9e881ec5376d9bba855fce93e03a3e84b9
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Dec 14 11:45:49 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/bce4bc9e881ec5376d9bba855fce93e03a3e84b9 [^]

fixed bug 14633: Wrong behaviour when printing messages using OBError

---
M src/org/openbravo/erpCommon/utility/MessageBD_data.xsql
M src/org/openbravo/erpCommon/utility/Utility.java
---
(0033184)
shuehner (administrator)
2010-12-14 19:30

Reviewed & Tested in stable/2.50/pgsql (rev: 2fbe2449d3ac), the method is now working fine reading both base-language & extra-language values in both base-language en_US (like corE) and with a module in another base-language (like de_DE)
(0033441)
hudsonbot (developer)
2010-12-30 13:13

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/bce4bc9e881e [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7d7e5eebcc62 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19448.obx [^]

- Issue History
Date Modified Username Field Change
2010-09-21 12:38 networkb New Issue
2010-09-21 12:38 networkb Assigned To => alostale
2010-09-21 12:49 rafaroda Issue Monitored: rafaroda
2010-09-27 08:45 alostale Status new => scheduled
2010-09-27 08:45 alostale fix_in_branch => pi
2010-09-27 16:27 rafaroda Tag Attached: dev-platform-quick-wins
2010-10-01 11:08 alostale Note Added: 0031535
2010-10-01 11:08 alostale Assigned To alostale => networkb
2010-10-01 11:08 alostale Status scheduled => feedback
2010-11-17 12:55 egoitz Note Added: 0032660
2010-11-17 12:55 egoitz Assigned To networkb => alostale
2010-11-17 12:55 egoitz Status feedback => new
2010-11-17 12:55 egoitz Target Version 2.50MP23 => 2.50MP25
2010-11-17 12:55 egoitz fix_in_branch pi =>
2010-11-17 12:55 egoitz Description Updated View Revisions
2010-11-17 12:55 egoitz Steps to Reproduce Updated View Revisions
2010-11-17 13:00 egoitz File Added: BudgetConfigurationUtility.java
2010-11-17 13:13 shuehner Note Added: 0032663
2010-11-17 13:14 shuehner Note Edited: 0032663 View Revisions
2010-11-17 13:19 shuehner Relationship added related to 0015072
2010-11-22 08:35 alostale Status new => scheduled
2010-12-14 11:44 alostale Status scheduled => acknowledged
2010-12-14 11:44 alostale Status acknowledged => scheduled
2010-12-14 11:44 alostale fix_in_branch => pi
2010-12-14 11:45 alostale Target Version 2.50MP25 => 3.0RC4
2010-12-14 11:45 alostale fix_in_branch pi =>
2010-12-14 11:46 hgbot Checkin
2010-12-14 11:46 hgbot Note Added: 0033154
2010-12-14 11:46 hgbot Status scheduled => resolved
2010-12-14 11:46 hgbot Resolution open => fixed
2010-12-14 11:46 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bce4bc9e881ec5376d9bba855fce93e03a3e84b9 [^]
2010-12-14 19:30 shuehner Note Added: 0033184
2010-12-14 19:30 shuehner Status resolved => closed
2010-12-16 22:15 anonymous sf_bug_id 0 => 3138781
2010-12-30 13:13 hudsonbot Checkin
2010-12-30 13:13 hudsonbot Note Added: 0033441


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker