Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0014619
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2010-09-20 15:352010-10-20 00:00
ReporterdalsasuaView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionc0245cb0e221
ProjectionnoneETAnoneTarget Versionpi
OSLinux 32 bitDatabaseOracleJava version1.6.0_14
OS VersionUbuntu 9.04Database version11.1.0.6.0 SEAnt version1.7.1
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0014619: Generate entities do not notice that a field name has changed one letter to upper

DescriptionIf one field is named (and is associated to an element named) "Subsidy entity", the generate entities will create all getters setters as get/setSubsidyentity. If now name of the field changes to "Subsidy Entity", the generated java class is not modified, so getters/setters will continue to be get/setSubsidyentity, instead of get/setSubsidyEntity in the instance where the change was made. In a fresh instance, the getters/setters will have the upper "E".
This happens even deleting the generated java file.
A work-around is to delete the class file of the generated java.
Steps To Reproduce1.Create a column in any table
2.Name it Subsidy entity
3.Create the field
4.Create a java class that uses through DAL setSubsidyentity
5.Compile
6.Change the name of the column (and element) to Subsidy Entity
7.Compile
8.Realize that everything goes fine
9.Now delete the build folder and compile again
10.Realize that the java created in step 4 will fail to compile, as it uses setSubsidyentity, while the created one is setSubsidyEntity
Tagsdev-platform-quick-wins
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0031269)
hgbot (developer)
2010-09-21 12:31

 Repository: erp/devel/pi
Changeset: c0245cb0e221b640b4a7e13a8d8ea0e99a5fee6b
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Sep 21 12:31:00 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c0245cb0e221b640b4a7e13a8d8ea0e99a5fee6b [^]

fixes issue 14619: Generate entities do not notice that a field name has changed one letter to upper

---
M src/org/openbravo/base/model/NamingUtil.java
---
(0031450)
hudsonbot (developer)
2010-09-29 11:57

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/c0245cb0e221 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/51c2c2967221 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18452.obx [^]
(0031963)
iperdomo (reporter)
2010-10-19 12:04

 Tested on pi @ rev eb105fcc4400

* Changed a field name, element name, synchronize terminology
* generate.entities
* Cleared the build folder
* compile.complete

The getters/setters name is consistent

- Issue History
Date Modified Username Field Change
2010-09-20 15:35 dalsasua New Issue
2010-09-20 15:35 dalsasua Assigned To => mtaal
2010-09-21 12:31 hgbot Checkin
2010-09-21 12:31 hgbot Note Added: 0031269
2010-09-21 12:31 hgbot Status new => resolved
2010-09-21 12:31 hgbot Resolution open => fixed
2010-09-21 12:31 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c0245cb0e221b640b4a7e13a8d8ea0e99a5fee6b [^]
2010-09-27 17:09 rafaroda Tag Attached: dev-platform-quick-wins
2010-09-29 11:57 hudsonbot Checkin
2010-09-29 11:57 hudsonbot Note Added: 0031450
2010-10-19 12:04 iperdomo Note Added: 0031963
2010-10-19 12:04 iperdomo Status resolved => closed
2010-10-20 00:00 anonymous sf_bug_id 0 => 3090870

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker