Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0014528
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] Y. DBSourceManagermajorhave not tried2010-09-13 16:572010-10-22 22:43
ReportermarvintmView Statuspublic 
Assigned Tomarvintm 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision52b4534693d5
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0014528: It should be possible to exclude database model objects from being loaded in modules

DescriptionCurrently there is a Java class in Openbravo with a hardcoded list of database model objects which shouldn't be taken into account by dbsourcemanager when loading the model (located in src-db/src).

This should be changed to an implementation in which modules can extend this list of objects.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0031019)
hgbot (developer)
2010-09-14 09:33

Repository: erp/devel/pi
Changeset: 2c3a33b40084ef6af9aed82a6358b38f654cad6e
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Sep 13 16:58:50 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2c3a33b40084ef6af9aed82a6358b38f654cad6e [^]

Fixed issue 14528. Now it is possible to extend the list of excluded database model objects with modules.

---
M src-db/database/lib/dbsourcemanager.jar
M src/org/openbravo/service/system/SystemValidationTask.java
A src-db/database/model/excludeFilter.xml
---
(0031061)
marvintm (developer)
2010-09-14 18:20

The changes in dbsourcemanager were added in this commit

https://code.openbravo.com/erp/devel/dbsm-main/rev/2c8d03471fcd [^]
(0031070)
hgbot (developer)
2010-09-15 10:05

Repository: erp/devel/pi
Changeset: c8ee016e65b9fbd6f47458eff74da110946c314d
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Sep 15 10:05:05 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c8ee016e65b9fbd6f47458eff74da110946c314d [^]

Related to issue 14528. Add deprecation in the old ExcludeFilter class

---
M src-db/src/com/openbravo/db/OpenbravoExcludeFilter.java
---
(0031071)
hgbot (developer)
2010-09-15 10:12

Repository: erp/devel/pi
Changeset: f435f47415f1221e3f3bae77a9fc9ec1e5134ec5
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Sep 15 10:11:36 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f435f47415f1221e3f3bae77a9fc9ec1e5134ec5 [^]

Related to issue 14528. Fixed wrong tag.

---
M src-db/src/com/openbravo/db/OpenbravoExcludeFilter.java
---
(0031113)
hudsonbot (developer)
2010-09-15 20:55

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/2c3a33b40084 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/80bfed94a6e8 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18410.obx [^]
(0031125)
hudsonbot (developer)
2010-09-15 20:55

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/c8ee016e65b9 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/80bfed94a6e8 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18410.obx [^]
(0031126)
hudsonbot (developer)
2010-09-15 20:55

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/f435f47415f1 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/80bfed94a6e8 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18410.obx [^]
(0031186)
shuehner (administrator)
2010-09-17 12:28

update.databascript.script does not use the new exclude system. And some other references in dbsm still use old system as well.
(0031188)
hgbot (developer)
2010-09-17 12:58

Repository: erp/devel/dbsm-main
Changeset: 92c55218cf8ec4ce39fc21ac952da3fc83f4897d
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Sep 17 12:56:58 2010 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/92c55218cf8ec4ce39fc21ac952da3fc83f4897d [^]

Related to issue 14528. Added new filtering to the update.database.script task.

---
M src/org/openbravo/ddlutils/task/AlterDatabaseDataAll.java
M src/org/openbravo/ddlutils/task/AlterXML2SQL.java
---
(0031189)
hgbot (developer)
2010-09-17 13:03

Repository: erp/devel/pi
Changeset: 9664a67bb1240bd8bb2f8e09111960d32cd60e45
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Sep 17 12:57:04 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9664a67bb1240bd8bb2f8e09111960d32cd60e45 [^]

Related to issue 14528. Added new filtering to the update.database.script task.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0031190)
hgbot (developer)
2010-09-17 13:03

Repository: erp/devel/pi
Changeset: 52b4534693d5696a956b2a8394956782e313a56a
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Sep 17 13:01:56 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/52b4534693d5696a956b2a8394956782e313a56a [^]

Fixed issue 14528. Added new filtering to the update.database.script task.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0031197)
shuehner (administrator)
2010-09-17 16:49

Tested on pi/psql. As change is in common code no special testing on oracle is needed. Tested are normal core upgrade without any changes from MP21 -> pi.obx including this changes. Then creation of a module using the new features (exclude defined for a table,view,function,trigger) and creation of those manually in the database. Verified that update.database, update.database.mod, update.database.script, export.database, export.config.script do not modify/remove those excluded elements and do not stop with some error because of their presence.
Also checked that a manually creation function in i.e. prescript,postscript is still present after create.database when this function is excluded in a module present when running create.database (Note that's a workaround for creating a manual function in i.e. a ModuleScript as right now, no ModuleScript's are executed during create.database).
(0031234)
hudsonbot (developer)
2010-09-20 15:28

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/9664a67bb124 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/2d835e4acd70 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18424.obx [^]
(0031235)
hudsonbot (developer)
2010-09-20 15:28

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/52b4534693d5 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/2d835e4acd70 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18424.obx [^]
(0032100)
hgbot (developer)
2010-10-22 10:23

Repository: erp/devel/pi
Changeset: a56edfeb2fe4d2376067653962b7d9c828b6c88c
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Oct 22 10:17:02 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a56edfeb2fe4d2376067653962b7d9c828b6c88c [^]

Related to issue 14528. Added new filtering also to SystemValidatorTest

---
M src-test/org/openbravo/test/system/SystemValidatorTest.java
---
(0032136)
hudsonbot (developer)
2010-10-22 22:43

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/a56edfeb2fe4 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/98214a9e7372 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18589.obx [^]

- Issue History
Date Modified Username Field Change
2010-09-13 16:57 marvintm New Issue
2010-09-13 16:57 marvintm Assigned To => marvintm
2010-09-14 09:33 hgbot Checkin
2010-09-14 09:33 hgbot Note Added: 0031019
2010-09-14 09:33 hgbot Status new => resolved
2010-09-14 09:33 hgbot Resolution open => fixed
2010-09-14 09:33 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2c3a33b40084ef6af9aed82a6358b38f654cad6e [^]
2010-09-14 18:20 marvintm Note Added: 0031061
2010-09-15 10:05 hgbot Checkin
2010-09-15 10:05 hgbot Note Added: 0031070
2010-09-15 10:12 hgbot Checkin
2010-09-15 10:12 hgbot Note Added: 0031071
2010-09-15 20:55 hudsonbot Checkin
2010-09-15 20:55 hudsonbot Note Added: 0031113
2010-09-15 20:55 hudsonbot Checkin
2010-09-15 20:55 hudsonbot Note Added: 0031125
2010-09-15 20:55 hudsonbot Checkin
2010-09-15 20:55 hudsonbot Note Added: 0031126
2010-09-17 12:28 shuehner Note Added: 0031186
2010-09-17 12:28 shuehner Status resolved => new
2010-09-17 12:28 shuehner Resolution fixed => open
2010-09-17 12:58 hgbot Checkin
2010-09-17 12:58 hgbot Note Added: 0031188
2010-09-17 13:03 hgbot Checkin
2010-09-17 13:03 hgbot Note Added: 0031189
2010-09-17 13:03 hgbot Checkin
2010-09-17 13:03 hgbot Note Added: 0031190
2010-09-17 13:03 hgbot Status new => resolved
2010-09-17 13:03 hgbot Resolution open => fixed
2010-09-17 13:03 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/2c3a33b40084ef6af9aed82a6358b38f654cad6e [^] => http://code.openbravo.com/erp/devel/pi/rev/52b4534693d5696a956b2a8394956782e313a56a [^]
2010-09-17 16:49 shuehner Note Added: 0031197
2010-09-17 16:49 shuehner Status resolved => closed
2010-09-18 00:00 anonymous sf_bug_id 0 => 3069535
2010-09-20 15:28 hudsonbot Checkin
2010-09-20 15:28 hudsonbot Note Added: 0031234
2010-09-20 15:28 hudsonbot Checkin
2010-09-20 15:28 hudsonbot Note Added: 0031235
2010-10-22 10:23 hgbot Checkin
2010-10-22 10:23 hgbot Note Added: 0032100
2010-10-22 22:43 hudsonbot Checkin
2010-10-22 22:43 hudsonbot Note Added: 0032136


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker