Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0014270 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] A. Platform | major | always | 2010-08-24 10:31 | 2010-10-14 00:00 | |||
Reporter | psanjuan | View Status | public | |||||
Assigned To | bemaill | |||||||
Priority | urgent | Resolution | fixed | Fixed in Version | 2.50MP23 | |||
Status | closed | Fix in branch | pi | Fixed in SCM revision | c8cc677ecd99 | |||
Projection | none | ETA | none | Target Version | ||||
OS | Linux 32 bit | Database | Oracle | Java version | 1.6 | |||
OS Version | Ubuntu 8.04.1 | Database version | 11.1.0.6.0 | Ant version | 1.7.0 | |||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | ||||||||
OBNetwork customer | No | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0014270: When changing the Settings from General Availabity to Test and the other way around an error is shown | |||||||
Description | When changing the Settings from General Availabity to Test and the other way around an error is shown | |||||||
Steps To Reproduce | Go to General Setup || Application || Module Management || Module Management - tab Settings and set below values to Test. - when doing a scan for updates, accept versions of the following status or highter = Test - when searching for new modules,accept versions of the following status or higher= Test - Save Go to Installed Modules tab, scan for updates and then you get below attached screen (scan_test.png). do not install anything, press cancel. Go back to General Setup || Application || Module Management || Module Management - tab Settings and set below value to General Availability. - when doing a scan for updates, accept versions of the following status or highter = General Availability - Save Go to Installed Modules tab, scan for updates and then you get below attached screen (scan_ga.png). do not install anything, press cancel. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() ![]() | |||||||
![]() |
||||||||
|
![]() |
|
(0030261) shuehner (administrator) 2010-08-24 17:52 |
Note: problem is that in the last screenshot we do call printPageInstall1 without anything to install or update (as the current maturity_update level does not allow anything to be updated (anymore)). -> then inside npe happens. Suggestion for fix: - When changing the maturity_update (global) level to something more restrictive -> clear update_available,update_ver_id for all modules - When changing maturity_update for one module to something more restrictive -> clear update_available,update_ver_id for this one module For the user means we does not see the 'unavailable' updates anymore and needs to use scan for updates again. Note2: for the npe itself: its already marked as possible NPE by eclipse |
(0030262) iciordia (viewer) 2010-08-24 18:14 |
Other suggestions: -it should be possible to execute scan for updates several times. Each time the system should clean previous results since the answer can be different in time (eg. because new modules are published). Scan for updates should be resetable -if there are internal changes in the instance regarding updating modules (eg. changes in maturity status configuration, installing/uninstalling modules, etc.) the system should automatically reset any previous scan for updates -before applying updates the system should check that the available updates returned by the CR are still available and valid before proceeding |
(0030264) shuehner (administrator) 2010-08-24 18:20 |
All good: - with a.) bugfix to scan for updates (to reset,update to list of available updates) - b.) same then note above - c.) this is partially done, just the code didn't check for empty result (of list of updates available) -> hence the npe just needs to be caught and fixed |
(0031399) bemaill (viewer) 2010-09-27 19:24 |
In my opinion this might be confusing: - When changing maturity_update for one module to something more restrictive -> clear update_available,update_ver_id for this one module If one does update scan, then changes the maturity acceptance level for the module from 'test'=>'general availability', saves settings (at this point the update info for the module will be cleaned), and immediately changes the maturity acceptance level for the module back to 'test' we expect the update info be available for the module, but in fact it's already gone. Should we clean update information for all modules every time something is changed on 'Setting' tab? In other words - every time (any) settings are changed the user would have to trigger 'update scan'. It's not gonna happen too often so I suppose it's acceptable. |
(0031400) iciordia (viewer) 2010-09-27 20:19 |
Valery, I don't see a big problem with update info being cleaned after doing any change in the settings of acceptance level, although in some cases those changes do not really change the "visibility" of module-versions from that instance. Maybe we could add a message in the settings window to let the user know that the update info has been removed -in order to ensure consistency-. Ismael |
(0031791) hgbot (developer) 2010-10-13 09:07 |
Repository: erp/devel/pi Changeset: c8cc677ecd9920f8396a4297839013d84eb18d1a Author: Valery Lezhebokov <valery.lezhebokov <at> gmail.com> Date: Wed Oct 06 12:03:47 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/c8cc677ecd9920f8396a4297839013d84eb18d1a [^] Fixes issue 14270: When changing the Settings from General Availabity to Test and the other way around an error is shown --- M src-db/database/sourcedata/AD_MESSAGE.xml M src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java M src/org/openbravo/erpCommon/ad_forms/ModuleManagementInstalled.html M src/org/openbravo/erpCommon/ad_forms/ModuleManagement_data.xsql --- |
(0031837) hudsonbot (viewer) 2010-10-13 23:38 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/c8cc677ecd99 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/c531f0a7334b [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18531.obx [^] |
![]() |
|||
Date Modified | Username | Field | Change |
2010-08-24 10:31 | psanjuan | New Issue | |
2010-08-24 10:31 | psanjuan | Assigned To | => alostale |
2010-08-24 10:31 | psanjuan | OBNetwork customer | => No |
2010-08-24 10:48 | psanjuan | Description Updated | View Revisions |
2010-08-24 10:49 | psanjuan | File Added: scan_test.png | |
2010-08-24 10:50 | psanjuan | Steps to Reproduce Updated | View Revisions |
2010-08-24 10:50 | psanjuan | File Added: scan_ga.png | |
2010-08-24 17:52 | shuehner | Note Added: 0030261 | |
2010-08-24 18:14 | iciordia | Note Added: 0030262 | |
2010-08-24 18:20 | shuehner | Note Added: 0030264 | |
2010-08-30 09:04 | alostale | Status | new => scheduled |
2010-08-30 09:04 | alostale | fix_in_branch | => pi |
2010-09-24 15:05 | alostale | Assigned To | alostale => bemaill |
2010-09-27 08:50 | alostale | Relationship added | related to 0014650 |
2010-09-27 19:24 | bemaill | Note Added: 0031399 | |
2010-09-27 20:19 | iciordia | Note Added: 0031400 | |
2010-10-13 09:07 | hgbot | Checkin | |
2010-10-13 09:07 | hgbot | Note Added: 0031791 | |
2010-10-13 09:07 | hgbot | Status | scheduled => resolved |
2010-10-13 09:07 | hgbot | Resolution | open => fixed |
2010-10-13 09:07 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/c8cc677ecd9920f8396a4297839013d84eb18d1a [^] |
2010-10-13 10:08 | alostale | Status | resolved => closed |
2010-10-13 10:08 | alostale | Fixed in Version | => 2.50MP23 |
2010-10-13 23:38 | hudsonbot | Checkin | |
2010-10-13 23:38 | hudsonbot | Note Added: 0031837 | |
2010-10-14 00:00 | anonymous | sf_bug_id | 0 => 3086966 |
Copyright © 2000 - 2009 MantisBT Group |