Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0014235
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2010-08-18 13:552010-10-30 11:24
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision8fe20cfac148
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0014235: Missing order by clause in Field_data.xsql selectDefaultValue method

DescriptionThe Wad engine calls the sql-query defined in FieldsData.selectDefaultValues twice and assumes that the rows are returned in the same order (as one call generates a java-function and the second call generates the call to this function (and the order of parameters needs to agree)).

The order of returned rows is not guaranteed to be stable without the order by clause showing itself in two problems:

- diffing srcAD with two different runs of compile.complete shows unneeded differences (harmless but annoying)
- sometimes (i.e. when changing Wad to be multi-threaded) the order is different inside one compile.complete run leaving to compile error of the generated files
TagsNo tags attached.
Attached Filesdiff file icon 14235.diff [^] (530 bytes) 2010-08-18 13:56 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate defect 0011752 closedalostale Default values of WAD generated windows do not work always. 

-  Notes
(0032146)
hgbot (developer)
2010-10-24 23:14

 Repository: erp/devel/pi
Changeset: 8fe20cfac1483a258e3a6da99c937c0ee45cfb68
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sun Oct 24 23:13:50 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8fe20cfac1483a258e3a6da99c937c0ee45cfb68 [^]

Fixed 14235: Missing order by clause in Field_data.xsql selectDefaultValue
Which does lead to compile-errors in some cases if db result-order returned by
two calls to the method (with same parameters) differs

---
M src-wad/src/org/openbravo/wad/Fields_data.xsql
---
(0032164)
marvintm (viewer)
2010-10-25 10:13

 Code-reviewed. Verified that the previous non-order is not a factor due to how the query is used, and that the change will produce a consistent order from now on.
(0032192)
hudsonbot (viewer)
2010-10-25 19:37

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/8fe20cfac148 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/8e23f326cade [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18733.obx [^]

- Issue History
Date Modified Username Field Change
2010-08-18 13:55 shuehner New Issue
2010-08-18 13:55 shuehner Assigned To => shuehner
2010-08-18 13:55 shuehner OBNetwork customer => No
2010-08-18 13:56 shuehner File Added: 14235.diff
2010-08-30 09:02 alostale Status new => scheduled
2010-10-24 23:14 hgbot Checkin
2010-10-24 23:14 hgbot Note Added: 0032146
2010-10-24 23:14 hgbot Status scheduled => resolved
2010-10-24 23:14 hgbot Resolution open => fixed
2010-10-24 23:14 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8fe20cfac1483a258e3a6da99c937c0ee45cfb68 [^]
2010-10-25 10:13 marvintm Note Added: 0032164
2010-10-25 10:13 marvintm Status resolved => closed
2010-10-25 19:37 hudsonbot Checkin
2010-10-25 19:37 hudsonbot Note Added: 0032192
2010-10-30 11:24 anonymous sf_bug_id 0 => 3098727
2012-03-29 17:14 shuehner Relationship added has duplicate 0011752

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker