Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0014140 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 03. Procurement management | major | always | 2010-08-06 12:58 | 2010-08-19 00:00 | |||
| Reporter | vmromanos | View Status | public | |||||
| Assigned To | adrianromero | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | e1e3c5b69de3 | ||||
| Projection | none | ETA | none | Target Version | 2.50MP21 | |||
| OS | Linux 32 bit | Database | PostgreSQL | Java version | 1.6.0_12 | |||
| OS Version | Debian 5.0 | Database version | 8.3.8 | Ant version | 1.7.0 | |||
| Product Version | pi | SCM revision | 70c809859a5 | |||||
| Merge Request Status | ||||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0014140: Multicurrency in purchase invoices doesn't work | |||||||
| Description | When you create a purchase invoice with a currency different from your accounting schema one and with no conversion rate defined, the application allows you to complete the invoice. If you post it, the accounting entry has the credit and debit amount equal to NULL (a 0 in the database fact_acct table). The sales invoices work fine. It's only reproducible in PI, not in MP20. It seems to be related with the new flows. | |||||||
| Steps To Reproduce | 0. Ensure there is no conversion rates in the system 1. As Openbravo Admin go to Master Data Management || Pricing || Price List, search the General Sales record and change the currency to, for example, "SOS" 2. Create a new purchase invoice selecting the "General Sales" price list 3. Insert a line 4. Try to complete the invoice. An error should be displayed informing there is no conversion rate available (see the one displayed in sales invoices) 5. If you post it, a wrong entry is created | |||||||
| Proposed Solution | Show error informing there is no conversion rate available, exactly the same one displayed for sales invoices when completing the invoice | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  null_entry.jpg [^] (19,444 bytes) 2010-08-06 13:02
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0029899) adrianromero (viewer) 2010-08-12 08:53 |
This behavior is not a regression. Current version in pi and previous versions including MP20 have the same behavior. Sales invoices behaves different than purchase invoices because when trying to complete a sales invoice, It is updated the Actual Life Time Value of the Customer and if it does not exist a valid change between the invoice currency and the customer currency an error is thrown. The real problem is that when posting the invoice (not when completing the invoice) and the accounting entries are calculated. the Accounting engine (AcctServer.java) if it does not exist a valid change between the invoice currency and the accounting schema currency just a message is written to the logs, no error is thrown and the accounting entries are created with null values. This behavior is implemented here: https://code.openbravo.com/erp/devel/pi/file/e485d4ccc287/src/org/openbravo/erpCommon/ad_forms/AcctServer.java#l1129 [^] |
|
(0030071) hgbot (developer) 2010-08-17 14:10 |
Repository: erp/devel/pi Changeset: ab63baf13ee9e1a0da20880a578b84153acbcb71 Author: Adrián Romero <adrianromero <at> openbravo.com> Date: Tue Aug 17 14:09:40 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/ab63baf13ee9e1a0da20880a578b84153acbcb71 [^] Fixes issue 0014140: Multicurrency in purchase invoices doesn't work It has been fixed the condition that checks whether a document is convertible or not --- M src/org/openbravo/erpCommon/ad_forms/AcctServer.java --- |
|
(0030073) hgbot (developer) 2010-08-17 14:50 |
Repository: erp/devel/pi Changeset: e1e3c5b69de3581519c31f04ff396024632abec0 Author: Adrián Romero <adrianromero <at> openbravo.com> Date: Tue Aug 17 14:49:38 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/e1e3c5b69de3581519c31f04ff396024632abec0 [^] Fixes issue 0014140: Multicurrency in purchase invoices doesn't work It has been added the message for not convertible documents --- M src-db/database/sourcedata/AD_MESSAGE.xml --- |
|
(0030074) adrianromero (viewer) 2010-08-17 14:53 |
* Steps to test Kindly follow the steps to reproduce and notice that when trying to post the invoice an error message will appear: Document currency cannot be converted to the Accounting Schema currency. * Other areas affected It only has been modified the logic of the accounting server when converting currencies making it more robust. |
|
(0030088) hudsonbot (viewer) 2010-08-17 21:15 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/ab63baf13ee9 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/c378f960e6c8 [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18175.obx [^] |
|
(0030090) hudsonbot (viewer) 2010-08-18 00:39 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/e1e3c5b69de3 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/2cad794ceb55 [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18177.obx [^] |
|
(0030100) sureshbabu (viewer) 2010-08-18 10:11 |
verified, system allowing the user to complete the invoice, but when we post the invoice throws the below error as "Document currency cannot be converted to the Accounting Schema currency." |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-08-06 12:58 | vmromanos | New Issue | |
| 2010-08-06 12:58 | vmromanos | Assigned To | => adrianromero |
| 2010-08-06 12:58 | vmromanos | OBNetwork customer | => No |
| 2010-08-06 13:00 | vmromanos | Steps to Reproduce Updated | View Revisions |
| 2010-08-06 13:00 | vmromanos | Proposed Solution updated | |
| 2010-08-06 13:02 | vmromanos | File Added: null_entry.jpg | |
| 2010-08-12 08:42 | adrianromero | Priority | immediate => urgent |
| 2010-08-12 08:42 | adrianromero | Status | new => scheduled |
| 2010-08-12 08:53 | adrianromero | Note Added: 0029899 | |
| 2010-08-17 14:10 | hgbot | Checkin | |
| 2010-08-17 14:10 | hgbot | Note Added: 0030071 | |
| 2010-08-17 14:10 | hgbot | Status | scheduled => resolved |
| 2010-08-17 14:10 | hgbot | Resolution | open => fixed |
| 2010-08-17 14:10 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/ab63baf13ee9e1a0da20880a578b84153acbcb71 [^] |
| 2010-08-17 14:50 | hgbot | Checkin | |
| 2010-08-17 14:50 | hgbot | Note Added: 0030073 | |
| 2010-08-17 14:50 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/ab63baf13ee9e1a0da20880a578b84153acbcb71 [^] => http://code.openbravo.com/erp/devel/pi/rev/e1e3c5b69de3581519c31f04ff396024632abec0 [^] |
| 2010-08-17 14:53 | adrianromero | Note Added: 0030074 | |
| 2010-08-17 21:15 | hudsonbot | Checkin | |
| 2010-08-17 21:15 | hudsonbot | Note Added: 0030088 | |
| 2010-08-18 00:39 | hudsonbot | Checkin | |
| 2010-08-18 00:39 | hudsonbot | Note Added: 0030090 | |
| 2010-08-18 08:51 | sureshbabu | Note Added: 0030096 | |
| 2010-08-18 10:10 | sureshbabu | Note Deleted: 0030096 | |
| 2010-08-18 10:11 | sureshbabu | Note Added: 0030100 | |
| 2010-08-18 10:11 | sureshbabu | Status | resolved => closed |
| 2010-08-19 00:00 | anonymous | sf_bug_id | 0 => 3048130 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |