Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0014092
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2010-07-29 17:122010-10-30 11:24
ReporterjpabloaeView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision617b923454aa
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionCommunity ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionpiSCM revisionacbf6d8e8822 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0014092: HttpsUtils.java: unused code

DescriptionThe src/org/openbravo/erpCommon/utility/HttpsUtils.java file contains some unused code, the one related to SSL certificate installation.
Proposed SolutionThat should be removed and the license should be set back to OBPL.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0029673)
jpabloae (reporter)
2010-07-29 17:27

This change will break the API. Given that it makes no sense for anyone to use these classes it will be accepted.
(0032142)
hgbot (developer)
2010-10-24 22:33

Repository: erp/devel/pi
Changeset: 617b923454aaa7e668592787b6731d5fc49dc709
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Wed Sep 29 17:40:27 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/617b923454aaa7e668592787b6731d5fc49dc709 [^]

Fixed issue 14092.Removed unused code. Deprecated public methods.

---
M src/org/openbravo/erpCommon/ad_process/HeartbeatProcess.java
M src/org/openbravo/erpCommon/modules/ImportModule.java
M src/org/openbravo/erpCommon/obps/ActiveInstanceProcess.java
M src/org/openbravo/erpCommon/utility/HttpsUtils.java
---
(0032143)
hgbot (developer)
2010-10-24 22:33

Repository: erp/devel/pi
Changeset: fd3f1b6a63c6f923c6f692832cef1245efedfcf5
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Wed Sep 29 17:45:43 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/fd3f1b6a63c6f923c6f692832cef1245efedfcf5 [^]

Related to issue 14092.Fixed license.

---
M src/org/openbravo/erpCommon/obps/ActiveInstanceProcess.java
M src/org/openbravo/erpCommon/utility/HttpsUtils.java
---
(0032188)
hudsonbot (developer)
2010-10-25 19:36

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/617b923454aa [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/8e23f326cade [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18733.obx [^]
(0032189)
hudsonbot (developer)
2010-10-25 19:36

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/fd3f1b6a63c6 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/8e23f326cade [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18733.obx [^]
(0032223)
shuehner (administrator)
2010-10-26 15:35

Code reviewed and all users of the code in core executed once.
Background: This deleted code could be used to auto-accept any certificate based on some certificate field, is the certificate received from the server was not already accepted by java. As the normal certificates used by ob-provided servers are accepted and the used certificate (butler) does not use the special marker value this code was not used in practice with the erp and can thus be removed safely.

- Issue History
Date Modified Username Field Change
2010-07-29 17:12 jpabloae New Issue
2010-07-29 17:12 jpabloae Assigned To => alostale
2010-07-29 17:14 jpabloae Issue Monitored: pjuvara
2010-07-29 17:27 jpabloae Note Added: 0029673
2010-08-02 08:09 alostale Status new => scheduled
2010-10-24 22:33 hgbot Checkin
2010-10-24 22:33 hgbot Note Added: 0032142
2010-10-24 22:33 hgbot Status scheduled => resolved
2010-10-24 22:33 hgbot Resolution open => fixed
2010-10-24 22:33 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/617b923454aaa7e668592787b6731d5fc49dc709 [^]
2010-10-24 22:33 hgbot Checkin
2010-10-24 22:33 hgbot Note Added: 0032143
2010-10-25 19:36 hudsonbot Checkin
2010-10-25 19:36 hudsonbot Note Added: 0032188
2010-10-25 19:36 hudsonbot Checkin
2010-10-25 19:36 hudsonbot Note Added: 0032189
2010-10-26 15:35 shuehner Note Added: 0032223
2010-10-26 15:35 shuehner Status resolved => closed
2010-10-30 11:24 anonymous sf_bug_id 0 => 3098726


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker