Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0014025

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] Z. Others

minor

have not tried

2010-07-21 14:20

2010-12-09 16:03

Reporter

shuehner

View Status

public

Assigned To

iperdomo

Priority

urgent

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

pi

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

2.50

SCM revision

Merge Request Status

Review Assigned To

OBNetwork customer

No

Web browser

Modules

User Interface Selector

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0014025: The 'Filter Expression' field should also use the callout to help with testing a js-expression (similar to Default Expression)

Description

The same callout which is used for evaluating a 'Default Expression' should also be used for the 'Filter Expression' field.

This allows more rapid evaluation/testing of js-expressions there also.

Tags

No tags attached.

14025.diff [^] (1,845 bytes) 2010-07-21 14:21 [Show Content] [Hide Content]

diff --git a/src-db/database/sourcedata/AD_COLUMN.xml b/src-db/database/sourcedata/AD_COLUMN.xml
--- a/src-db/database/sourcedata/AD_COLUMN.xml
+++ b/src-db/database/sourcedata/AD_COLUMN.xml
@@ -2045,6 +2045,7 @@
 <!--C43DB530998E488FB51F987257B0689A-->  <ISSESSIONATTR><![CDATA[N]]></ISSESSIONATTR>
 <!--C43DB530998E488FB51F987257B0689A-->  <ISSECONDARYKEY><![CDATA[N]]></ISSECONDARYKEY>
 <!--C43DB530998E488FB51F987257B0689A-->  <ISDESENCRYPTABLE><![CDATA[N]]></ISDESENCRYPTABLE>
+<!--C43DB530998E488FB51F987257B0689A-->  <AD_CALLOUT_ID><![CDATA[B1A343FFF5804FA9ADEF047C91654A12]]></AD_CALLOUT_ID>
 <!--C43DB530998E488FB51F987257B0689A-->  <DEVELOPMENTSTATUS><![CDATA[RE]]></DEVELOPMENTSTATUS>
 <!--C43DB530998E488FB51F987257B0689A-->  <AD_MODULE_ID><![CDATA[5EB4F15C80684ACA904756BDC12ADBE5]]></AD_MODULE_ID>
 <!--C43DB530998E488FB51F987257B0689A-->  <POSITION><![CDATA[12]]></POSITION>
diff --git a/src/org/openbravo/userinterface/selector/DefaultExpressionCallout.java b/src/org/openbravo/userinterface/selector/DefaultExpressionCallout.java
--- a/src/org/openbravo/userinterface/selector/DefaultExpressionCallout.java
+++ b/src/org/openbravo/userinterface/selector/DefaultExpressionCallout.java
@@ -83,7 +83,13 @@
     sb.append("var calloutName='").append(this.getClass().getName()).append("';\n");
     sb.append("var respuesta = [");
 
-    String js = vars.getStringParameter("inpdefaultExpression");
+    String inpLastFieldChanged = vars.getStringParameter("inpLastFieldChanged");
+    String js = "";
+    if ("inpdefaultExpression".equals(inpLastFieldChanged)) {
+      js = vars.getStringParameter("inpdefaultExpression");
+    } else if ("inpfilterExpression".equals(inpLastFieldChanged)) {
+      js = vars.getStringParameter("inpfilterExpression");
+    }
 
     if (js.equals("")) {
       sb.append(CLEAR_MSG_CODE + "];\n");

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

feature request

closed

It should be possible to assignes default values for fields on selectors

Notes
(0029441) shuehner (administrator) 2010-07-21 14:21	Attached possible patch for attaching the callout to the second field also + a mini change to be able to cope with both input fieldnames.

(0029463) hgbot (developer) 2010-07-22 09:38	Repository: erp/mods/org.openbravo.userinterface.selector Changeset: eefd1ddf034093dfc98b30e94144113f12b158a2 Author: Iván Perdomo <ivan.perdomo <at> openbravo.com> Date: Thu Jul 22 09:37:58 2010 +0200 URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/eefd1ddf034093dfc98b30e94144113f12b158a2 [^] Fixes issue 14025: Added callout to filter expression - Apply diff provided in the issue - Moved info/warning messages to AD_Message --- M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_MESSAGE.xml M src/org/openbravo/userinterface/selector/DefaultExpressionCallout.java ---

(0029471) shuehner (administrator) 2010-07-22 16:23	Reviewed & Tested on selector module from hg, rev: eefd1ddf0340 Now callout is used in both places to evaluate the entered js-expression.

Issue History
Date Modified	Username	Field	Change
2010-07-21 14:20	shuehner	New Issue
2010-07-21 14:20	shuehner	Assigned To	=> iperdomo
2010-07-21 14:20	shuehner	OBNetwork customer	=> No
2010-07-21 14:20	shuehner	Relationship added	blocks 0013458
2010-07-21 14:21	shuehner	File Added: 14025.diff
2010-07-21 14:21	shuehner	Note Added: 0029441
2010-07-21 19:08	iperdomo	Status	new => scheduled
2010-07-21 19:08	iperdomo	fix_in_branch	=> pi
2010-07-22 09:38	hgbot	Checkin
2010-07-22 09:38	hgbot	Note Added: 0029463
2010-07-22 09:38	hgbot	Status	scheduled => resolved
2010-07-22 09:38	hgbot	Resolution	open => fixed
2010-07-22 09:38	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/eefd1ddf034093dfc98b30e94144113f12b158a2 [^]
2010-07-22 16:23	shuehner	Note Added: 0029471
2010-07-22 16:23	shuehner	Status	resolved => closed
2010-12-09 16:03	anonymous	sf_bug_id	0 => 3133324

Copyright © 2000 - 2009 MantisBT Group