Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0014023
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersmajorhave not tried2010-07-21 13:492010-12-09 16:03
ReportershuehnerView Statuspublic 
Assigned Toiperdomo 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revisiona9884304fd40
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50SCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesUser Interface Selector
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0014023: Can't create default expression using a constant String for the expression

DescriptionI wanted to create a default expression for the name field of a bpartner selector with the value The% to filter by all names starting with the prefix: The.

I tried:
The% -> wrong as expression needs to return a string
"The%" -> HQL error
"'The%'" -> no rows shown anymore, no error-msg, expression not shown in selector grid

Steps To ReproduceInstall attached module
check i.e. Purchase Order window
and try to use the new defined Business Partner Selector in there.
TagsNo tags attached.
Attached Files? file icon org.test2-0.0.3.obx [^] (5,314 bytes) 2010-07-21 13:50
? file icon org.test-0.0.3.obx [^] (2,579 bytes) 2010-07-21 13:50

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks feature request 0013458 closediperdomo It should be possible to assignes default values for fields on selectors 

-  Notes
(0029452)
iperdomo (viewer)
2010-07-21 19:04

 The final Default Expression is: "The%"

Without the need of extra single quotes and/or scape characters. Remember that the default expression will be translated to HQL in the form:

  property = default

In this case will be translated to: name = 'The%'

This is not the 'expected' behavior because to filter with % you need to use the _like_ operator, e.g. name like 'The%'

This initial implementation should only work with equals. If you want to use the _like_ operator, use the Filter expression at Selector level.
(0029453)
hgbot (developer)
2010-07-21 19:06

 Repository: erp/mods/org.openbravo.userinterface.selector
Changeset: fe52ad4fcb2ecad75d99f14d35fffab17c78426b
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Wed Jul 21 19:05:57 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/fe52ad4fcb2ecad75d99f14d35fffab17c78426b [^]

Fixes issue 14023: Quote expression when the value is string

---
M web/org.openbravo.userinterface.selector/js/ob_selector_widget.js
---
(0029475)
hgbot (developer)
2010-07-22 17:01

 Repository: erp/mods/org.openbravo.userinterface.selector
Changeset: 27407b4c34b9870c86d14b5a84ee66750f0c4941
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Jul 22 17:00:28 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/27407b4c34b9870c86d14b5a84ee66750f0c4941 [^]

Fixes issue 14023: Removed qouting logic when dealing with string def. values
Removed the front-end logic to quote string default values, and just add the
default value to the request map. This rely on the backend code.

---
M web/org.openbravo.userinterface.selector/js/ob_selector_widget.js
---
(0029481)
hgbot (developer)
2010-07-22 18:17

 Repository: erp/mods/org.openbravo.service.datasource
Changeset: c550eaa588ccb596d0a1283c5e891201080783fc
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Jul 22 18:17:13 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.service.datasource/rev/c550eaa588ccb596d0a1283c5e891201080783fc [^]

Fixes issue 14023: Removed java logic to handle _def_ parameters

---
M src/org/openbravo/service/datasource/DefaultDataSourceService.java
---
(0029589)
hgbot (developer)
2010-07-27 13:12

 Repository: erp/mods/org.openbravo.userinterface.selector
Changeset: f5fbce871181e897462cbfcab0dbfc21098cc6c3
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Tue Jul 27 13:11:06 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/f5fbce871181e897462cbfcab0dbfc21098cc6c3 [^]

Fixes issue 14023: Refactored default expression using action handler
- The default values are now calculated on each open selector request since it
  could be using a session value
- Moved the logic to use Action handler
- Removed the logic to calculate the defaults values in the components since
  it makes no sense
- Added formatDate and formatDateTime to the OB object to be able to format
  dates: OB.formatDate(new Date()) - will give you today's date with the
  default format used by the application

---
M src/org/openbravo/userinterface/selector/DefaultExpressionCallout.java
M src/org/openbravo/userinterface/selector/OBBindings.java
M src/org/openbravo/userinterface/selector/SelectorComponent.java
M src/org/openbravo/userinterface/selector/templates/selector.ftl
M web/org.openbravo.userinterface.selector/js/ob_selector_link_widget.js
M web/org.openbravo.userinterface.selector/js/ob_selector_widget.js
A src/org/openbravo/userinterface/selector/SelectorDefaultFilterActionHandler.java
---
(0029617)
hgbot (developer)
2010-07-27 18:04

 Repository: erp/mods/org.openbravo.userinterface.selector
Changeset: 46c743109767bf9b01e5decf8af3f15c4ab81c50
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Tue Jul 27 18:02:37 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/46c743109767bf9b01e5decf8af3f15c4ab81c50 [^]

Fixes issue 14023: Refactored the selector datasource filter
- The datasource filter applies a filter for the selector when using the
  suggestion box
- Skips the default values when the properties come in the request

---
M src/org/openbravo/userinterface/selector/SelectorDataSourceFilter.java
M web/org.openbravo.userinterface.selector/js/ob_selector_widget.js
---
(0029634)
hgbot (developer)
2010-07-28 10:37

 Repository: erp/mods/org.openbravo.userinterface.selector
Changeset: e540cd4361d078e9b7d167f8b6ab50c14bfb31df
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Wed Jul 28 10:35:33 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/e540cd4361d078e9b7d167f8b6ab50c14bfb31df [^]

Fixes issue 14023: Modified the way to apply default filters
- When using the suggestion box we just modify the parameters map and delegate
  the rest to the datasource service

---
M src/org/openbravo/userinterface/selector/SelectorDataSourceFilter.java
---
(0029648)
hgbot (developer)
2010-07-28 17:18

 Repository: erp/mods/org.openbravo.userinterface.selector
Changeset: 36dce69bff1dd4d402513ca5780d2969693ad703
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Wed Jul 28 17:17:09 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/36dce69bff1dd4d402513ca5780d2969693ad703 [^]

Issue 14023: Added debug info when skipping evaluation

---
M src/org/openbravo/userinterface/selector/SelectorDataSourceFilter.java
---
(0029916)
hgbot (developer)
2010-08-12 13:49

 Repository: erp/mods/org.openbravo.userinterface.selector
Changeset: fccddc83c82619bf9ae5b8971c163b44873c44df
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Aug 12 13:49:10 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/fccddc83c82619bf9ae5b8971c163b44873c44df [^]

Fixes issue 14023: Fixes NPE when having default at field without a filter
 Fixes NPE when defining default expressions but without a filter expression in
 the selector definition

---
M src/org/openbravo/userinterface/selector/SelectorDataSourceFilter.java
---
(0029950)
hgbot (developer)
2010-08-13 10:10

 Repository: erp/mods/org.openbravo.userinterface.selector
Changeset: 039694384399006a4a16f1ed34605f41a4f04504
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Fri Aug 13 10:10:02 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/039694384399006a4a16f1ed34605f41a4f04504 [^]

Fixes issue 14023: Fixes date formatting when fetching data
The QueryBuilder used by the json datasource service uses a fixed date format
dd-MM-yyyy, therefore the date format configured in the systems needs to
reformat the date values to match the QueryBuilder one.
Since OB.formatDate() uses SimpleDateFormat class and returns a String, the
current way to detect if a field property needs reformatting is through the
selector field name, it _must_ end with the word 'date' (ignoring case)

---
M src/org/openbravo/userinterface/selector/SelectorDataSourceFilter.java
M web/org.openbravo.userinterface.selector/js/ob_selector_widget.js
---
(0029958)
hgbot (developer)
2010-08-13 16:22

 Repository: erp/mods/org.openbravo.userinterface.selector
Changeset: 40b61d1b5e75dbc1aa3e4ef08ca1ec46e73a88fb
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Fri Aug 13 16:21:47 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/40b61d1b5e75dbc1aa3e4ef08ca1ec46e73a88fb [^]

Fixes issue 14023: Fixed reference to selector id

---
M web/org.openbravo.userinterface.selector/js/ob_selector_widget.js
---
(0030130)
hgbot (developer)
2010-08-18 18:20

 Repository: erp/mods/org.openbravo.userinterface.selector
Changeset: 27f84eda8dd91a94e5b63f7f28bd4ea3f06a9e6a
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Wed Aug 18 18:19:45 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/27f84eda8dd91a94e5b63f7f28bd4ea3f06a9e6a [^]

Fixes issue 14023: Refactored the Default/Filter expression handling
- Added new methods to the OBBindings: parseDate, and formatDate passing a
  format as second parameter
- Refactored the filter and default expressions. Now the _where parameter is
  modified when filtering data, and the result expressions are appended as
  _and_
- Fixed issue of duplicated 'Yes' entry in boolean columns
- The popup window 'flags' its requests with a _requestType='Window'
- Evaluation of expressions on 'suggestion box searchable fields' is skipped
  when using the suggestion box

---
M src/org/openbravo/userinterface/selector/OBBindings.java
M src/org/openbravo/userinterface/selector/SelectorConstants.java
M src/org/openbravo/userinterface/selector/SelectorDataSourceFilter.java
M src/org/openbravo/userinterface/selector/SelectorDefaultFilterActionHandler.java
M web/org.openbravo.userinterface.selector/js/ob_selector_widget.js
---
(0030131)
hgbot (developer)
2010-08-18 18:23

 Repository: erp/mods/org.openbravo.service.json
Changeset: acb773f3638139d2392a0447d7cbad963c165e9a
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Wed Aug 18 18:22:53 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.service.json/rev/acb773f3638139d2392a0447d7cbad963c165e9a [^]

Related to issue 14023: Added comment to QueryBuilder
- The implementation of QueryBuilder.getWhere method needs to be in sync with
  the SelectorDataSourceFilter

---
M src/org/openbravo/service/json/QueryBuilder.java
---
(0030160)
hgbot (developer)
2010-08-19 17:09

 Repository: erp/mods/org.openbravo.userinterface.selector
Changeset: a9884304fd4062bddbfa3b90fd370fed07024672
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Aug 19 17:08:18 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/a9884304fd4062bddbfa3b90fd370fed07024672 [^]

Fixes issue 14023: Removed logic to identify the type of result
- The result of the JS expression is added directly to the JSON object map so
  the library needs to handle the data type of the object

---
M src/org/openbravo/userinterface/selector/SelectorDefaultFilterActionHandler.java
---
(0030373)
hgbot (developer)
2010-08-26 16:53

 Repository: erp/mods/org.openbravo.service.json
Changeset: 4653df7f33e75285cb2aa376e292a78edb259fee
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Aug 26 16:52:42 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.service.json/rev/4653df7f33e75285cb2aa376e292a78edb259fee [^]

Issue 14023: Code clean up, removed unused constant
This constant was used to identify default values in request parameters, not
needed anymore, since all evaluation is made in the server side

---
M src/org/openbravo/service/json/JsonConstants.java
---
(0030375)
hgbot (developer)
2010-08-26 18:31

 Repository: erp/mods/org.openbravo.userinterface.selector
Changeset: 3e63acf5ea992e5421f5ef6e95e69de85fc2a5ab
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Aug 26 18:31:28 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/3e63acf5ea992e5421f5ef6e95e69de85fc2a5ab [^]

Issue 14023: Changed replace with replaceAll call, related to Issue 13945
The change is to sync the code with the QueryBuilder class, it should treat
all spaces as wildcard when using 'contains'

---
M src/org/openbravo/userinterface/selector/SelectorDataSourceFilter.java
---
(0030469)
shuehner (administrator)
2010-08-30 15:29

 Marking as closed as specified testcase is now working fine and also all the other related issues (related to project default/filter expressions) are reviewed and closed now.

- Issue History
Date Modified Username Field Change
2010-07-21 13:49 shuehner New Issue
2010-07-21 13:49 shuehner Assigned To => iperdomo
2010-07-21 13:49 shuehner OBNetwork customer => No
2010-07-21 13:50 shuehner File Added: org.test2-0.0.3.obx
2010-07-21 13:50 shuehner File Added: org.test-0.0.3.obx
2010-07-21 13:51 iperdomo Relationship added blocks 0013458
2010-07-21 13:51 iperdomo Status new => scheduled
2010-07-21 13:51 iperdomo fix_in_branch => pi
2010-07-21 19:04 iperdomo Note Added: 0029452
2010-07-21 19:06 hgbot Checkin
2010-07-21 19:06 hgbot Note Added: 0029453
2010-07-21 19:06 hgbot Status scheduled => resolved
2010-07-21 19:06 hgbot Resolution open => fixed
2010-07-21 19:06 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/fe52ad4fcb2ecad75d99f14d35fffab17c78426b [^]
2010-07-22 17:01 hgbot Checkin
2010-07-22 17:01 hgbot Note Added: 0029475
2010-07-22 17:01 hgbot Fixed in SCM revision http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/fe52ad4fcb2ecad75d99f14d35fffab17c78426b [^] => http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/27407b4c34b9870c86d14b5a84ee66750f0c4941 [^]
2010-07-22 18:17 hgbot Checkin
2010-07-22 18:17 hgbot Note Added: 0029481
2010-07-22 18:17 hgbot Fixed in SCM revision http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/27407b4c34b9870c86d14b5a84ee66750f0c4941 [^] => http://code.openbravo.com/erp/mods/org.openbravo.service.datasource/rev/c550eaa588ccb596d0a1283c5e891201080783fc [^]
2010-07-27 13:12 hgbot Checkin
2010-07-27 13:12 hgbot Note Added: 0029589
2010-07-27 13:12 hgbot Fixed in SCM revision http://code.openbravo.com/erp/mods/org.openbravo.service.datasource/rev/c550eaa588ccb596d0a1283c5e891201080783fc [^] => http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/f5fbce871181e897462cbfcab0dbfc21098cc6c3 [^]
2010-07-27 18:04 hgbot Checkin
2010-07-27 18:04 hgbot Note Added: 0029617
2010-07-27 18:04 hgbot Fixed in SCM revision http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/f5fbce871181e897462cbfcab0dbfc21098cc6c3 [^] => http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/46c743109767bf9b01e5decf8af3f15c4ab81c50 [^]
2010-07-28 10:37 hgbot Checkin
2010-07-28 10:37 hgbot Note Added: 0029634
2010-07-28 10:37 hgbot Fixed in SCM revision http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/46c743109767bf9b01e5decf8af3f15c4ab81c50 [^] => http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/e540cd4361d078e9b7d167f8b6ab50c14bfb31df [^]
2010-07-28 17:18 hgbot Checkin
2010-07-28 17:18 hgbot Note Added: 0029648
2010-08-12 13:49 hgbot Checkin
2010-08-12 13:49 hgbot Note Added: 0029916
2010-08-12 13:49 hgbot Fixed in SCM revision http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/e540cd4361d078e9b7d167f8b6ab50c14bfb31df [^] => http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/fccddc83c82619bf9ae5b8971c163b44873c44df [^]
2010-08-13 10:10 hgbot Checkin
2010-08-13 10:10 hgbot Note Added: 0029950
2010-08-13 10:10 hgbot Fixed in SCM revision http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/fccddc83c82619bf9ae5b8971c163b44873c44df [^] => http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/039694384399006a4a16f1ed34605f41a4f04504 [^]
2010-08-13 16:22 hgbot Checkin
2010-08-13 16:22 hgbot Note Added: 0029958
2010-08-13 16:22 hgbot Fixed in SCM revision http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/039694384399006a4a16f1ed34605f41a4f04504 [^] => http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/40b61d1b5e75dbc1aa3e4ef08ca1ec46e73a88fb [^]
2010-08-18 18:20 hgbot Checkin
2010-08-18 18:20 hgbot Note Added: 0030130
2010-08-18 18:20 hgbot Fixed in SCM revision http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/40b61d1b5e75dbc1aa3e4ef08ca1ec46e73a88fb [^] => http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/27f84eda8dd91a94e5b63f7f28bd4ea3f06a9e6a [^]
2010-08-18 18:23 hgbot Checkin
2010-08-18 18:23 hgbot Note Added: 0030131
2010-08-19 17:09 hgbot Checkin
2010-08-19 17:09 hgbot Note Added: 0030160
2010-08-19 17:09 hgbot Fixed in SCM revision http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/27f84eda8dd91a94e5b63f7f28bd4ea3f06a9e6a [^] => http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/a9884304fd4062bddbfa3b90fd370fed07024672 [^]
2010-08-26 16:53 hgbot Checkin
2010-08-26 16:53 hgbot Note Added: 0030373
2010-08-26 18:31 hgbot Checkin
2010-08-26 18:31 hgbot Note Added: 0030375
2010-08-30 15:29 shuehner Note Added: 0030469
2010-08-30 15:29 shuehner Status resolved => closed
2010-12-09 16:03 anonymous sf_bug_id 0 => 3133322

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker