Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0013854
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 01. General setupmajoralways2010-07-01 12:582010-08-24 11:53
ReporternetworkbView Statuspublic 
Assigned Toadrianromero 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionc74447443fa3
ProjectionnoneETAnoneTarget Version2.50MP20
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50MP19SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0013854: If the reciptien of an alert has an email defined the alert is sent by email althought you don't have define it

DescriptionIf the reciptien of an alert has an email defined the alert is sent by email althought you don't have define it
Steps To Reproduce-configure the header tab on the client definition window to use email.Do it for small bazar.

-Has Openbravo Admin, create a new user and define an email for it.
-Create an alert for smallbazar client, i.e:
select req.m_requisition_id as referencekey_id,
       req.documentno as record_id,
       0 as ad_role_id,
       req.ad_user_id as ad_user_id,
       'La solicitud '||req.documentno||' no tiene descripcion' as description,
       'Y' as isActive,
        req.ad_org_id,
        req.ad_client_id,
        now() as created,
        0 as createdBy,
        now() as updated,
        0 as updatedby
  from m_requisition req
  where req.description is null;
-In the recipient tab add the user defined previously.
-Don't check the sendmail checkbox
-Create a requistion without description to launch te alert created previosly
-When the alert is created see that an email is send.
Proposed SolutionOn the AlertProcess_data.xsql file
modify the preparemail method
adding a new condtion for each select on the union
as

AND AR.AND SENDEMAIL = 'Y'
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0028954)
hgbot (developer)
2010-07-01 16:31

Repository: erp/devel/pi
Changeset: c74447443fa374eef36f1062ce98af78362df172
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Jul 01 16:30:59 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c74447443fa374eef36f1062ce98af78362df172 [^]

Fixes issue 0013854: If the reciptien of an alert has an email defined the alert is sent by email althought you don't have define it
It has been added a filter to the prepareMails sentence to get only records that have the sendemail field active.

---
M src/org/openbravo/erpCommon/ad_process/AlertProcess_data.xsql
---
(0028956)
adrianromero (manager)
2010-07-01 16:35

* Testing of the issue

Follow the steps to reproduce and notice that when the alert is created no email will be sent

* Other areas affected

Only the function that sends mail for alerts it is affected, no other areas to test.
(0029005)
hudsonbot (developer)
2010-07-02 14:51

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/c74447443fa3 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/8fd5a427789e [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17797.obx [^]
(0029492)
sureshbabu (reporter)
2010-07-23 09:00

verified
(0030244)
psarobe (manager)
2010-08-24 11:53

Finally this is not a regression but an issue that was not properly fixed. The original issue that caused the "regression" was 0011811 but after doing some research it came out that the issue was not properly fixed. Before issue 0011811 you didn't receive any email and after that fixed you always received an email even you didn't want to. So the correct action would have been to reopen the issue since it was not properly fixed

- Issue History
Date Modified Username Field Change
2010-07-01 12:58 networkb New Issue
2010-07-01 12:58 networkb Assigned To => adrianromero
2010-07-01 13:15 networkb Target Version => 2.50MP20
2010-07-01 16:31 hgbot Checkin
2010-07-01 16:31 hgbot Note Added: 0028954
2010-07-01 16:31 hgbot Status new => resolved
2010-07-01 16:31 hgbot Resolution open => fixed
2010-07-01 16:31 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c74447443fa374eef36f1062ce98af78362df172 [^]
2010-07-01 16:35 adrianromero Note Added: 0028956
2010-07-02 12:00 psarobe Tag Attached: Regression
2010-07-02 14:51 hudsonbot Checkin
2010-07-02 14:51 hudsonbot Note Added: 0029005
2010-07-23 09:00 sureshbabu Note Added: 0029492
2010-07-23 09:00 sureshbabu Status resolved => closed
2010-07-24 00:00 anonymous sf_bug_id 0 => 3033807
2010-08-24 11:49 psarobe Tag Detached: Regression
2010-08-24 11:53 psarobe Note Added: 0030244


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker