Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0013852 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 07. Sales management | major | have not tried | 2010-06-30 18:49 | 2010-07-24 00:00 | |||
| Reporter | jonalegriaesarte | View Status | public | |||||
| Assigned To | adrianromero | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | 5dd3d4843cb3 | |||
| Projection | none | ETA | none | Target Version | 2.50MP20 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0013852: Rollback missed in CreateFrom class | |||||||
| Description | In file src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java, method saveInvoice a rollback is missed in this piece of code: if (isSOTrx.equals("Y")) data = CreateFromInvoiceData.selectFromShipmentUpdateSOTrx(conn, this, strClaves); else data = CreateFromInvoiceData.selectFromShipmentUpdate(conn, this, strClaves); dataAux = CreateFromInvoiceData.selectPriceList(conn, this, strDateInvoiced, strPriceList); if (dataAux == null || dataAux.length == 0) { myMessage = Utility.translateError(this, vars, vars.getLanguage(), "PriceListVersionNotFound"); return myMessage; } The rollback (releaseRollbackConnection(conn) line) must be before the return. This problem could happen in other pieces of code. | |||||||
| Proposed Solution | The code must be if (dataAux == null || dataAux.length == 0) { myMessage = Utility.translateError(this, vars, vars.getLanguage(), "PriceListVersionNotFound"); releaseRollbackConnection(conn); return myMessage; } | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0029210) hgbot (developer) 2010-07-11 07:30 |
Repository: erp/devel/pi Changeset: 5dd3d4843cb36bbb63b134f51e2a3c79ac68484b Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com> Date: Sun Jul 11 10:56:34 2010 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/5dd3d4843cb36bbb63b134f51e2a3c79ac68484b [^] Fixes issue 13852: Rollback missed in CreateFrom class. --- M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java --- |
|
(0029211) harikrishnan (reporter) 2010-07-11 07:31 |
Steps to test: *The fix is to be tested in "Create Lines From" button in sales invoice. Root Cause: *Before when error is thrown this rolling back is not their. Impact: Their is no impact of this changeset. |
|
(0029280) hudsonbot (developer) 2010-07-14 04:43 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/5dd3d4843cb3 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/2a91111beef4 [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17878.obx [^] |
|
(0029511) psarobe (manager) 2010-07-23 11:16 |
Verified by code review |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-06-30 18:49 | jonalegriaesarte | New Issue | |
| 2010-06-30 18:49 | jonalegriaesarte | Assigned To | => adrianromero |
| 2010-07-05 13:25 | adrianromero | Status | new => scheduled |
| 2010-07-05 13:25 | adrianromero | fix_in_branch | => pi |
| 2010-07-11 07:30 | hgbot | Checkin | |
| 2010-07-11 07:30 | hgbot | Note Added: 0029210 | |
| 2010-07-11 07:30 | hgbot | Status | scheduled => resolved |
| 2010-07-11 07:30 | hgbot | Resolution | open => fixed |
| 2010-07-11 07:30 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/5dd3d4843cb36bbb63b134f51e2a3c79ac68484b [^] |
| 2010-07-11 07:31 | harikrishnan | Note Added: 0029211 | |
| 2010-07-14 04:43 | hudsonbot | Checkin | |
| 2010-07-14 04:43 | hudsonbot | Note Added: 0029280 | |
| 2010-07-23 11:16 | psarobe | Note Added: 0029511 | |
| 2010-07-23 11:16 | psarobe | Status | resolved => closed |
| 2010-07-24 00:00 | anonymous | sf_bug_id | 0 => 3033806 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |