Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0013687
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 00. Application dictionarycriticalalways2010-06-17 15:562011-04-01 00:00
ReportergorkaionView Statuspublic 
Assigned Toalostale 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision71ae37dedcfa
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabaseOracleJava version1.5.0_15
OS VersionGentooDatabase version11gAnt version1.7.0
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0013687: Inconsistent behavior when the isDisplayed flag is changed on a field

DescriptionWhen a field is hidden unchecking the Displayed flag its Sequence Number remains as it is. But if we use the Sort tab to reorder some fields, all the sequence numbers are recalculated, setting to null the Sequence Number of the hidden fields.
Steps To ReproduceGo to any displayed field with core in development and uncheck the displayed flag (in Application Dictionary || Windows, Tabs, and Fields || Window >> Tab >> Field ). Notice that the sequence number is not changed.
Go to the Field Sequence tab and press the save button without changing anything.
Go back to the Field tab and notice that the sequence numbers have been recalculated and the hidden fields have the sequence number set to null
Proposed SolutionRecalculate the sequence numbers of fields when the isDisplayed flag is changed.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0013692 closedelopio QA The index of name column in Accounting Schema window has changed 

-  Notes
(0028560)
gorkaion (developer)
2010-06-17 15:57
edited on: 2010-06-17 15:58

currently there are many fields in core that have the isDisplayed flag set to 'N' but doesn't have its sequence number set to null. These fields will get changed whenever someone reorder the fields of the tab they belong to.

(0028561)
hgbot (developer)
2010-06-17 17:41

Repository: erp/devel/pi
Changeset: cce0b72981a2c30095e3f9daf8f94478c2f04428
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Thu Jun 17 16:50:42 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/cce0b72981a2c30095e3f9daf8f94478c2f04428 [^]

Related to issue 13687.Set to null seqno values of fields with seqno=0 and isdisplayed='N'.

---
M src-db/database/sourcedata/AD_FIELD.xml
---
(0028600)
hudsonbot (developer)
2010-06-18 23:20

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/cce0b72981a2 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/c2668b004a6e [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17687.obx [^]
(0033366)
alostale (manager)
2010-12-22 16:30

Instead of the proposed solution, this is the solution that will be implemented:

1. When isDisplayed flag or sequence number is edited, no recalculation will be done (as it is now).
2. When setting isDisplayed to false, seqNo field will automatically be set to null.
3. When editing from Field Sequence tab try to do the less changes in sequences as possible.

Implementing it in this way, no changes will happen in the described situation.
(0033368)
hgbot (developer)
2010-12-22 16:50

Repository: erp/devel/pi
Changeset: 71ae37dedcfa03bccdad2cfbbe0532b6bf2f4a51
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Dec 22 16:49:52 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/71ae37dedcfa03bccdad2cfbbe0532b6bf2f4a51 [^]

fixed bug 13687: Sort tabs are less intrusive when updating

Previously sort tabs tried to reorder all the items with an interval
between positions of 10. The only exception to this was in case the
item was in a module not in development.

Now it tries to do as less changes as possible, keeping the elements
in the same position as they were in case they were already sorted even
if their interval is not 10. When positioning a new element between 2
existent ones, it is tried its possition not to affect the other elements
but to look for a sequenece in between, only in case no free sequences
are available sequences for other elements are recalculated.

---
M src-wad/src/org/openbravo/wad/javasourceSortTab.javaxml
A src-db/database/model/triggers/AD_FIELD_TRG2.xml
---
(0033376)
hgbot (developer)
2010-12-23 13:17

Repository: erp/devel/pi
Changeset: 0b19faf71019a801e1b590d57eb2b235dddb877f
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Dec 23 13:16:54 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0b19faf71019a801e1b590d57eb2b235dddb877f [^]

related to issue 13687: Do not set to null sequence field when it is not shown

---
M src-wad/src/org/openbravo/wad/datasourceSortTab.xsqlxml
R src-db/database/model/triggers/AD_FIELD_TRG2.xml
---
(0033377)
hgbot (developer)
2010-12-23 13:31

Repository: erp/devel/pi
Changeset: 533322e2fd25e2c1d63799d9da3e09c0e391098b
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Dec 23 13:30:45 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/533322e2fd25e2c1d63799d9da3e09c0e391098b [^]

[cleanup] Remove from template changes of seqno->null in ad_field

  Related to issue 13687. Sequence of not visible fields is not set to null,
  so now these sequences are kept in the template even for not visible fields.

---
M modules/org.openbravo.v3/src-db/database/configScript.xml
---
(0033469)
hudsonbot (developer)
2010-12-30 13:15

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/71ae37dedcfa [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7d7e5eebcc62 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19448.obx [^]
(0033473)
hudsonbot (developer)
2010-12-30 13:15

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/0b19faf71019 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7d7e5eebcc62 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19448.obx [^]
(0033474)
hudsonbot (developer)
2010-12-30 13:15

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/533322e2fd25 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7d7e5eebcc62 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19448.obx [^]

- Issue History
Date Modified Username Field Change
2010-06-17 15:56 gorkaion New Issue
2010-06-17 15:56 gorkaion Assigned To => alostale
2010-06-17 15:57 gorkaion Note Added: 0028560
2010-06-17 15:58 gorkaion Note Edited: 0028560 View Revisions
2010-06-17 15:58 gorkaion Note Edited: 0028560 View Revisions
2010-06-17 17:41 hgbot Checkin
2010-06-17 17:41 hgbot Note Added: 0028561
2010-06-18 02:30 elopio Relationship added related to 0013692
2010-06-18 23:20 hudsonbot Checkin
2010-06-18 23:20 hudsonbot Note Added: 0028600
2010-06-23 10:38 alostale Status new => scheduled
2010-12-21 16:53 dmitry_mezentsev Priority normal => immediate
2010-12-21 16:53 dmitry_mezentsev Severity minor => critical
2010-12-21 17:40 shuehner Issue Monitored: shuehner
2010-12-22 16:30 alostale Note Added: 0033366
2010-12-22 16:50 hgbot Checkin
2010-12-22 16:50 hgbot Note Added: 0033368
2010-12-22 16:50 hgbot Status scheduled => resolved
2010-12-22 16:50 hgbot Resolution open => fixed
2010-12-22 16:50 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/71ae37dedcfa03bccdad2cfbbe0532b6bf2f4a51 [^]
2010-12-23 13:17 hgbot Checkin
2010-12-23 13:17 hgbot Note Added: 0033376
2010-12-23 13:31 hgbot Checkin
2010-12-23 13:31 hgbot Note Added: 0033377
2010-12-30 13:15 hudsonbot Checkin
2010-12-30 13:15 hudsonbot Note Added: 0033469
2010-12-30 13:15 hudsonbot Checkin
2010-12-30 13:15 hudsonbot Note Added: 0033473
2010-12-30 13:15 hudsonbot Checkin
2010-12-30 13:15 hudsonbot Note Added: 0033474
2011-03-31 12:51 gorkaion Status resolved => closed
2011-04-01 00:00 anonymous sf_bug_id 0 => 3265611


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker