Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0013412
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajorhave not tried2010-05-21 16:452010-06-03 22:49
ReportershuehnerView Statuspublic 
Assigned Toadrianromero 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision75ebe35a028a
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0013412: SL_Order_DocType fails with non-numeric document type ID (i.e. newly created document types)

DescriptionThe following line in the callout implementation:

if (!newDocNo && Integer.valueOf(strDocType).intValue() != 0) {

fails with newly created document types as they a UUID's and not only numbers.

        at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
        at java.lang.Integer.parseInt(Integer.java:449)
        at java.lang.Integer.valueOf(Integer.java:554)
        at org.openbravo.erpCommon.ad_callouts.SL_Order_DocType.printPage(SL_Order_DocType.java:95)
        at org.openbravo.erpCommon.ad_callouts.SL_Order_DocType.doPost(SL_Order_DocType.java:63)
TagsUUID project
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00134322.50MP20 closedharikrishnan Identifiers are now UUID and java code cannot suppose are integer values 

-  Notes
(0027645)
shuehner (administrator)
2010-05-21 16:45

 Found by seeing stacktrace in demo1.openbravo.com environment.
(0027680)
hgbot (developer)
2010-05-24 14:13

 Repository: erp/devel/pi
Changeset: 75ebe35a028a6f560d4a98c5f526499f6484fa50
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon May 24 14:12:24 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/75ebe35a028a6f560d4a98c5f526499f6484fa50 [^]

Fixes issue 0013412: SL_Order_DocType fails with non-numeric document type ID (i.e. newly created document types)
This changeset modifies the condition of comparing the strDocType with 0, the Document type for new documents, not converting the value to integer because it will fail for new document types, document types with an UUID as identifier

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Order_DocType.java
---
(0027681)
adrianromero (manager)
2010-05-24 14:16

 * Steps to test
Create a new Document Type for Sales Orders. Just coping the values form another sales order document type.
Create a new Sales order with the recently created document type and process it.
Review the stack trace and verify that the error does not appear.

Other test that has to be done is to review the stacktrace in demo1.openbravo.com environment and review that this error does not appear again.

* Other areas affected
No other areas affected. Only the Sales order window with new document types is involved in this change.
(0027688)
arunkumar (reporter)
2010-05-25 07:38

 Tested working fine
(0027689)
sureshbabu (reporter)
2010-05-25 07:42

 verified..
(0027921)
hudsonbot (developer)
2010-06-03 22:49

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/75ebe35a028a [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/c011484a38d9 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17407.obx [^]

- Issue History
Date Modified Username Field Change
2010-05-21 16:45 shuehner New Issue
2010-05-21 16:45 shuehner Assigned To => adrianromero
2010-05-21 16:45 shuehner Note Added: 0027645
2010-05-21 16:49 shuehner Tag Attached: UUID project
2010-05-24 14:13 hgbot Checkin
2010-05-24 14:13 hgbot Note Added: 0027680
2010-05-24 14:13 hgbot Status new => resolved
2010-05-24 14:13 hgbot Resolution open => fixed
2010-05-24 14:13 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/75ebe35a028a6f560d4a98c5f526499f6484fa50 [^]
2010-05-24 14:16 adrianromero Note Added: 0027681
2010-05-25 07:38 arunkumar Note Added: 0027688
2010-05-25 07:38 arunkumar Status resolved => closed
2010-05-25 07:42 sureshbabu Note Added: 0027689
2010-05-25 14:30 adrianromero Relationship added related to 0013432
2010-05-26 00:00 anonymous sf_bug_id 0 => 3007110
2010-06-03 22:49 hudsonbot Checkin
2010-06-03 22:49 hudsonbot Note Added: 0027921

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker