Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0013412 | Openbravo ERP | 07. Sales management | public | 2010-05-21 16:45 | 2010-06-03 22:49 |
|
| Reporter | shuehner | |
| Assigned To | adrianromero | |
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | pi | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0013412: SL_Order_DocType fails with non-numeric document type ID (i.e. newly created document types) |
| Description | The following line in the callout implementation:
if (!newDocNo && Integer.valueOf(strDocType).intValue() != 0) {
fails with newly created document types as they a UUID's and not only numbers.
at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
at java.lang.Integer.parseInt(Integer.java:449)
at java.lang.Integer.valueOf(Integer.java:554)
at org.openbravo.erpCommon.ad_callouts.SL_Order_DocType.printPage(SL_Order_DocType.java:95)
at org.openbravo.erpCommon.ad_callouts.SL_Order_DocType.doPost(SL_Order_DocType.java:63)
|
| Steps To Reproduce | |
| Proposed Solution | |
| Additional Information | |
| Tags | UUID project |
| Relationships | | related to | defect | 0013432 | 2.50MP20 | closed | harikrishnan | Identifiers are now UUID and java code cannot suppose are integer values |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2010-05-21 16:45 | shuehner | New Issue | |
| 2010-05-21 16:45 | shuehner | Assigned To | => adrianromero |
| 2010-05-21 16:45 | shuehner | Note Added: 0027645 | |
| 2010-05-21 16:49 | shuehner | Tag Attached: UUID project | |
| 2010-05-24 14:13 | hgbot | Checkin | |
| 2010-05-24 14:13 | hgbot | Note Added: 0027680 | |
| 2010-05-24 14:13 | hgbot | Status | new => resolved |
| 2010-05-24 14:13 | hgbot | Resolution | open => fixed |
| 2010-05-24 14:13 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/75ebe35a028a6f560d4a98c5f526499f6484fa50 [^] |
| 2010-05-24 14:16 | adrianromero | Note Added: 0027681 | |
| 2010-05-25 07:38 | arunkumar | Note Added: 0027688 | |
| 2010-05-25 07:38 | arunkumar | Status | resolved => closed |
| 2010-05-25 07:42 | sureshbabu | Note Added: 0027689 | |
| 2010-05-25 14:30 | adrianromero | Relationship added | related to 0013432 |
| 2010-05-26 00:00 | anonymous | sf_bug_id | 0 => 3007110 |
| 2010-06-03 22:49 | hudsonbot | Checkin | |
| 2010-06-03 22:49 | hudsonbot | Note Added: 0027921 | |
|
Notes |
|
|
|
|
Found by seeing stacktrace in demo1.openbravo.com environment. |
|
|
|
(0027680)
|
|
hgbot
|
|
2010-05-24 14:13
|
|
Repository: erp/devel/pi
Changeset: 75ebe35a028a6f560d4a98c5f526499f6484fa50
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon May 24 14:12:24 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/75ebe35a028a6f560d4a98c5f526499f6484fa50 [^]
Fixes issue 0013412: SL_Order_DocType fails with non-numeric document type ID (i.e. newly created document types)
This changeset modifies the condition of comparing the strDocType with 0, the Document type for new documents, not converting the value to integer because it will fail for new document types, document types with an UUID as identifier
---
M src/org/openbravo/erpCommon/ad_callouts/SL_Order_DocType.java
---
|
|
|
|
|
* Steps to test
Create a new Document Type for Sales Orders. Just coping the values form another sales order document type.
Create a new Sales order with the recently created document type and process it.
Review the stack trace and verify that the error does not appear.
Other test that has to be done is to review the stacktrace in demo1.openbravo.com environment and review that this error does not appear again.
* Other areas affected
No other areas affected. Only the Sales order window with new document types is involved in this change. |
|
|
|
|
|
|
|
|
|
|
|
|
|