Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0013367
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminorsometimes2010-05-18 15:442010-06-17 00:00
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionfb83ef0f2fbc
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0013367: Allow callout disabilitation on new record

DescriptionWhen a new record is created all combo reloads and callouts associated to drop down lists are executed.

In some cases, this can cause performance issues, and in case that is known that those callouts will not do any change it should be possible to deactivate this behavior.
Proposed Solution-Add a new ValidateOnChange column in ad_column table to be shown for drop down list references.
-Do not execute callouts when a new record is created in case this new property is false.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0027446)
hgbot (developer)
2010-05-18 18:06

Repository: erp/devel/pi
Changeset: fb83ef0f2fbc63851300bffb4b4611c6205c1222
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue May 18 18:04:45 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/fb83ef0f2fbc63851300bffb4b4611c6205c1222 [^]

fixed issue 13367: Allow callout disabilitation on new record

---
M src-db/database/model/tables/AD_COLUMN.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_TABLE.xml
M src-wad/src/org/openbravo/wad/EditionFields_data.xsql
M src-wad/src/org/openbravo/wad/WadUtility.java
M src-wad/src/org/openbravo/wad/controls/WADList.java
---
(0027594)
hudsonbot (developer)
2010-05-20 11:15

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/fb83ef0f2fbc [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/a7901e097e1a [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17407.obx [^]
(0028494)
iperdomo (reporter)
2010-06-16 12:30

When removing a flag in a column with a callout, the difference in the generated code is that the column is removed from the onloadClient function.

Below the diff:

--- /home/iperdomo/tmp/srcAD/org/openbravo/erpWindows/PurchaseOrder/Header_Edition.html 2010-06-16 11:38:13.000000000 +0200
+++ srcAD/org/openbravo/erpWindows/PurchaseOrder/Header_Edition.html 2010-06-16 12:15:19.000000000 +0200
@@ -526,7 +526,6 @@
 if (inputValue(key)==null || inputValue(key)=="") updateOnChange(frm.inpcIncotermsId);
 if (inputValue(key)==null || inputValue(key)=="") updateOnChange(frm.inpadOrgtrxId);
 if (inputValue(key)==null || inputValue(key)=="") updateOnChange(frm.inpdocstatus);
-if (inputValue(key)==null || inputValue(key)=="") updateOnChange(frm.inpcDoctypeId);
   displayLogic();
   readOnlyLogic();
   return true;
diff -ur /home/iperdomo/tmp/srcAD/org/openbravo/erpWindows/PurchaseOrder/Header_NonEditable.html srcAD/org/openbravo/erpWindows/PurchaseOrder/Header_NonEditable.html
--- /home/iperdomo/tmp/srcAD/org/openbravo/erpWindows/PurchaseOrder/Header_NonEditable.html 2010-06-16 11:38:13.000000000 +0200
+++ srcAD/org/openbravo/erpWindows/PurchaseOrder/Header_NonEditable.html 2010-06-16 12:15:20.000000000 +0200
@@ -492,7 +492,6 @@
 if (inputValue(key)==null || inputValue(key)=="") updateOnChange(frm.inpcIncotermsId);
 if (inputValue(key)==null || inputValue(key)=="") updateOnChange(frm.inpadOrgtrxId);
 if (inputValue(key)==null || inputValue(key)=="") updateOnChange(frm.inpdocstatus);
-if (inputValue(key)==null || inputValue(key)=="") updateOnChange(frm.inpcDoctypeId);
   displayLogic();
   readOnlyLogic();
   return true;
(0028495)
iperdomo (reporter)
2010-06-16 12:31

Tested on pi @ rev ced7876366af

- Issue History
Date Modified Username Field Change
2010-05-18 15:44 alostale New Issue
2010-05-18 15:44 alostale Assigned To => alostale
2010-05-18 18:06 hgbot Checkin
2010-05-18 18:06 hgbot Note Added: 0027446
2010-05-18 18:06 hgbot Status new => resolved
2010-05-18 18:06 hgbot Resolution open => fixed
2010-05-18 18:06 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/fb83ef0f2fbc63851300bffb4b4611c6205c1222 [^]
2010-05-20 11:15 hudsonbot Checkin
2010-05-20 11:15 hudsonbot Note Added: 0027594
2010-06-16 12:30 iperdomo Note Added: 0028494
2010-06-16 12:31 iperdomo Note Added: 0028495
2010-06-16 12:31 iperdomo Status resolved => closed
2010-06-17 00:00 anonymous sf_bug_id 0 => 3017326


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker