0013314: Error when posting an invoice with negative line amount

(0027204)
psarobe (viewer)
2010-05-13 15:53

Have you tried with negative quantity instead of negative price?

It makes no sense to enter negative prices

(0027206)
networkb (viewer)
2010-05-13 16:14

Yes, same behavior with negative quantity instead of negative price.

(0028723)
sathiyan (viewer)
2010-06-24 08:31

I have attached screen shots there posting entries are grouped based on negatives and positives. It should be on same account(product revenue) only. If we want entries in different type(negatives as debit), we have to un-select(check off) the flag of allow negative entries(Financial Management || Accounting || Setup || Accounting Schema || Accounting Schema) and need to submit. It is behave as expected.

(0028724)
sathiyan (viewer)
2010-06-24 08:40

Additional notes below:
If business user want entries to be posted on different account altogether, it should be done through different document type only.

For instance, ARI(AR Invoice is subject to posted on 70000 (account id) only always(whether it is positive -credit side or not - debit side). They want to post it on different account id, they have to configure new document type and need to configure account id for that.

(0028746)
dalsasua (viewer)
2010-06-24 15:56

Now it's clear for the developer what the issue consists of.

(0028779)
hgbot (developer)
2010-06-25 14:41

Repository: erp/devel/pi
Changeset: f094e3983471b19291f5868591825f6a31140007
Author: Sathiyan Sivaprakasam <sathiyan.sivaprakasam <at> openbravo.com>
Date: Fri Jun 25 18:10:20 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/f094e3983471b19291f5868591825f6a31140007 [^]

Fixes Issue 13314: Error when posting an invoice with negative line amount/quantity.

---
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal_data.xsql
---

(0028911)
hudsonbot (viewer)
2010-06-30 12:17

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/f094e3983471 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/0670375d782d [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17726.obx [^]

(0029364)
sureshbabu (viewer)
2010-07-16 13:49

Verified, right now system behaves when we post an invoice with below line amt

line 1: 100 euros
line 2: -30 euros

When we post the invoice, 70 euros will be posted in
Dr customer account 70 euros
Cr Product account 70 euros

(0030480)
dalsasua (viewer)
2010-08-30 18:42

Fix to 0014234 restores previous behavior of the report. If user wants this grouping to happen, must un-flag the "Allow negatives" check.

Issue History
Date Modified	Username	Field	Change
2010-05-13 12:38	networkb	New Issue
2010-05-13 12:38	networkb	Assigned To	=> dalsasua
2010-05-13 12:38	networkb	OBNetwork customer	=> Yes
2010-05-13 15:53	psarobe	Note Added: 0027204
2010-05-13 15:53	psarobe	Status	new => feedback
2010-05-13 16:14	networkb	Note Added: 0027206
2010-05-13 16:14	networkb	Status	feedback => new
2010-05-13 16:22	adrianromero	Status	new => scheduled
2010-05-13 16:22	adrianromero	fix_in_branch	=> pi
2010-05-18 19:16	networkb	Target Version	2.50MP19 => 2.50MP20
2010-05-18 19:16	networkb	fix_in_branch	pi =>
2010-06-24 07:59	sathiyan	Assigned To	dalsasua => sathiyan
2010-06-24 08:31	sathiyan	Note Added: 0028723
2010-06-24 08:33	sathiyan	File Added: screen1_negatives_In_different_group.png
2010-06-24 08:33	sathiyan	File Added: screen2_lines_grid.png
2010-06-24 08:34	sathiyan	File Added: screen3_allow_negative_entries_off.png
2010-06-24 08:40	sathiyan	Note Added: 0028724
2010-06-24 08:41	sathiyan	Status	scheduled => feedback
2010-06-24 14:01	sathiyan	Status	feedback => scheduled
2010-06-24 14:01	sathiyan	fix_in_branch	=> pi
2010-06-24 15:56	dalsasua	Note Added: 0028746
2010-06-25 14:41	hgbot	Checkin
2010-06-25 14:41	hgbot	Note Added: 0028779
2010-06-25 14:41	hgbot	Status	scheduled => resolved
2010-06-25 14:41	hgbot	Resolution	open => fixed
2010-06-25 14:41	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/f094e3983471b19291f5868591825f6a31140007 [^]
2010-06-30 12:17	hudsonbot	Checkin
2010-06-30 12:17	hudsonbot	Note Added: 0028911
2010-07-16 13:49	sureshbabu	Note Added: 0029364
2010-07-16 13:49	sureshbabu	Status	resolved => closed
2010-07-17 00:00	anonymous	sf_bug_id	0 => 3030766
2010-08-25 10:27	dalsasua	Relationship added	related to 0014234
2010-08-30 18:42	dalsasua	Note Added: 0030480

Notes
(0027204) psarobe (viewer) 2010-05-13 15:53	Have you tried with negative quantity instead of negative price? It makes no sense to enter negative prices

(0027206) networkb (viewer) 2010-05-13 16:14	Yes, same behavior with negative quantity instead of negative price.

(0028723) sathiyan (viewer) 2010-06-24 08:31	I have attached screen shots there posting entries are grouped based on negatives and positives. It should be on same account(product revenue) only. If we want entries in different type(negatives as debit), we have to un-select(check off) the flag of allow negative entries(Financial Management \|\| Accounting \|\| Setup \|\| Accounting Schema \|\| Accounting Schema) and need to submit. It is behave as expected.

(0028724) sathiyan (viewer) 2010-06-24 08:40	Additional notes below: If business user want entries to be posted on different account altogether, it should be done through different document type only. For instance, ARI(AR Invoice is subject to posted on 70000 (account id) only always(whether it is positive -credit side or not - debit side). They want to post it on different account id, they have to configure new document type and need to configure account id for that.

(0028746) dalsasua (viewer) 2010-06-24 15:56	Now it's clear for the developer what the issue consists of.

(0028779) hgbot (developer) 2010-06-25 14:41	Repository: erp/devel/pi Changeset: f094e3983471b19291f5868591825f6a31140007 Author: Sathiyan Sivaprakasam <sathiyan.sivaprakasam <at> openbravo.com> Date: Fri Jun 25 18:10:20 2010 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/f094e3983471b19291f5868591825f6a31140007 [^] Fixes Issue 13314: Error when posting an invoice with negative line amount/quantity. --- M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal_data.xsql ---

(0028911) hudsonbot (viewer) 2010-06-30 12:17	A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/f094e3983471 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/0670375d782d [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17726.obx [^]

(0029364) sureshbabu (viewer) 2010-07-16 13:49	Verified, right now system behaves when we post an invoice with below line amt line 1: 100 euros line 2: -30 euros When we post the invoice, 70 euros will be posted in Dr customer account 70 euros Cr Product account 70 euros

(0030480) dalsasua (viewer) 2010-08-30 18:42	Fix to 0014234 restores previous behavior of the report. If user wants this grouping to happen, must un-flag the "Allow negatives" check.