Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0013163
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajoralways2010-04-30 09:452010-05-18 21:43
ReporterpsarobeView Statuspublic 
Assigned Todalsasua 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionb9e8574569f7
ProjectionnoneETAnoneTarget Version2.50MP17
OSAnyDatabaseOracleJava version
OS VersionDatabase versionAnt version
Product Version2.50MP13SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0013163: Cannot complete a sales/purchase invoice under some circumstances

DescriptionUnder some circumstances an invoice cannot be completed. This happens when:
1. The business partner has discounts configured
2. The result of the discount (amount) has more than 2 decimals
3. Only happens in Oracle database

The reason is:
1. Trigger C_INVOICELINE_TRG4 is executed before C_INVLINE_CHK_RESTRICTIONS_TRG so the amount is not rounded based on the precision.
2. There is another issue that needs to be fixed. How can the error is coded like "RAISE_APPLICATION_ERROR(-20501,'Line Amount Is Not Correct');". That's a big mistake. That number has nothing to do with the real error so it misleads the end user and developers when trying to figure out what was wrong
Steps To Reproduce1. Login in PI or Main
2. Openbravo/openbravo
3. Go to Sales management-> Transactions->Sales invoice
4. Click new and select Sailor as bpartner
5. Move to lines and select hammer
6. Qty=1
7. Go back to the header and complete

Expected result: Process complete successfully

Current result and error: Document already posted/processed
Proposed SolutionTrigger C_INVOICELINE_TRG4 should be merged with C_INVLINE_CHK_RESTRICTIONS_TRG and do the check once the amount (line net amount) is rounded
TagsRegression
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0026809)
hgbot (developer)
2010-04-30 12:28

Repository: erp/devel/pi
Changeset: b9e8574569f75fb2a408ff09233f02050e356bae
Author: David Alsasua <david.alsasua <at> openbravo.com>
Date: Fri Apr 30 12:27:53 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b9e8574569f75fb2a408ff09233f02050e356bae [^]

Fixes issue 13163: Cannot complete a sales/purchase invoice

---
M src-db/database/model/triggers/C_INVLINE_CHK_RESTRICTIONS_TRG.xml
R src-db/database/model/triggers/C_INVOICELINE_TRG4.xml
---
(0026873)
sureshbabu (reporter)
2010-05-03 16:08

Tested with 3 decimal places for euro relation, euro edition, price relation, price edition in format.xml file.
working fine, able to complete sales & purchase invoice
(0026918)
psarobe (manager)
2010-05-04 15:56

Regression introduced by 12366
(0027459)
hudsonbot (developer)
2010-05-18 21:43

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/b9e8574569f7 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/aa11838d5f80 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17380.obx [^]

- Issue History
Date Modified Username Field Change
2010-04-30 09:45 psarobe New Issue
2010-04-30 09:45 psarobe Assigned To => dalsasua
2010-04-30 09:46 psarobe Tag Attached: Regression
2010-04-30 09:46 psarobe Status new => scheduled
2010-04-30 09:46 psarobe fix_in_branch => pi
2010-04-30 12:28 hgbot Checkin
2010-04-30 12:28 hgbot Note Added: 0026809
2010-04-30 12:28 hgbot Status scheduled => resolved
2010-04-30 12:28 hgbot Resolution open => fixed
2010-04-30 12:28 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b9e8574569f75fb2a408ff09233f02050e356bae [^]
2010-05-03 16:08 sureshbabu Note Added: 0026873
2010-05-03 16:08 sureshbabu Status resolved => closed
2010-05-04 00:00 anonymous sf_bug_id 0 => 2996197
2010-05-04 15:55 psarobe version 2.50MP14 => 2.50MP13
2010-05-04 15:55 psarobe fix_in_branch pi =>
2010-05-04 15:56 psarobe Note Added: 0026918
2010-05-18 12:12 gorka_gil Target Version 2.50MP15 => 2.50MP17
2010-05-18 21:43 hudsonbot Checkin
2010-05-18 21:43 hudsonbot Note Added: 0027459


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker