Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0013042 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | have not tried | 2010-04-19 17:05 | 2010-05-28 00:00 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | gorkaion | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 2.50MP15 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 05c4b6abd4d3 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0013042: Utility.getPropertyValue raises expected exception as IllegalStateException (sublcass of RuntimeException) | |||||||
| Description | The new Utility.getPropertyValue function can be used to read a value for the new property configuration project. It calls the underlying pl-function AD_GET_PROPERTY_VALUE. This pl-function raises an exception in case of conflicting property values. However the java-function does not explicitly handle/throw any exception but passes the sql-exception wrapped in a IllegalStateException (sublcass of RuntimeException). Those do not need to thrown explicitely. This means users of the utility-function do not even know that property-value conflicts to exists and do not handle them. In that case the error will be raised and passed through the callers in an unpredictable way. | |||||||
| Steps To Reproduce | Get a data-conflict in for a property: - add two 'Property configuration' entries for the same property, without marking any of them as selected. Call the Utility.getPropertyValue function and check how the exception is raised. | |||||||
| Proposed Solution | Check if the exception should not be handled in a different way. If yes, change the method signature in MP15 to not force an API-change for it later. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0026350) hgbot (developer) 2010-04-19 19:07 |
Repository: erp/devel/pi Changeset: 05c4b6abd4d38e4dc4e853626933e7ac25721579 Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com> Date: Mon Apr 19 19:21:26 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/05c4b6abd4d38e4dc4e853626933e7ac25721579 [^] Fixed issue 13042.Fixed exception management of the method. --- M src/org/openbravo/erpCommon/ad_actionButton/InvoicePaymentMonitor.java M src/org/openbravo/erpCommon/ad_process/PaymentMonitor.java M src/org/openbravo/erpCommon/ad_process/PaymentMonitorProcess.java M src/org/openbravo/erpCommon/utility/Utility.java A src/org/openbravo/erpCommon/utility/PropertyException.java --- |
|
(0026525) hudsonbot (developer) 2010-04-21 10:43 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/05c4b6abd4d3 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/6aaf8711c872 [^] Tests: http://builds.openbravo.com/view/devel-int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17101.obx [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-04-19 17:05 | shuehner | New Issue | |
| 2010-04-19 17:05 | shuehner | Assigned To | => alostale |
| 2010-04-19 17:50 | alostale | Assigned To | alostale => gorkaion |
| 2010-04-19 18:28 | shuehner | Priority | urgent => immediate |
| 2010-04-19 18:28 | shuehner | Status | new => scheduled |
| 2010-04-19 18:28 | shuehner | Fixed in Version | => 2.50MP15 |
| 2010-04-19 19:07 | hgbot | Checkin | |
| 2010-04-19 19:07 | hgbot | Note Added: 0026350 | |
| 2010-04-19 19:07 | hgbot | Status | scheduled => resolved |
| 2010-04-19 19:07 | hgbot | Resolution | open => fixed |
| 2010-04-19 19:07 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/05c4b6abd4d38e4dc4e853626933e7ac25721579 [^] |
| 2010-04-20 10:23 | shuehner | Relationship added | related to 0013048 |
| 2010-04-21 10:43 | hudsonbot | Checkin | |
| 2010-04-21 10:43 | hudsonbot | Note Added: 0026525 | |
| 2010-05-27 11:18 | gorkaion | Status | resolved => closed |
| 2010-05-28 00:00 | anonymous | sf_bug_id | 0 => 3008200 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |