Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0013031
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajoralways2010-04-19 12:552010-05-18 21:43
ReporternetworkbView Statuspublic 
Assigned Tosivaraman 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revision8d31064fd72c
ProjectionnoneETAnoneTarget Version2.40MP13
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.40MP12SCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0013031: The shipment and invoice created after complete a POS Order have wrong data in the createdby and updatedby fields

DescriptionThe shipment and invoice created after complete a POS Order have wrong data in the createdby and updatedby fields
Steps To Reproduce-Login as Openbravo admin
-Enable on the session preferences the option to see the audit
-Create a sales order selecting the document type POS Order
-Add a line
-Complete the order.
-See that the new shipment and invoice created automatically
have the updatedby and createdby feles filled with "System Admin"
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00130232.40MP13 closedharikrishnan When completing or processing documents the updatedby column is not updated properly 
depends on backport 00130532.40MP13 closedsivaraman The shipment and invoice created after complete a POS Order have wrong data in the createdby and updatedby fields 
related to defect 00130332.40MP13 closedadrianromero The create shipment from order process does not fill well the audit fields. 

-  Notes
(0026342)
networkb (viewer)
2010-04-19 13:18

 it happens also in 2.50
(0026935)
hgbot (developer)
2010-05-04 17:54

 Repository: erp/stable/2.40
Changeset: 66ae42fbee99404bf43db5b22a0ded8f610fce73
Author: Sivaraman Rajagopal <sivaraman.rajagopal <at> openbravo>
Date: Tue May 04 21:22:53 2010 +0530
URL: http://code.openbravo.com/erp/stable/2.40/rev/66ae42fbee99404bf43db5b22a0ded8f610fce73 [^]

Fixes issue 13031: The shipment and invoice created after complete a POS Order have wrong data in the createdby and updatedby fields

---
M src-db/database/model/functions/C_INVOICE_CREATE.xml
M src-db/database/model/functions/C_ORDER_POST1.xml
---
(0026938)
hgbot (developer)
2010-05-04 18:03

 Repository: erp/devel/pi
Changeset: 8d31064fd72c402ed356d772ab12d82fcaa7d86a
Author: Sivaraman Rajagopal <sivaraman.rajagopal <at> openbravo.com>
Date: Tue May 04 21:32:01 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/8d31064fd72c402ed356d772ab12d82fcaa7d86a [^]

Fixes issue 13031: The shipment and invoice created after complete a POS Order have wrong data in the createdby and updatedby fields

---
M src-db/database/model/functions/C_INVOICE_CREATE.xml
---
(0026940)
sivaraman (viewer)
2010-05-04 18:28

 Steps to test:
1. Log on to Openbravo
2. Change user role to Openbravo Admin
3. Go to General Setup || Application || Session Preferences || Session Preferences
4. Enable Show audit and Save
5. Go to Sales Management || Transactions || Sales Order || Header
6. Create new sales order selecting the document type POS Order
7. Add a line with any product
8. Save and complete the order by clicking 'Complete' button

Root cause:
While completing the sales order, 'p_PInstance_ID' is validated in C_INVOICE_CREATE procedure. As sales order completion is not processed through 'p_PInstance_ID', it gets NULL value and therefore default user ID (0) is assigned while creating sales invoice. User ID of AD_PINSTANCE will be assigned only if 'p_PInstance_ID' is not null. To avoid setting default value for always, we have added a SELECT clause to fetch proper user ID value from C_ORDER table. In 2.40 version, additionally we have modified C_ORDER_POST1.xml in order to update 'UPDATEDBY' column.

Impact:
It has been verified that the fix resolves the issue without any other impact.
(0026977)
arunkumar (viewer)
2010-05-06 11:10

 Tested working fine
(0027480)
hudsonbot (viewer)
2010-05-18 21:43

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/8d31064fd72c [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/aa11838d5f80 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17380.obx [^]

- Issue History
Date Modified Username Field Change
2010-04-19 12:55 networkb New Issue
2010-04-19 12:55 networkb Assigned To => adrianromero
2010-04-19 12:55 networkb OBNetwork customer => Yes
2010-04-19 12:55 networkb Relationship added related to 0013024
2010-04-19 12:57 networkb Relationship added related to 0013033
2010-04-19 13:11 networkb version => 2.40MP12
2010-04-19 13:11 networkb Target Version => 2.40MP13
2010-04-19 13:18 networkb Note Added: 0026342
2010-04-20 09:57 adrianromero Relationship deleted related to 0013024
2010-04-20 09:57 adrianromero Relationship added related to 0013023
2010-04-20 12:56 adrianromero Sticky Issue No => Yes
2010-04-20 12:57 adrianromero Sticky Issue Yes => No
2010-04-20 12:57 adrianromero Status new => scheduled
2010-04-20 12:57 adrianromero fix_in_branch => pi
2010-04-20 12:57 adrianromero Issue cloned 0013053
2010-04-20 12:57 adrianromero Relationship added depends on 0013053
2010-05-04 17:51 sivaraman Assigned To adrianromero => sivaraman
2010-05-04 17:54 hgbot Checkin
2010-05-04 17:54 hgbot Note Added: 0026935
2010-05-04 17:54 hgbot Status scheduled => resolved
2010-05-04 17:54 hgbot Resolution open => fixed
2010-05-04 17:54 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/stable/2.40/rev/66ae42fbee99404bf43db5b22a0ded8f610fce73 [^]
2010-05-04 18:03 hgbot Checkin
2010-05-04 18:03 hgbot Note Added: 0026938
2010-05-04 18:03 hgbot Fixed in SCM revision http://code.openbravo.com/erp/stable/2.40/rev/66ae42fbee99404bf43db5b22a0ded8f610fce73 [^] => http://code.openbravo.com/erp/devel/pi/rev/8d31064fd72c402ed356d772ab12d82fcaa7d86a [^]
2010-05-04 18:28 sivaraman Note Added: 0026940
2010-05-06 11:10 arunkumar Note Added: 0026977
2010-05-06 11:10 arunkumar Status resolved => closed
2010-05-07 00:00 anonymous sf_bug_id 0 => 2997915
2010-05-18 21:43 hudsonbot Checkin
2010-05-18 21:43 hudsonbot Note Added: 0027480

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker