Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0012903

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] A. Platform

minor

have not tried

2010-04-07 17:28

2010-04-19 21:12

Reporter

shuehner

View Status

public

Assigned To

mtaal

Priority

normal

Resolution

fixed

Fixed in Version

2.50MP15

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

pi

SCM revision

Review Assigned To

Web browser

Modules

Core

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0012903: Error in OBQuery when using with hql clause having order by but not where part

Description

Using the following code snippet fails to execute:

products = OBDal.getInstance().createQuery(Product.class, " as e order by name");
products.setFilterOnReadableOrganization(false);
products.setFilterOnReadableClients(false);
assertTrue(products.count() > 0);

java.lang.StringIndexOutOfBoundsException: String index out of range: -1
    at java.lang.String.substring(String.java:1949)
    at org.openbravo.dal.service.OBQuery.createQueryString(OBQuery.java:215)
    at org.openbravo.dal.service.OBQuery.count(OBQuery.java:140)

Steps To Reproduce

Use attached junit testcases

Tags

No tags attached.

testcases_for_12903.diff [^] (1,742 bytes) 2010-04-07 17:31 [Show Content] [Hide Content]

diff -r 6ba00074e974 src-test/org/openbravo/test/dal/IssuesTest.java
--- a/src-test/org/openbravo/test/dal/IssuesTest.java	Wed Apr 07 18:06:23 2010 +0530
+++ b/src-test/org/openbravo/test/dal/IssuesTest.java	Wed Apr 07 17:42:44 2010 +0200
@@ -292,4 +298,40 @@
     products.setFilterOnReadableClients(false);
     assertTrue(products.count() > 0);
   }
+
+  /**
+   * Tests issue: https://issues.openbravo.com/view.php?id=12903
+   */
+  public void test12903() {
+    setSystemAdministratorContext();
+    OBQuery<Product> products;
+
+    products = OBDal.getInstance().createQuery(Product.class,
+        " as e where e.name is not null order by name");
+    products.setFilterOnReadableOrganization(false);
+    products.setFilterOnReadableClients(false);
+    assertTrue(products.count() > 0);
+
+    products = OBDal.getInstance().createQuery(Product.class, " as e order by name");
+    products.setFilterOnReadableOrganization(false);
+    products.setFilterOnReadableClients(false);
+    assertTrue(products.count() > 0);
+
+    products = OBDal.getInstance().createQuery(Product.class, "order by name");
+    products.setFilterOnReadableOrganization(false);
+    products.setFilterOnReadableClients(false);
+    assertTrue(products.count() > 0);
+
+    products = OBDal.getInstance().createQuery(Product.class, " where name is not null");
+    products.setFilterOnReadableOrganization(false);
+    products.setFilterOnReadableClients(false);
+    assertTrue(products.count() > 0);
+
+    products = OBDal.getInstance().createQuery(Product.class, "");
+    products.setFilterOnReadableOrganization(false);
+    products.setFilterOnReadableClients(false);
+    assertTrue(products.count() > 0);
+
+  }
+
 }
\ No newline at end of file

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

pi

closed

OBQuery count not working with a query with aliases

Notes
(0025952) shuehner (administrator) 2010-04-07 17:32	Note: testcases just excercise various hql queries combinations of alias,where,order by. The testcases perhaps need to be extended with specific ones depending on the fix done for this issue.

(0025953) shuehner (administrator) 2010-04-07 17:32	Adding related as issue was found reviewing 12853.

(0025968) hgbot (developer) 2010-04-08 09:36	Repository: erp/devel/pi Changeset: c56bf39535655e046da329134721985ec44bc916 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Thu Apr 08 09:47:48 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/c56bf39535655e046da329134721985ec44bc916 [^] fixes issue 12903: Error in OBQuery when using with hql clause having order by but not where part --- M src-test/org/openbravo/test/dal/IssuesTest.java M src/org/openbravo/dal/service/OBQuery.java ---

(0026217) marvintm (developer) 2010-04-14 19:05	The code looks fine and the tests run correctly

(0026435) hudsonbot (developer) 2010-04-19 21:12	A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/c56bf3953565 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^] Tests: http://builds.openbravo.com/view/devel-int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^]

Issue History
Date Modified	Username	Field	Change
2010-04-07 17:28	shuehner	New Issue
2010-04-07 17:28	shuehner	Assigned To	=> mtaal
2010-04-07 17:31	shuehner	File Added: testcases_for_12903.diff
2010-04-07 17:32	shuehner	Note Added: 0025952
2010-04-07 17:32	shuehner	Relationship added	related to 0012853
2010-04-07 17:32	shuehner	Note Added: 0025953
2010-04-08 09:36	hgbot	Checkin
2010-04-08 09:36	hgbot	Note Added: 0025968
2010-04-08 09:36	hgbot	Status	new => resolved
2010-04-08 09:36	hgbot	Resolution	open => fixed
2010-04-08 09:36	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/c56bf39535655e046da329134721985ec44bc916 [^]
2010-04-14 19:05	marvintm	Note Added: 0026217
2010-04-14 19:05	marvintm	Status	resolved => closed
2010-04-14 19:05	marvintm	Fixed in Version	=> 2.50MP15
2010-04-15 00:00	anonymous	sf_bug_id	0 => 2987423
2010-04-19 21:12	hudsonbot	Checkin
2010-04-19 21:12	hudsonbot	Note Added: 0026435

Copyright © 2000 - 2009 MantisBT Group