Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0012824 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] Z. Others | critical | have not tried | 2010-03-26 15:08 | 2010-04-19 21:13 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | dalsasua | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 6c78ad9d5176 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0012824: api check build 327 fails - part2 | |||||||
| Description | This api check build fails: http://builds.openbravo.com/job/erp_devel_pi-module-integrity-test/326/console [^] [checkAPI] 25977 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++ [checkAPI] 25985 ERROR - Errors in API model validation [checkAPI] 25989 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++ [checkAPI] 25996 ERROR - Unique constraint modified, column removed: table: C_BP_VENDOR_ACCT - Unique constraint: C_BP_VENDOR_ACCT_ACCTSCHEMA_UN - removed column AD_ORG_ID | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0025752) shuehner (administrator) 2010-03-26 15:09 |
The removal of a column from the unique-constraint makes it more strict, which could make it fail for existing data. |
|
(0025894) balamurugan (reporter) 2010-04-06 13:54 |
This api change is related to the fixing of the issue 12589. In 12589, the constraint C_BP_VENDOR_ACCT_ACCTSCHEMA_UN in the table C_BP_VENDOR_ACCT includes the following columns C_ACCTSCHEMA_ID, C_BPARTNER_ID, STATUS and AD_ORG_ID. so, the system allows to create two vendor accounting lines using same account schema with different organization. So, the AD_ORG_ID is removed from the constraint not allow to create such that. In order to fix this api break, i need a confirmation whether this api change is valid or not. |
|
(0025899) balamurugan (reporter) 2010-04-06 14:40 |
This api change is related to the fixing of the issue 12589. In 12589, the constraint C_BP_VENDOR_ACCT_ACCTSCHEMA_UN in the table C_BP_VENDOR_ACCT includes the following columns C_ACCTSCHEMA_ID, C_BPARTNER_ID, STATUS and AD_ORG_ID. so, the system allows to create two vendor accounting lines using same account schema with different organization. So, the AD_ORG_ID is removed from the constraint not allow to create such that. In order to fix this api break, i need a confirmation whether this api change is valid or not. |
|
(0025901) shuehner (administrator) 2010-04-06 14:52 |
@paolo: The problem with that issue is that there might be local data, which is not fine with the new changed/stricter constraint. Using the new BuildValidation project (will be included in MP15, see [1]) we can add a check if the data is fine, and if not stop the upgrade with a error message explaining what/why and what needs to be checked/changed in the local system. If we add this validation, then it should be fine to accept this changed constraint. [1] http://wiki.openbravo.com/wiki/Projects/ValidationsAndPrescripts [^] |
|
(0025915) pjuvara (reporter) 2010-04-06 21:15 |
The proposed constraint change is certainly correct functionally (it mirrors the customer account constraints) but I understand shuehner's concern on update for existing customers. Can we postpone the fix for issue 12589 till after MP15 so that we can add a validation script prompting users to clean up the data before applying the update? |
|
(0025930) marvintm (developer) 2010-04-07 12:37 |
Hi As Stefan mentioned, the Build Validations will be included in MP15 (the project was already merged to pi), so there is no problem afaics in including both the API change and the validation now, as everything should be fine (in the validation we can include a specific message telling the users what they should do). |
|
(0025950) pjuvara (reporter) 2010-04-07 16:42 |
I am OK with marvintm suggestion. |
|
(0026042) hgbot (developer) 2010-04-09 18:38 |
Repository: erp/devel/pi Changeset: 5c592e20669af9595f420264548768f1bc6e7248 Author: David Alsasua <david.alsasua <at> openbravo.com> Date: Fri Apr 09 18:50:30 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/5c592e20669af9595f420264548768f1bc6e7248 [^] Fixes issue 12824: api check build 327 --- M src-db/database/sourcedata/AD_MESSAGE.xml A src-util/buildvalidation/src/org/openbravo/buildvalidation/Cbpvendoracct.java A src-util/buildvalidation/src/org/openbravo/buildvalidation/Cbpvendoracct_data.xsql --- |
|
(0026043) hgbot (developer) 2010-04-09 18:51 |
Repository: erp/devel/api-checks Changeset: 63452bd73c719b5e2889e962b8f4d13e958033a5 Author: David Alsasua <david.alsasua <at> openbravo.com> Date: Fri Apr 09 19:03:41 2010 +0200 URL: http://code.openbravo.com/erp/devel/api-checks/rev/63452bd73c719b5e2889e962b8f4d13e958033a5 [^] Fixes issue 12824: api check build 327 --- M model/model/tables/C_BP_VENDOR_ACCT.xml --- |
|
(0026044) hgbot (developer) 2010-04-09 19:05 |
Repository: erp/devel/pi Changeset: 6c78ad9d51765ab3f499895fae814e7bf27da3af Author: David Alsasua <david.alsasua <at> openbravo.com> Date: Fri Apr 09 19:17:41 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/6c78ad9d51765ab3f499895fae814e7bf27da3af [^] Fixes issue 12824: api check build 327 --- A src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/Cbpvendoracct.class A src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/CbpvendoracctData.class --- |
|
(0026045) shuehner (administrator) 2010-04-09 20:27 |
api-check build now fine -> closing |
|
(0026446) hudsonbot (developer) 2010-04-19 21:13 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/5c592e20669a [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^] Tests: http://builds.openbravo.com/view/devel-int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^] |
|
(0026447) hudsonbot (developer) 2010-04-19 21:13 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/6c78ad9d5176 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^] Tests: http://builds.openbravo.com/view/devel-int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-03-26 15:08 | shuehner | New Issue | |
| 2010-03-26 15:08 | shuehner | Assigned To | => balamurugan |
| 2010-03-26 15:09 | shuehner | Relationship added | related to 0012589 |
| 2010-03-26 15:09 | shuehner | Note Added: 0025752 | |
| 2010-03-26 15:14 | jpabloae | Issue Monitored: jpabloae | |
| 2010-04-06 13:54 | balamurugan | Note Added: 0025894 | |
| 2010-04-06 13:54 | balamurugan | Assigned To | balamurugan => pjuvara |
| 2010-04-06 14:40 | balamurugan | Note Added: 0025899 | |
| 2010-04-06 14:40 | balamurugan | Status | new => feedback |
| 2010-04-06 14:52 | shuehner | Note Added: 0025901 | |
| 2010-04-06 21:15 | pjuvara | Note Added: 0025915 | |
| 2010-04-06 21:15 | pjuvara | Assigned To | pjuvara => balamurugan |
| 2010-04-06 21:15 | pjuvara | Status | feedback => new |
| 2010-04-07 12:37 | marvintm | Note Added: 0025930 | |
| 2010-04-07 16:42 | pjuvara | Note Added: 0025950 | |
| 2010-04-09 18:38 | hgbot | Checkin | |
| 2010-04-09 18:38 | hgbot | Note Added: 0026042 | |
| 2010-04-09 18:38 | hgbot | Status | new => resolved |
| 2010-04-09 18:38 | hgbot | Resolution | open => fixed |
| 2010-04-09 18:38 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/5c592e20669af9595f420264548768f1bc6e7248 [^] |
| 2010-04-09 18:48 | shuehner | Assigned To | balamurugan => dalsasua |
| 2010-04-09 18:48 | shuehner | Status | resolved => new |
| 2010-04-09 18:48 | shuehner | Resolution | fixed => open |
| 2010-04-09 18:51 | hgbot | Checkin | |
| 2010-04-09 18:51 | hgbot | Note Added: 0026043 | |
| 2010-04-09 18:51 | hgbot | Status | new => resolved |
| 2010-04-09 18:51 | hgbot | Resolution | open => fixed |
| 2010-04-09 18:51 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/5c592e20669af9595f420264548768f1bc6e7248 [^] => http://code.openbravo.com/erp/devel/api-checks/rev/63452bd73c719b5e2889e962b8f4d13e958033a5 [^] |
| 2010-04-09 19:05 | hgbot | Checkin | |
| 2010-04-09 19:05 | hgbot | Note Added: 0026044 | |
| 2010-04-09 19:05 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/api-checks/rev/63452bd73c719b5e2889e962b8f4d13e958033a5 [^] => http://code.openbravo.com/erp/devel/pi/rev/6c78ad9d51765ab3f499895fae814e7bf27da3af [^] |
| 2010-04-09 20:27 | shuehner | Note Added: 0026045 | |
| 2010-04-09 20:27 | shuehner | Status | resolved => closed |
| 2010-04-10 00:00 | anonymous | sf_bug_id | 0 => 2984777 |
| 2010-04-19 21:13 | hudsonbot | Checkin | |
| 2010-04-19 21:13 | hudsonbot | Note Added: 0026446 | |
| 2010-04-19 21:13 | hudsonbot | Checkin | |
| 2010-04-19 21:13 | hudsonbot | Note Added: 0026447 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |