Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0012704 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 07. Sales management | minor | always | 2010-03-17 09:45 | 2010-07-13 22:11 | |||
| Reporter | networkb | View Status | public | |||||
| Assigned To | adrianromero | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | fd08978a94e6 | ||||
| Projection | none | ETA | none | Target Version | 2.50MP20 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | 2.50MP19 | SCM revision | ||||||
| Merge Request Status | ||||||||
| Review Assigned To | ||||||||
| OBNetwork customer | OBPS | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0012704: Error when a Price Adjustment is applied | |||||||
| Description | On Sales Order, if a Price Adjustment is applied, the application does not calculate properly the Standard Price. -Modify the Format.xml and the Standard Precision. The number's format must be 0.0000 | |||||||
| Steps To Reproduce | -Modify the Format.xml and the Standard Precision. * <Number name="euroRelation" decimal="." grouping="," formatOutput="#,##0.0000" formatInternal="#0.00" /> <Number name="euroEdition" decimal="." grouping="," formatOutput="#0.0000" formatInternal="#0.00" /> * <Number name="priceRelation" decimal="." grouping="," formatOutput="#,##0.0000" formatInternal="#0.00" /> <Number name="priceEdition" decimal="." grouping="," formatOutput="#0.0000" formatInternal="#0.00" /> The number's format must be 0.0000 -As Openbravo Admin go to Master Data Management || Product (Hammer)|| Product >> Price - Select Price List Version: Sales 2006 - List Price: 1.4200 - Standard Price: 1.4200 - Price Limit: 5.5000 -Save and go to Master Data Management || Pricing || Price Adjustments -Create a new record: - Starting Date: 01-01-2010 - Discount %: 47.80 - Included Business Partners: All selected -Go to Bisiness Partner and select Obelix Quarry SA. -Save and go to Sales Management || Transactions || Sales Order -Create a new record, select Obelix and go to Lines. -Select hammer. -Realize that the Standard Price is 1.4199 | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0025563) rafaroda (viewer) 2010-03-17 09:49 |
Have a look at this line when debugging https://code.openbravo.com/erp/devel/pi/file/tip/src/org/openbravo/erpCommon/ad_callouts/SL_Order_Amt.java#l152 [^] |
|
(0026966) adrianromero (viewer) 2010-05-05 18:36 |
Cannot reproduce in pi. Kindly test this issue in pi and verify it. |
|
(0026980) adrianromero (viewer) 2010-05-06 11:53 |
This issue cannot be reproduced in pi but it was reproduced in MP13. |
|
(0028973) networkb (viewer) 2010-07-02 10:29 |
It is reproduced in MP19 and MP18. |
|
(0029067) hgbot (developer) 2010-07-05 18:29 |
Repository: erp/devel/pi Changeset: fd08978a94e6654e2014a646c210281c8af160c1 Author: Adrián Romero <adrianromero <at> openbravo.com> Date: Mon Jul 05 18:28:07 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/fd08978a94e6654e2014a646c210281c8af160c1 [^] Fixes issue 0012704: Error when a Price Adjustment is applied It has been modified the callout that calculates the price to not to modify the priceStd when calculating discounts if it is not necesary. This is done in order to avoid differences due rounding --- M src/org/openbravo/erpCommon/ad_callouts/SL_Order_Amt.java --- |
|
(0029068) adrianromero (viewer) 2010-07-05 18:35 |
* Testing of the issue Just follow the Steps to Reproduce section and notice that now the Standard Price is 1.4200 as expected. * Other areas affected by the change It only has been modified the callout function that calculates order prices.No other areas are affected. Take into account that this issue is because of price calculation cannot be reversed because of rounding. Then the solution implemented is just not to modify the Net Standard Price if it is not required but if for example the Net Unit Price is manually changed to 0,7412, the Net Standard Price will be changed to 1.4199 that is the correct result of removing the discount to the 0.7412 price. |
|
(0029111) hudsonbot (viewer) 2010-07-07 12:38 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/fd08978a94e6 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/d555a35070ee [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17817.obx [^] |
|
(0029274) sureshbabu (viewer) 2010-07-13 22:11 |
verified |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-03-17 09:45 | networkb | New Issue | |
| 2010-03-17 09:45 | networkb | Assigned To | => adrianromero |
| 2010-03-17 09:45 | networkb | OBNetwork customer | => Yes |
| 2010-03-17 09:47 | rafaroda | Issue Monitored: rafaroda | |
| 2010-03-17 09:49 | rafaroda | Note Added: 0025563 | |
| 2010-03-17 17:41 | adrianromero | Status | new => scheduled |
| 2010-03-17 17:41 | adrianromero | fix_in_branch | => pi |
| 2010-05-05 18:36 | adrianromero | Note Added: 0026966 | |
| 2010-05-05 18:36 | adrianromero | Status | scheduled => feedback |
| 2010-05-06 11:53 | adrianromero | Note Added: 0026980 | |
| 2010-05-06 11:53 | adrianromero | Status | feedback => closed |
| 2010-05-06 11:53 | adrianromero | Resolution | open => unable to reproduce |
| 2010-05-07 00:00 | anonymous | sf_bug_id | 0 => 2997914 |
| 2010-05-11 18:19 | jpabloae | Target Version | 2.50MP16 => 2.50MP17 |
| 2010-07-02 10:29 | networkb | Note Added: 0028973 | |
| 2010-07-02 10:29 | networkb | Status | closed => new |
| 2010-07-02 10:29 | networkb | Resolution | unable to reproduce => open |
| 2010-07-02 10:30 | networkb | fix_in_branch | pi => |
| 2010-07-02 10:30 | networkb | Steps to Reproduce Updated | View Revisions |
| 2010-07-02 10:31 | networkb | version | 2.50MP13 => 2.50MP19 |
| 2010-07-02 10:31 | networkb | Target Version | 2.50MP17 => 2.50MP20 |
| 2010-07-05 13:08 | adrianromero | Priority | high => immediate |
| 2010-07-05 13:08 | adrianromero | Status | new => scheduled |
| 2010-07-05 18:29 | hgbot | Checkin | |
| 2010-07-05 18:29 | hgbot | Note Added: 0029067 | |
| 2010-07-05 18:29 | hgbot | Status | scheduled => resolved |
| 2010-07-05 18:29 | hgbot | Resolution | open => fixed |
| 2010-07-05 18:29 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/fd08978a94e6654e2014a646c210281c8af160c1 [^] |
| 2010-07-05 18:35 | adrianromero | Note Added: 0029068 | |
| 2010-07-07 12:38 | hudsonbot | Checkin | |
| 2010-07-07 12:38 | hudsonbot | Note Added: 0029111 | |
| 2010-07-13 22:11 | sureshbabu | Note Added: 0029274 | |
| 2010-07-13 22:11 | sureshbabu | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |