Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0012605
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 04. Warehouse managementminoralways2010-03-09 12:312012-04-26 19:32
ReporterxabiermerinoView Statuspublic 
Assigned Tonaiaramartinez 
PriorityhighResolutionfixedFixed in Version3.0MP11
StatusclosedFix in branchpiFixed in SCM revisionda699739d61d
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0012605: Minor issue in 'Generate Average Costs' price choosing

DescriptionMinor issue in 'Generate Average Costs' price choosing

Tested in http://live.builds.openbravo.com/erp_devel_pi-full-oracle/ [^]
Steps To ReproduceProcess 'Generate Average Costs'
https://code.openbravo.com/erp/devel/pi/file/tip/src-db/database/model/functions/M_GENERATE_AVERAGE_COSTS.xml [^]
1) Create a new Purchase Price List
2) Create a new purchase price list version valid from date 23-03-2010
3) Create a product price for product Hammer (all to 25.00)
4) Navigate to product Hammer then to tab Price and de-activate product price record
for Price List Version Purchase 2006
5) Create a goods receipt with movement date 23-03-2010
6) Add a line for product Hammer.
7) Navigate back to the header and complete it.
8) Click on Generate Average Costs process.
9) Navigate to product Hammer then to tab Costing.
10) A record for the goods receipt movement has been created with the product price
of the Price List Version Purchase 2006 even this record has been de-activated for
the product Hammer (minor issue).
11) Navigate to the Price List Version Purchase 2006 and de-activate it.
12) Click on Generate Average Costs process.
13) You get a warning message saying that cost could not be calculated (since price
not found): this is correct.
14) Navigate to the business partner of the goods receipt and in Vendor tab select
the new Purchase Price List created.
15) Click on Generate Average Costs process.
16) You get a warning message saying that cost could not be calculated (since price
not found): this is NOT correct since the price list version is valid for the same
date as the movement date (23-03-2010) but is not taken into account (minor issue).
Proposed SolutionFor both minor issues have a look at these lines
https://code.openbravo.com/erp/devel/pi/file/tip/src-db/database/model/functions/M_GENERATE_AVERAGE_COSTS.xml#l214 [^]
* Is missing AND M_PRODUCTPRICE.ISACTIVE='Y'
* Have to replace AND M_PRICELIST_VERSION.VALIDFROM<Cur_InOutLine.MOVEMENTDATE by AND
M_PRICELIST_VERSION.VALIDFROM<=Cur_InOutLine.MOVEMENTDATE
TagsVMA-Reviewed
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0047584)
naiaramartinez (developer)
2012-04-16 13:21

 Test Plan:
  Login as System administrator.
   Go to 'windows, tabs and fields'
   Select the record with 'Product' as name
   Select the record in tab with Price as name.
   Select 'Active' field and check the display field in order to do visible.
  
  Login as F&B International Group admin.
   Create a new Purchase Price List
   Create a new purchase price list version valid from date 16-04-2012
   Create a product price for product Ale Beer (all to 25.00)
   Navigate to product Ale Beer then to tab Price and de-activate product price record for General Sales and Happy Deinks Price List.
   Create a goods receipt with movement date 16-04-2012
   Add a line for product Ale Beer.
   Navigate to the business partner of the goods receipt and in Vendor tab select the new Purchase Price List created.
   Navigate back to the header og the goods receipt and complete it.
   Click on Generate Average Costs process.
   Navigate to product Ale Beer then to tab Costing.
   A record for the goods receipt movement has been created with the product price of the created Price List.
(0047910)
hgbot (developer)
2012-04-24 13:10

 Repository: erp/devel/pi
Changeset: da699739d61dd0980bc84ca06d86abdd399a38dc
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Thu Apr 19 18:21:17 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/da699739d61dd0980bc84ca06d86abdd399a38dc [^]

fixed bug 12605 In M_GENERATE_AVERAGE_COST add isactive and date validations
M_PRODUCTPRICE.ISACTIVE='Y' and
M_PRICELIST_VERSION.VALIDFROM<Cur_InOutLine.MOVEMENTDATE+1

---
M src-db/database/model/functions/M_GENERATE_AVERAGE_COSTS.xml
---
(0047912)
mirurita (developer)
2012-04-24 13:19

 code review + testing OK
(0048078)
hudsonbot (developer)
2012-04-26 19:32

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/70a717a9ffa1 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2010-03-09 12:31 xabiermerino New Issue
2010-03-09 12:31 xabiermerino Assigned To => adrianromero
2011-06-03 11:00 dalsasua Assigned To adrianromero => dalsasua
2011-07-20 18:11 dalsasua Assigned To dalsasua => jonalegriaesarte
2012-04-03 12:20 jonalegriaesarte Assigned To jonalegriaesarte => vmromanos
2012-04-10 13:39 vmromanos Tag Attached: VMA-Reviewed
2012-04-16 13:09 naiaramartinez Assigned To vmromanos => naiaramartinez
2012-04-16 13:10 naiaramartinez Status new => scheduled
2012-04-16 13:10 naiaramartinez fix_in_branch => pi
2012-04-16 13:21 naiaramartinez Note Added: 0047584
2012-04-24 13:10 hgbot Checkin
2012-04-24 13:10 hgbot Note Added: 0047910
2012-04-24 13:10 hgbot Status scheduled => resolved
2012-04-24 13:10 hgbot Resolution open => fixed
2012-04-24 13:10 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/da699739d61dd0980bc84ca06d86abdd399a38dc [^]
2012-04-24 13:19 mirurita Note Added: 0047912
2012-04-24 13:19 mirurita Status resolved => closed
2012-04-24 13:19 mirurita Fixed in Version => 3.0MP11
2012-04-26 19:32 hudsonbot Checkin
2012-04-26 19:32 hudsonbot Note Added: 0048078

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker