Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0012587 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
feature request | [Openbravo ERP] 07. Sales management | major | always | 2010-03-08 09:50 | 2010-08-18 00:00 | |||
Reporter | networkb | View Status | public | |||||
Assigned To | adrianromero | |||||||
Priority | urgent | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | pi | Fixed in SCM revision | 2c0b028e7372 | |||
Projection | none | ETA | none | Target Version | 2.50MP14 | |||
OS | Linux 32 bit | Database | PostgreSQL | Java version | 1.6.0_18 | |||
OS Version | Community Appliance | Database version | 8.3.9 | Ant version | 1.7.1 | |||
Product Version | 2.50MP12 | SCM revision | ||||||
Merge Request Status | ||||||||
Review Assigned To | ||||||||
OBNetwork customer | OBPS | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0012587: wrong price in process "copy lines" of invoice | |||||||
Description | in process "copy lines" in sales invoice, the new lines copied have the same unit price and list price that original invoice. The unit price and list price should be the price of price list of new invoice | |||||||
Steps To Reproduce | Sales Management || Transactions || Sales Invoice || Header: . create new invoice: business partner: mafalda price list: mafalda sales run "copy lines": select invoice 100007 (sales invoice) 6 lines are copied: Sales Management || Transactions || Sales Invoice || Header || Lines: . line 50: Net Unit Price 35 Net List Price 37 . in price list "Mafalda Sales" , go to tab "product price", and select the Hat product: Master Data Management || Pricing || Price List || Price List >> Price List Version >> Product Price the "list price" is 33.30 and the "standard price" is 31.50 The line 50 of new invoice, should be copied with this prices. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() ![]() ![]() | |||||||
![]() |
||||||||
|
![]() |
|
(0025124) rafaroda (viewer) 2010-03-08 14:17 |
I attach a patch proposal. Please notice that: 1) This patch is based on Openbravo ERP 2.50 MP8 but fix for issue 0012465 has been included. 2) This patch modifies current Copy Invoice Lines behavior. It would be interesting to extend this patch in order to preserve the old functionality (copy the lines exactly as they are) and add the new one (re-calculate prices and offers). |
(0025132) psarobe (viewer) 2010-03-08 15:50 edited on: 2010-03-08 15:51 |
This is not an issue but a feature request. The button is working how it is designed for |
(0027803) hgbot (developer) 2010-05-28 08:12 |
Repository: erp/devel/pi Changeset: 07a95c580a6230cfcecc22f98d539d5fa161473e Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com> Date: Fri May 28 11:19:37 2010 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/07a95c580a6230cfcecc22f98d539d5fa161473e [^] Fixes issue 12587: wrong price in process \"copy lines\" of invoice --- M src-db/database/sourcedata/AD_TEXTINTERFACES.xml M src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice.html M src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice.java M src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice_data.xsql --- |
(0027804) harikrishnan (viewer) 2010-05-28 08:50 |
Steps to reproduce: *Create a purchase invoice with business partner mafalda.Select the product as Hat. *Complete the sales order. *Goto Price List in the masterdata management and change the product price of hat for Mafalda sales. *Create a new sales invoice header with mafalda and then click on"Copy Lines". *If "Select Price from price List = N" then the prices are taken from the invoice that are copying.If this check box is selected then prices are taken from the price list. Root Cause: *Before is always copied from the previous invoice alone.Now according to the condition the price are taken. Impact: The impact can be seen in the purchase invoice also.Because the same copy line button is used for both the invoice. *Since i have checked the condition their is no impact of the previous functionality. |
(0027816) adrianromero (viewer) 2010-05-28 15:22 |
With this modification the copy lines process always give the message "Error: Process failed during execution. |
(0027833) hgbot (developer) 2010-05-31 13:50 |
Repository: erp/devel/pi Changeset: 2c0b028e737224a381182b3cb835ec9c531b9ca6 Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com> Date: Mon May 31 17:15:48 2010 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/2c0b028e737224a381182b3cb835ec9c531b9ca6 [^] Fixes issue 12587 while clicking copy lines their error processing failed.This is because in pgsql the amount is inserted as string.Now this is fixed. --- M src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice_data.xsql --- |
(0027933) hudsonbot (viewer) 2010-06-03 22:49 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/07a95c580a62 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/c011484a38d9 [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17407.obx [^] |
(0027935) hudsonbot (viewer) 2010-06-03 22:49 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/2c0b028e7372 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/c011484a38d9 [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17407.obx [^] |
(0030038) sureshbabu (viewer) 2010-08-17 08:16 |
verified its working fine |
![]() |
|||
Date Modified | Username | Field | Change |
2010-03-08 09:50 | networkb | New Issue | |
2010-03-08 09:50 | networkb | Assigned To | => adrianromero |
2010-03-08 09:50 | networkb | OBNetwork customer | => Yes |
2010-03-08 14:05 | rafaroda | Issue Monitored: rafaroda | |
2010-03-08 14:14 | rafaroda | Relationship added | related to 0012465 |
2010-03-08 14:15 | rafaroda | File Added: issue-12587-patch-proposal.diff | |
2010-03-08 14:17 | rafaroda | Note Added: 0025124 | |
2010-03-08 15:50 | psarobe | Note Added: 0025132 | |
2010-03-08 15:50 | psarobe | Assigned To | adrianromero => pjuvara |
2010-03-08 15:50 | psarobe | Type | defect => feature request |
2010-03-08 15:51 | psarobe | Assigned To | pjuvara => adrianromero |
2010-03-08 15:51 | psarobe | Status | new => scheduled |
2010-03-08 15:51 | psarobe | Note Edited: 0025132 | View Revisions |
2010-03-08 16:05 | jpabloae | Target Version | 2.50MP13 => 2.50MP14 |
2010-03-08 16:17 | rafaroda | File Deleted: issue-12587-patch-proposal.diff | |
2010-03-08 16:25 | rafaroda | File Added: issue-12587-patch-proposal.diff | |
2010-03-09 09:05 | rafaroda | File Deleted: issue-12587-patch-proposal.diff | |
2010-03-09 09:05 | rafaroda | File Added: issue-12587-patch-proposal.diff | |
2010-03-09 09:06 | rafaroda | File Added: CopyFromInvoice.java | |
2010-03-09 09:06 | rafaroda | File Added: CopyFromInvoice_data.xsql | |
2010-03-09 10:01 | adrianromero | Priority | immediate => urgent |
2010-05-28 08:12 | hgbot | Checkin | |
2010-05-28 08:12 | hgbot | Note Added: 0027803 | |
2010-05-28 08:12 | hgbot | Status | scheduled => resolved |
2010-05-28 08:12 | hgbot | Resolution | open => fixed |
2010-05-28 08:12 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/07a95c580a6230cfcecc22f98d539d5fa161473e [^] |
2010-05-28 08:50 | harikrishnan | Note Added: 0027804 | |
2010-05-28 15:22 | adrianromero | Note Added: 0027816 | |
2010-05-28 15:22 | adrianromero | Status | resolved => new |
2010-05-28 15:22 | adrianromero | Status | new => scheduled |
2010-05-28 15:22 | adrianromero | fix_in_branch | => pi |
2010-05-31 13:50 | hgbot | Checkin | |
2010-05-31 13:50 | hgbot | Note Added: 0027833 | |
2010-05-31 13:50 | hgbot | Status | scheduled => resolved |
2010-05-31 13:50 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/07a95c580a6230cfcecc22f98d539d5fa161473e [^] => http://code.openbravo.com/erp/devel/pi/rev/2c0b028e737224a381182b3cb835ec9c531b9ca6 [^] |
2010-06-03 22:49 | hudsonbot | Checkin | |
2010-06-03 22:49 | hudsonbot | Note Added: 0027933 | |
2010-06-03 22:49 | hudsonbot | Checkin | |
2010-06-03 22:49 | hudsonbot | Note Added: 0027935 | |
2010-08-17 08:16 | sureshbabu | Note Added: 0030038 | |
2010-08-17 08:16 | sureshbabu | Status | resolved => closed |
2010-08-18 00:00 | anonymous | sf_bug_id | 0 => 3047302 |
Copyright © 2000 - 2009 MantisBT Group |