Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0012586
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 08. Project and service managementmajorhave not tried2010-03-08 09:012010-03-16 11:34
ReporternetworkbView Statuspublic 
Assigned Toadrianromero 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisiona0a6f1333eec
ProjectionnoneETAnoneTarget Version2.50MP14
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50MP12SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0012586: The way to pay the expeses of the employee is creating an invoice what is not correct

DescriptionThe way to pay the expeses of the employee is creating an invoice what is not correct.
This invoices are showed on the invoice register book, what in not legal.

Steps To Reproduce-Insert an expense (not time expense) for an employee and process it
-Go to the "create ap invoices" process
-Fill the form to create the invoice for the previous expense.
Proposed SolutionInstead of create an invoice, create a manual settlement to paid the customer,
assigning to the settlement the project of the expense.
In this way the project profitability report should be changed to take into account this settlements.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 00120142.50MP14 closedadrianromero Error in Project Profitability 
related to backport 00157882.50MP27 closedadrianromero the system is blocked when run Create AP Expense Invoices 

-  Notes
(0025148)
pjuvara (reporter)
2010-03-08 17:22

An alternative solution is to clearly label this type of invoices and make sure they are not included in the tax reports.
(0025150)
adrianromero (manager)
2010-03-08 18:18

The proposed solution to this issue is to create a new flag in the document types table called "is employee expenses", and modify the Create AP invoices process to create a document of type of the document type with this flag active and if it does not exist any document type with this flag active then follow the current flow.

This way the user must create a new document type for employee expenses with this new flag active and then the Create AP invoices process will create new documents with this new document type and then it will not appear in the invoice register book because the document type for employees expenses will be new.
(0025236)
psarobe (manager)
2010-03-11 10:53

Adrian, it could happen that you have marked more than one so let's use max(). Take into account the organization of the document type
(0025246)
hgbot (developer)
2010-03-11 17:50

Repository: erp/devel/pi
Changeset: 8b436aa61995d1a4ed26dd5110efa109025598b2
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Mar 11 17:55:12 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8b436aa61995d1a4ed26dd5110efa109025598b2 [^]

Fixes issue 0012586: The way to pay the expeses of the employee is creating an invoice what is not correct

---
M src-db/database/model/tables/C_DOCTYPE.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/erpCommon/ad_process/ExpenseAPInvoice_data.xsql
A src-db/database/model/functions/AD_GET_DOCTYPE_EXPENSES.xml
---
(0025247)
adrianromero (manager)
2010-03-11 17:55

To test this issue. Create a new document type for expenses, but with the Expense flag activated.

When running the "Create AP invoices" process it will generate invoices with the new document type created and then it will not appear in the Invoice Register Book.
(0025250)
hgbot (developer)
2010-03-11 18:11

Repository: erp/devel/pi
Changeset: a0a6f1333eec22a330aa1b6d5ee5cfe375de2f42
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Mar 11 18:17:39 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a0a6f1333eec22a330aa1b6d5ee5cfe375de2f42 [^]

Fixes issue 0012586: The way to pay the expeses of the employee is creating an invoice what is not correct
Fixing copyright notice in function file

---
M src-db/database/model/functions/AD_GET_DOCTYPE_EXPENSES.xml
---
(0025430)
hudsonbot (developer)
2010-03-12 22:41

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/8b436aa61995 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/631c626866c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16685.obx [^]
(0025431)
hudsonbot (developer)
2010-03-12 22:41

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/a0a6f1333eec [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/631c626866c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16685.obx [^]
(0025493)
psarobe (manager)
2010-03-15 19:08

tested working fine

- Issue History
Date Modified Username Field Change
2010-03-08 09:01 networkb New Issue
2010-03-08 09:01 networkb Assigned To => adrianromero
2010-03-08 16:05 jpabloae Target Version 2.50MP14 => 2.50MP15
2010-03-08 17:22 pjuvara Note Added: 0025148
2010-03-08 18:18 adrianromero Status new => scheduled
2010-03-08 18:18 adrianromero Note Added: 0025150
2010-03-08 18:18 adrianromero fix_in_branch => pi
2010-03-11 10:39 networkb Target Version 2.50MP15 => 2.50MP14
2010-03-11 10:39 networkb fix_in_branch pi =>
2010-03-11 10:53 psarobe Note Added: 0025236
2010-03-11 17:50 hgbot Checkin
2010-03-11 17:50 hgbot Note Added: 0025246
2010-03-11 17:50 hgbot Status scheduled => resolved
2010-03-11 17:50 hgbot Resolution open => fixed
2010-03-11 17:50 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8b436aa61995d1a4ed26dd5110efa109025598b2 [^]
2010-03-11 17:55 adrianromero Note Added: 0025247
2010-03-11 18:11 hgbot Checkin
2010-03-11 18:11 hgbot Note Added: 0025250
2010-03-11 18:11 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/8b436aa61995d1a4ed26dd5110efa109025598b2 [^] => http://code.openbravo.com/erp/devel/pi/rev/a0a6f1333eec22a330aa1b6d5ee5cfe375de2f42 [^]
2010-03-12 22:41 hudsonbot Checkin
2010-03-12 22:41 hudsonbot Note Added: 0025430
2010-03-12 22:41 hudsonbot Checkin
2010-03-12 22:41 hudsonbot Note Added: 0025431
2010-03-15 19:08 psarobe Note Added: 0025493
2010-03-15 19:08 psarobe Status resolved => closed
2010-03-16 00:00 anonymous sf_bug_id 0 => 2970941
2010-03-16 11:33 rafaroda Issue Monitored: rafaroda
2010-03-16 11:34 rafaroda Relationship added related to 0012014
2011-01-27 10:52 malsasua Relationship added related to 0015788


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker