Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0012318
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementminoralways2010-02-17 11:372010-05-18 12:12
ReporternetworkbView Statuspublic 
Assigned Toharikrishnan 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revisionba70331d074a
ProjectionnoneETAnoneTarget Version2.50MP17
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50MP11SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0012318: A sales order with negative amount, does not appear in "Create invoices from orders"

DescriptionA sales order is created with negative amount. Also, its good shipment is created and completed.

If its sales invoice is needed to create automatically, using "Create invoices from orders", it does not appear because of its negative amount.

However, same sales order appears in "Generate invoices", process. If it is selected, invoice is created without problems.

It makes no sense that this sales order appears in one process and not in the other one.

Note: revising this process, c_invoice_candidate_v there is a clausure where only possitive lines are taken.
Steps To ReproduceGo to Sales Management > Transactions > Sales order.
Create a new header for Organization Main. Select as Invoice terms, "After delivery".
Fill all needed fields.
Go to Line tab.
Select one product. As ordered quantity, select -11.
Go back to header and process it.
Go to Good shipment window.
Create a new register and select same organization and BP.
Use Create lines from, and select previous line created.
Process it.
Go to Create invoices from orders form. Search.
Sales order does not appear.
Go to Generate invoices.
Select Main organization, and check that sales order appears.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0012913 closedshuehner api check build 338 failed with warnings 

-  Notes
(0024484)
adrianromero (manager)
2010-02-17 12:25

The proposal to fix this is to modify the process "c_invoice_candidate_v" to tale not only positive lines but also negative lines.

It has to be taken into account whether the process "c_invoice_candidate_v" is used in other places or not. Not to modify the behabiour in other places, only in "Create invoices from orders"
(0025265)
psarobe (manager)
2010-03-12 09:27

Hi Adrian,

This affects also the button "Create lines from" in Sales invoice/Purchase invoice. And it is not correct that you cannot select negatives sales orders.
I would like you to do a little research to know who did this change and why. Doing this we can know the reasons behind the change and we can teach him why he did it wrong so it does not happen again.
This change is affecting QS flows.
(0025896)
adrianromero (manager)
2010-04-06 13:59

This issue has been introduced in the following changeset:
https://code.openbravo.com/erp/devel/pi/rev/03e9f606c46e [^]

When fixing issue https://issues.openbravo.com/view.php?id=8173 [^]
(0025897)
hgbot (developer)
2010-04-06 14:11

Repository: erp/devel/pi
Changeset: ba70331d074a4ef404ba021a4f43e05348c5ecb6
Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com>
Date: Tue Apr 06 17:52:36 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/ba70331d074a4ef404ba021a4f43e05348c5ecb6 [^]

Fixes issue 12318: A sales order with negative amount, does not appear in \"Create invoices from orders\".

---
M src-db/database/model/views/C_INVOICE_CANDIDATE_V.xml
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
---
(0025904)
harikrishnan (reporter)
2010-04-06 15:45

Steps to test

*Create a standard sales order with negative quantity.
*Create a Goods Shipment for the above created sales order using create lines from.
*Now if you go to Create Invoice From orders ,the above created negative sales order will be displayed.The same order will be displayed in "Create Line From" in sales invoice window.
(0025933)
sureshbabu (reporter)
2010-04-07 13:18

working fine
(0026416)
hudsonbot (developer)
2010-04-19 21:12

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/ba70331d074a [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^]

- Issue History
Date Modified Username Field Change
2010-02-17 11:37 networkb New Issue
2010-02-17 11:37 networkb Assigned To => adrianromero
2010-02-17 12:25 adrianromero Status new => scheduled
2010-02-17 12:25 adrianromero Note Added: 0024484
2010-02-17 12:25 adrianromero fix_in_branch => pi
2010-03-08 16:05 jpabloae Target Version 2.50MP14 => 2.50MP15
2010-03-12 09:27 psarobe Note Added: 0025265
2010-04-06 07:43 harikrishnan Assigned To adrianromero => harikrishnan
2010-04-06 13:59 adrianromero Note Added: 0025896
2010-04-06 14:11 hgbot Checkin
2010-04-06 14:11 hgbot Note Added: 0025897
2010-04-06 14:11 hgbot Status scheduled => resolved
2010-04-06 14:11 hgbot Resolution open => fixed
2010-04-06 14:11 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ba70331d074a4ef404ba021a4f43e05348c5ecb6 [^]
2010-04-06 15:45 harikrishnan Note Added: 0025904
2010-04-07 13:18 sureshbabu Note Added: 0025933
2010-04-07 13:18 sureshbabu Status resolved => closed
2010-04-08 00:00 anonymous sf_bug_id 0 => 2983495
2010-04-08 17:29 shuehner Relationship added related to 0012913
2010-04-19 21:12 hudsonbot Checkin
2010-04-19 21:12 hudsonbot Note Added: 0026416
2010-05-18 12:12 gorka_gil Target Version 2.50MP15 => 2.50MP17


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker