Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0011804
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 01. General setupminoralways2009-12-17 00:452010-03-12 22:41
ReporterelopioView Statuspublic 
Assigned Todbaz 
PriorityurgentResolutionfixedFixed in Versionpi
StatusclosedFix in branchpiFixed in SCM revision61af0928920b
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0011804: Message box without id in rebuild pop up.

DescriptionThe elements that display message title and message body have no ids in the rebuild pop up.

This is the html of that section:
<td id="messageBoxIDContent" style="vertical-align: top;">
<span>
<div class="MessageBox_TextTitle">Error:</div>
<div class="MessageBox_TextDescription">
An error has occurred in the build. For a list of actions to take, go to
http://wiki.openbravo.com/wiki/UpgradeTips [^]
.
</div>
Steps To Reproduce# Login as user with system admin role (Openbravo/openbravo)
# Navigate to module management General Setup || Application || Module Management || Module Management
# Move to Add modules tab
# Click the Browse File System button and select hello world 1.0.4 obx file. This file will cause a warning.
# complete the installation procedure
# Navigate to Installed modules tab
# Click rebuild now
# Click Ok
# Wait for the warning to appear.
Proposed Solutionuse "messageBoxIDTitle" as title id and "messageBoxIDMessage" as body id. Those are the identifiers used in the rest of the application.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0012040 closeddbaz Use the same identifier for all message box titles and messages 

-  Notes
(0024948)
dbaz (developer)
2010-03-02 14:38

 Repository: erp/devel/pi
Changeset: 61af0928920b27864c15ab0fea12cc7fd97c02ae
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Mar 02 14:37:05 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/61af0928920b27864c15ab0fea12cc7fd97c02ae [^]

Fixed issue 12040: Now all MessageBoxes have the same ID

---
M src/org/openbravo/base/secureApp/Advise.html
M src/org/openbravo/base/secureApp/Advise.xml
M src/org/openbravo/base/secureApp/AdvisePopUp.html
M src/org/openbravo/base/secureApp/AdvisePopUp.xml
M src/org/openbravo/base/secureApp/AdvisePopUpRefresh.html
M src/org/openbravo/base/secureApp/AdvisePopUpRefresh.xml
M src/org/openbravo/base/secureApp/Error.html
M src/org/openbravo/base/secureApp/Error.xml
M src/org/openbravo/base/secureApp/ErrorPopUp.html
M src/org/openbravo/base/secureApp/ErrorPopUp.xml
M src/org/openbravo/erpCommon/ad_forms/HeartbeatConfirm.html
M src/org/openbravo/erpCommon/ad_forms/HeartbeatConfirm.xml
M src/org/openbravo/erpCommon/ad_forms/RegistrationConfirm.html
M src/org/openbravo/erpCommon/ad_forms/RegistrationConfirm.xml
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintStatus.html
---
(0024982)
sureshbabu (reporter)
2010-03-03 08:24

 @Leo, i am not getting the warning message, while re-building the system after installing the hello world 1.0.4, so kindly take care of this.
(0025041)
hgbot (developer)
2010-03-04 07:16

 Repository: tools/automation/main
Changeset: f810864c4798a9afd81c872fbd8027d9dc905026
Author: Leo Arias <leo.arias <at> openbravo.com>
Date: Thu Mar 04 00:20:07 2010 -0600
URL: http://code.openbravo.com/tools/automation/main/rev/f810864c4798a9afd81c872fbd8027d9dc905026 [^]

Updated message box identifiers because issue 11804 is now resolved.

---
M src-test/com/openbravo/test/integration/erp/gui/general/application/RebuildSystemPopUp.java
---
(0025069)
elopio (reporter)
2010-03-05 05:48

 This message box still has no id. Perhaps it was fixed for the Error message box but not for the warning one.
With today's pi it shows the same html:

<div class="MessageBox_TextTitle">Warning</div><div class="MessageBox_TextDescription">There were warnings on the build. The application will run, but you should check them to see if there were important. Go to http://wiki.openbravo.com/wiki/ERP/2.50/Update_Tips [^] for more information. You must now restart the application container to see the changes.</div><div class="MessageBox_TextSeparator"></div>

@dbaz, please let me know if you need more info.
(0025094)
dbaz (developer)
2010-03-05 16:36

 src/org/openbravo/erpCommon/ad_process/ApplyModules.html

The IDs are right.

Assigned to AMO to check what is happening
(0025096)
hgbot (developer)
2010-03-05 17:11

 Repository: erp/devel/pi
Changeset: cfea97cf5a8b39ef0d0972e355d2b818815a9c39
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Fri Mar 05 17:15:33 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cfea97cf5a8b39ef0d0972e355d2b818815a9c39 [^]

Related to issue 11804: Added the messageBox ID also to JS functions

---
M src/org/openbravo/erpCommon/security/Login_F1.html
M web/js/default/MessageBox.js
M web/js/utils.js
---
(0025100)
hgbot (developer)
2010-03-07 07:40

 Repository: tools/automation/main
Changeset: 76faf89dae5279ade815a47cda23d087747db9b6
Author: Leo Arias <leo.arias <at> openbravo.com>
Date: Sun Mar 07 00:45:28 2010 -0600
URL: http://code.openbravo.com/tools/automation/main/rev/76faf89dae5279ade815a47cda23d087747db9b6 [^]

Updated message box identifiers because issue 11804 is resolved again.

---
M src-test/com/openbravo/test/integration/erp/gui/general/application/RebuildSystemPopUp.java
---
(0025102)
arunkumar (reporter)
2010-03-08 06:42

 Leo I have tested this.After rebuilding the title message shows "Process completed successfully" and the body message is displayed as "The build was completed succesfully. You must now restart the application container to see the changes."

I guess this is the right one.Leo can you please check and close this.
(0025401)
hudsonbot (developer)
2010-03-12 22:41

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/cfea97cf5a8b [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/631c626866c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16685.obx [^]

- Issue History
Date Modified Username Field Change
2009-12-17 00:45 elopio New Issue
2009-12-17 00:45 elopio Assigned To => rafaroda
2010-01-21 19:18 elopio Relationship added blocks 0012040
2010-02-11 18:32 rafaroda Assigned To rafaroda => alostale
2010-02-13 21:41 iciordia Assigned To alostale => dbaz
2010-02-13 21:41 iciordia Priority normal => urgent
2010-02-13 21:41 iciordia Status new => scheduled
2010-03-02 14:38 dbaz Note Added: 0024948
2010-03-02 14:38 dbaz Status scheduled => resolved
2010-03-02 14:38 dbaz Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/61af0928920b27864c15ab0fea12cc7fd97c02ae [^]
2010-03-02 14:38 dbaz Resolution open => fixed
2010-03-03 08:24 sureshbabu Note Added: 0024982
2010-03-04 07:16 hgbot Checkin
2010-03-04 07:16 hgbot Note Added: 0025041
2010-03-05 05:48 elopio Note Added: 0025069
2010-03-05 05:48 elopio Status resolved => new
2010-03-05 05:48 elopio Resolution fixed => open
2010-03-05 16:36 dbaz Note Added: 0025094
2010-03-05 16:36 dbaz Assigned To dbaz => marvintm
2010-03-05 17:08 elopio Status new => scheduled
2010-03-05 17:08 elopio fix_in_branch => pi
2010-03-05 17:10 dbaz Assigned To marvintm => dbaz
2010-03-05 17:11 hgbot Checkin
2010-03-05 17:11 hgbot Note Added: 0025096
2010-03-05 17:12 dbaz Status scheduled => resolved
2010-03-05 17:12 dbaz Resolution open => fixed
2010-03-07 07:40 hgbot Checkin
2010-03-07 07:40 hgbot Note Added: 0025100
2010-03-08 06:42 arunkumar Note Added: 0025102
2010-03-11 06:20 elopio Status resolved => closed
2010-03-11 06:20 elopio Fixed in Version => pi
2010-03-12 00:00 anonymous sf_bug_id 0 => 2969003
2010-03-12 22:41 hudsonbot Checkin
2010-03-12 22:41 hudsonbot Note Added: 0025401

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker