Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0011765
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] 03. Procurement managementminoralways2009-12-14 12:462010-01-27 12:24
ReporternetworkbView Statuspublic 
Assigned Togorkaion 
PriorityhighResolutionfixedFixed in Version2.50MP12
StatusclosedFix in branch2.40Fixed in SCM revision188c8617c39f
ProjectionnoneETAnoneTarget Version
OSAnyDatabasePostgreSQLJava version
OS VersionDatabase versionAnt version
Product Version2.50MP8SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0011765: Error when Create Purchase Order from a Requisition

DescriptionWhen yo try create the purchase order appears this Error:

Error:
no existe la funcion m_get_offers_price(timestamp without time zone, character
varying, character varying, numeric, numeric, numeric)
Steps To Reproduce-As Openbravo Admin go to Procurement Management || Transactions || Requisition
-Create a new record
-Save and go to Lines.
-Product: Hammer
-Save, go to the Header and Complete
-Go to Procurement Management || Transactions || Manage Requisitions
-Chose the Requisition created after filtering
-Click Create Purchase Order
Proposed SolutionReview M_REQUISITION_CREATE_PO function in the following line https://code.openbravo.com/erp/stable/2.40/file/9d637a50c2d8/src-db/database/model/functions/M_REQUISITION_CREATEPO.xml#l216 [^]

It is using variable v_PriceList NUMBER (which is the price defined as price list - WRONG) instead of Cur_Lines.PriceList_ID NUMBER (which is the ID of the pricelist- CORRECT).

M_GET_OFFERS_PRICE gets the ID of a pricelist (NUMBER) as last parameter, which is also CORRECT https://code.openbravo.com/erp/stable/2.40/file/9d637a50c2d8/src-db/database/model/functions/M_GET_OFFERS_PRICE.xml [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to backport 00117062.40MP12 closedgorkaion the price adjustment isn't correct if in the price adustment includes a Price List 
blocks defect 00114642.50MP11 closedgorkaion Error when Create Purchase Order from a Requisition 

-  Notes
(0022750)
rafaroda (developer)
2009-12-14 12:50

 Created backport because needed to fix 0011706
(0022759)
hgbot (developer)
2009-12-14 16:04

 Repository: erp/stable/2.40
Changeset: 188c8617c39ff8dba13cdc1d49e96b1c9fcbc6d5
Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com>
Date: Mon Dec 14 14:49:51 2009 +0100
URL: http://code.openbravo.com/erp/stable/2.40/rev/188c8617c39ff8dba13cdc1d49e96b1c9fcbc6d5 [^]

Fixes issue 0011706 Fixes issue 0011765 Price adjustments fixed in requisitions to orders

---
M src-db/database/model/functions/M_REQUISITION_CREATEPO.xml
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.java
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder_data.xsql
---
(0022761)
rafaroda (developer)
2009-12-14 16:07
edited on: 2010-01-08 16:44

 Steps to test this fix:
1) Create a Price Adjustment in Master Data Management || Pricing || Price Adjustments || Adjustments
* Name = Price Adjustment 40% off in all products for McGiver Supplies and Price List Purchase
* Starting Date = 01-01-2000
* Discount% = 40%
* Included Business Partners = All Selected
* Included Price Lists = All Selected
2) Navigate to Business Partner tab:
* Business Partner = McGiver Supplies
3) Navigate to Price List tab:
* Price List = Purchase
4) Create a new requisition in Procurement Management || Transactions || Requisition || Header
* Business Partner = McGiver Supplies
5) Navigate to Lines and create a new record:
* Product = Hammer
* Price List = Purchase
* Quantity = 15
* Unit Price = 4.50
* List Price = 5.00
* Discount = 10%
6) Create a new record:
* Product = Hammer
* Price List = Purchase
* Quantity = 37
* Unit Price = blank
* List Price = blank
* Discount = blank
7) Navigate back to the requisition header and Complete it.
8) Navigate to Procurement Management || Transactions || Manage Requisitions || Header and select the previous requisition.
9) Click on Create Purchase Order and select an Order Date, Business Partner = McGiver Supplies, Price List = Purchase and click on OK.
10) Navigate to the Purchase Order created.
11) Navigate to lines tab and check that:
* One line with Product = Hammer
** Quantity = 37
** Unit Price = 2.7 (Standard Price - Price Adjustment)
** Standard Price = 4.5
** Price Adjustment = 1.8 (Standard Price*40% = 4.5*40%)
** List Price = 5
** Discount = 10% ((List Price - Standard Price)*100/List Price)
* A second line with Product = Hammer
** Quantity = 15
** Unit Price = 2.7 (Standard Price - Price Adjustment)
** Standard Price = 4.5
** Price Adjustment = 1.8 (Standard Price*40% = 4.5*40%)
** List Price = 5
** Discount = 10% ((List Price - Standard Price)*100/List Price

See prices relations at https://issues.openbravo.com/view.php?id=8275 [^]
(0022976)
networkb (developer)
2009-12-21 11:11

 The proposed solution does not work
(0023016)
rafaroda (developer)
2009-12-22 14:44

 Sorry, what do you mean by "The proposed solution does not work"? Can you please explain further? Please notice that this is the solution proposed for Openbravo ERP 2.40 version. Proposed solution for Openbravo ERP 2.50 version can be found at 0011464
(0023017)
networkb (developer)
2009-12-22 15:24

 I have applied the solution in 2.40 MP11 and it does not work.
(0023041)
hgbot (developer)
2009-12-23 19:23

 Repository: erp/stable/2.40
Changeset: 03c93bd5c5f22fbaff14b7e7b36c243f89b2464a
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Wed Dec 23 19:12:27 2009 +0100
URL: http://code.openbravo.com/erp/stable/2.40/rev/03c93bd5c5f22fbaff14b7e7b36c243f89b2464a [^]

Related to issue 11765 and 11706.Backout fix.

---
M src-db/database/model/functions/M_REQUISITION_CREATEPO.xml
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.java
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder_data.xsql
---
(0023042)
gorkaion (developer)
2009-12-23 19:27

 fixed with changeset:
https://code.openbravo.com/erp/stable/2.40/rev/97563fbb3cff [^]
(0023819)
arunkumar (reporter)
2010-01-27 12:18

 Tested & Working fine.

- Issue History
Date Modified Username Field Change
2009-12-14 12:46 rafaroda New Issue
2009-12-14 12:46 rafaroda Assigned To => rafaroda
2009-12-14 12:46 rafaroda Issue generated from 0011464
2009-12-14 12:46 rafaroda Relationship added blocks 0011464
2009-12-14 12:49 rafaroda Reporter rafaroda => networkb
2009-12-14 12:49 rafaroda Status new => scheduled
2009-12-14 12:49 rafaroda fix_in_branch => 2.40
2009-12-14 12:49 rafaroda Steps to Reproduce Updated
2009-12-14 12:50 rafaroda Note Added: 0022750
2009-12-14 12:50 rafaroda Relationship added related to 0011706
2009-12-14 16:04 hgbot Checkin
2009-12-14 16:04 hgbot Note Added: 0022759
2009-12-14 16:04 hgbot Status scheduled => resolved
2009-12-14 16:04 hgbot Resolution open => fixed
2009-12-14 16:04 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/stable/2.40/rev/188c8617c39ff8dba13cdc1d49e96b1c9fcbc6d5 [^]
2009-12-14 16:07 rafaroda Note Added: 0022761
2009-12-14 16:21 rafaroda Note Edited: 0022761
2009-12-21 11:11 networkb Note Added: 0022976
2009-12-22 14:44 rafaroda Note Added: 0023016
2009-12-22 15:24 networkb Note Added: 0023017
2009-12-23 19:20 gorkaion Assigned To rafaroda => gorkaion
2009-12-23 19:20 gorkaion Status resolved => new
2009-12-23 19:20 gorkaion Resolution fixed => open
2009-12-23 19:20 gorkaion Status new => scheduled
2009-12-23 19:20 gorkaion fix_in_branch 2.40 => pi
2009-12-23 19:21 gorkaion fix_in_branch pi => 2.40
2009-12-23 19:23 hgbot Checkin
2009-12-23 19:23 hgbot Note Added: 0023041
2009-12-23 19:23 hgbot Fixed in SCM revision http://code.openbravo.com/erp/stable/2.40/rev/188c8617c39ff8dba13cdc1d49e96b1c9fcbc6d5 [^] => http://code.openbravo.com/erp/stable/2.40/rev/03c93bd5c5f22fbaff14b7e7b36c243f89b2464a [^]
2009-12-23 19:25 gorkaion Status scheduled => resolved
2009-12-23 19:25 gorkaion Fixed in SCM revision http://code.openbravo.com/erp/stable/2.40/rev/03c93bd5c5f22fbaff14b7e7b36c243f89b2464a [^] => https://code.openbravo.com/erp/stable/2.40/rev/188c8617c39f [^]
2009-12-23 19:26 gorkaion Resolution open => fixed
2009-12-23 19:27 gorkaion Note Added: 0023042
2010-01-08 16:44 rafaroda Note Edited: 0022761
2010-01-27 12:18 arunkumar Note Added: 0023819
2010-01-27 12:18 arunkumar Status resolved => closed
2010-01-27 12:18 arunkumar Fixed in Version => 2.40MP11
2010-01-27 12:24 sureshbabu Fixed in Version 2.40MP11 => 2.50MP12

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker