Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0011568 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | always | 2009-12-01 11:45 | 2009-12-11 06:38 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | 50f57c84e409 | |||
| Projection | none | ETA | none | Target Version | pi | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Merge Request Status | ||||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0011568: Heartbeat uses multiple database connections and closes connection too early | |||||||
| Description | The src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java class uses multiple db connections to read information from the database and commits a transaction to read the data again in the next step in a new connection. The early commit results in errors in hibernate because an object is not linked to a session anymore. gr. Martin | |||||||
| Proposed Solution | The solution is to use DalConnectionProvider and use one connection for all steps. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0022289) mtaal (viewer) 2009-12-01 11:46 |
Changeset: https://code.openbravo.com/erp/devel/pi/rev/641e8014bc50 [^] |
|
(0022544) mtaal (viewer) 2009-12-08 14:04 |
One more change is needed for this issue. When a new ProcessRequest is created then the OBScheduler is called. However, the OBScheduler uses its own connection provider. If the transaction is not committed before the scheduler is called. Then the OBScheduler won't see the ProcessRequest if it is new. So before calling the OBScheduler a commit has to be done. |
|
(0022547) hgbot (developer) 2009-12-08 16:44 |
Repository: erp/devel/pi Changeset: c021f8b29557b4cdf74747fa53b978e6e8791cf4 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Tue Dec 08 16:43:55 2009 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/c021f8b29557b4cdf74747fa53b978e6e8791cf4 [^] fixes issue 11568: Heartbeat uses multiple database connections and closes connection too early --- M src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java --- |
|
(0022571) iperdomo (viewer) 2009-12-09 11:36 |
I tested on pi @ rev785d51b8023e and got a wrong message and this errors in the log: a3196480 978929 [http-8880-6] ERROR org.openbravo.erpCommon.utility.MessageBDData - Exception in query: SELECT MSGTEXT FROM AD_MESSAGE WHERE VALUE=?Exception:org.hibernate.HibernateException: connnection proxy not usable after transaction completion a3196480 978929 [http-8880-6] ERROR org.openbravo.erpCommon.utility.MessageBDData - Exception in query: SELECT NAME FROM AD_ELEMENT WHERE COLUMNNAME=?Exception:org.hibernate.HibernateException: connnection proxy not usable after transaction completion |
|
(0022611) hgbot (developer) 2009-12-10 11:17 |
Repository: erp/devel/pi Changeset: 50f57c84e40910857a5f0ed21bc6419765e3621f Author: Martin Taal <martin.taal <at> openbravo.com> Date: Thu Dec 10 11:16:59 2009 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/50f57c84e40910857a5f0ed21bc6419765e3621f [^] fixes issue 11568: Heartbeat uses multiple database connections and closes connection too early --- M src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java --- |
|
(0022661) iperdomo (viewer) 2009-12-10 18:49 |
Tested on pi @ rev e82d1b5b692e |
|
(0022674) hudsonbot (viewer) 2009-12-11 06:35 |
--- A changeset related to this issue has passed a series of tests and has been promoted to main: Changeset: http://code.openbravo.com/erp/devel/main/rev/789f4e19eaf7 [^] Tests: http://builds.openbravo.com/view/devel-int/ [^] --- |
|
(0022681) hudsonbot (viewer) 2009-12-11 06:38 |
--- An OBX is generated including a changeset related to this issue and is available at: OBX: http://builds.openbravo.com/erp/obx/core/OpenbravoERP-2.50CI.15682.obx [^] --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2009-12-01 11:45 | mtaal | New Issue | |
| 2009-12-01 11:45 | mtaal | Assigned To | => mtaal |
| 2009-12-01 11:45 | mtaal | OBNetwork customer | => No |
| 2009-12-01 11:45 | mtaal | Status | new => scheduled |
| 2009-12-01 11:45 | mtaal | fix_in_branch | => pi |
| 2009-12-01 11:46 | mtaal | Note Added: 0022289 | |
| 2009-12-01 11:46 | mtaal | Status | scheduled => resolved |
| 2009-12-01 11:46 | mtaal | Fixed in Version | => pi |
| 2009-12-01 11:46 | mtaal | Fixed in SCM revision | => 5502 |
| 2009-12-01 11:46 | mtaal | Resolution | open => fixed |
| 2009-12-08 14:04 | mtaal | Note Added: 0022544 | |
| 2009-12-08 14:04 | mtaal | Status | resolved => new |
| 2009-12-08 14:04 | mtaal | Resolution | fixed => open |
| 2009-12-08 14:04 | mtaal | Fixed in Version | pi => |
| 2009-12-08 16:44 | hgbot | Checkin | |
| 2009-12-08 16:44 | hgbot | Note Added: 0022547 | |
| 2009-12-08 16:44 | hgbot | Status | new => resolved |
| 2009-12-08 16:44 | hgbot | Resolution | open => fixed |
| 2009-12-08 16:44 | hgbot | Fixed in SCM revision | 5502 => http://code.openbravo.com/erp/devel/pi/rev/c021f8b29557b4cdf74747fa53b978e6e8791cf4 [^] |
| 2009-12-09 11:36 | iperdomo | Note Added: 0022571 | |
| 2009-12-09 11:36 | iperdomo | Status | resolved => new |
| 2009-12-09 11:36 | iperdomo | Resolution | fixed => open |
| 2009-12-10 11:17 | hgbot | Checkin | |
| 2009-12-10 11:17 | hgbot | Note Added: 0022611 | |
| 2009-12-10 11:17 | hgbot | Status | new => resolved |
| 2009-12-10 11:17 | hgbot | Resolution | open => fixed |
| 2009-12-10 11:17 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/c021f8b29557b4cdf74747fa53b978e6e8791cf4 [^] => http://code.openbravo.com/erp/devel/pi/rev/50f57c84e40910857a5f0ed21bc6419765e3621f [^] |
| 2009-12-10 18:49 | iperdomo | Note Added: 0022661 | |
| 2009-12-10 18:49 | iperdomo | Status | resolved => closed |
| 2009-12-11 00:00 | anonymous | sf_bug_id | 0 => 2912319 |
| 2009-12-11 06:35 | hudsonbot | Checkin | |
| 2009-12-11 06:35 | hudsonbot | Note Added: 0022674 | |
| 2009-12-11 06:38 | hudsonbot | Checkin | |
| 2009-12-11 06:38 | hudsonbot | Note Added: 0022681 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |