Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0011486
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 00. Application dictionaryminoralways2009-11-25 11:572009-12-15 04:56
ReporternetworkbView Statuspublic 
Assigned Toharikrishnan 
PriorityhighResolutionfixedFixed in Version2.50MP10
StatusclosedFix in branchpiFixed in SCM revision51f8743bf57c
ProjectionnoneETAnoneTarget Version2.50MP10
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50MP9SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0011486: "Allow negative stock" does not chech if products have negative stock

DescriptionIf "Allow negative stock" is checked and then you deactivated it, no checking is done in order to verify if any product has a negative stock.
This causes a unstable information about stock.
Steps To Reproduce1) Check that Entity in General setup > Client > Client > Information, Allow Negative Stock is active.
2) Navigate to Navigate to Warehouse Management || Analysis Tools || Stock Report and check if there is any product with negative stock.
3) If not, create and complete some Goods Shipments of a product to reach negative stock.
4) Navigate to Navigate to Warehouse Management || Analysis Tools || Stock Report and check if there is any product with negative stock.
5) Navigate back to Entity in General setup > Client > Client > Information and de-activate Allow Negative Stock.

No message is shown.
Proposed SolutionWhen saving this record (in AD_CLIENT_INFO table [1]), a trigger has to make a stock check for the current Client. If the stock check fails (there are products with negative stock for this client), record should not be saved and error message should display: There are products with negative stock. Please set their stock to zero before allowing negative stock.

Stock check has to follow the same query as https://code.openbravo.com/erp/devel/pi/file/e083d72207fd/src-db/database/model/functions/M_CHECK_STOCK.xml#l48 [^] but removing the product and organization (all the products have to be verified for all the organizations within the current client).

[1] https://code.openbravo.com/erp/devel/pi/file/fbbc19d048ad/src-db/database/model/tables/AD_CLIENTINFO.xml [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 00111352.50MP10 closedrafaroda Insufficent stock in the line of produced product in Bill of Materials production window 

-  Notes
(0022389)
hgbot (developer)
2009-12-03 11:12

Repository: erp/devel/pi
Changeset: d05f23c7afe6a343dc9fdc8f5e9743950259b868
Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com>
Date: Thu Dec 03 15:41:39 2009 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/d05f23c7afe6a343dc9fdc8f5e9743950259b868 [^]

Fixes Issue 11486: \"Allow negative stock\" does not check if products have negative stock.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
A src-db/database/model/triggers/AD_CLIENTINFO_TRG.xml
---
(0022454)
hudsonbot (developer)
2009-12-04 09:15

---
A changeset related to this issue has passed a series of tests and has been promoted to main:

Changeset: http://code.openbravo.com/erp/devel/main/rev/f6bc559b1872 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
---
(0022531)
sureshbabu (reporter)
2009-12-08 09:12

The message "There are products with negative stock. Please set their stock to zero before allowing negative stock" appears when the user un-checks the "Allow Negative Stock" check box, which is out of context.

 (When we un-check the Allow Negative stock check box, ERP would not allow the user to perform transactions related with negative stocking nothing but we are deactivates the option of performing transactions with negative stock)

Kindly change the message similar to below

"There are products already with negative stock. Please set their stock to zero before deactivating the negative stock option"
(0022687)
hgbot (developer)
2009-12-11 09:38

Repository: erp/devel/pi
Changeset: 51f8743bf57c654e4cdb07ba3e92b11eec39aaf6
Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com>
Date: Fri Dec 11 14:06:34 2009 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/51f8743bf57c654e4cdb07ba3e92b11eec39aaf6 [^]

Fix for issue 11486 changing the message.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0022733)
sureshbabu (reporter)
2009-12-14 10:55

Tested working fine
(0022784)
hudsonbot (developer)
2009-12-15 04:56

---
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/e7ad8a48210d [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/obx/core/OpenbravoERP-2.50CI.15705.obx [^]
---

- Issue History
Date Modified Username Field Change
2009-11-25 11:57 networkb New Issue
2009-11-25 11:57 networkb Assigned To => rafaroda
2009-11-25 14:19 rafaroda Relationship added related to 0011135
2009-12-01 17:26 rafaroda Priority immediate => high
2009-12-01 17:26 rafaroda Status new => scheduled
2009-12-01 17:26 rafaroda Description Updated
2009-12-01 17:26 rafaroda Proposed Solution updated
2009-12-01 17:26 rafaroda Steps to Reproduce Updated
2009-12-02 09:45 harikrishnan Assigned To rafaroda => harikrishnan
2009-12-02 11:07 rafaroda Steps to Reproduce Updated
2009-12-03 11:12 hgbot Checkin
2009-12-03 11:12 hgbot Note Added: 0022389
2009-12-03 11:12 hgbot Status scheduled => resolved
2009-12-03 11:12 hgbot Resolution open => fixed
2009-12-03 11:12 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d05f23c7afe6a343dc9fdc8f5e9743950259b868 [^]
2009-12-04 09:15 hudsonbot Checkin
2009-12-04 09:15 hudsonbot Note Added: 0022454
2009-12-08 09:12 sureshbabu Note Added: 0022531
2009-12-08 09:12 sureshbabu Status resolved => new
2009-12-08 09:12 sureshbabu Resolution fixed => open
2009-12-11 09:38 hgbot Checkin
2009-12-11 09:38 hgbot Note Added: 0022687
2009-12-11 09:38 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/d05f23c7afe6a343dc9fdc8f5e9743950259b868 [^] => http://code.openbravo.com/erp/devel/pi/rev/51f8743bf57c654e4cdb07ba3e92b11eec39aaf6 [^]
2009-12-11 09:46 rafaroda Status new => scheduled
2009-12-11 09:46 rafaroda fix_in_branch => pi
2009-12-11 09:46 rafaroda Status scheduled => resolved
2009-12-11 09:46 rafaroda Resolution open => fixed
2009-12-14 10:55 sureshbabu Note Added: 0022733
2009-12-14 10:55 sureshbabu Status resolved => closed
2009-12-14 10:55 sureshbabu Fixed in Version => 2.50MP10
2009-12-15 00:00 anonymous sf_bug_id 0 => 2914441
2009-12-15 04:56 hudsonbot Checkin
2009-12-15 04:56 hudsonbot Note Added: 0022784


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker