Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0011416 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | sometimes | 2009-11-19 14:19 | 2009-11-25 00:00 | |||
| Reporter | iperdomo | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | 4887282d860c | |||
| Projection | none | ETA | none | Target Version | ||||
| OS | Linux 32 bit | Database | PostgreSQL | Java version | 1.6.0_15 | |||
| OS Version | 2.6.30-gentoo-r5 | Database version | 8.3.8 | Ant version | 1.7.1 | |||
| Product Version | pi | SCM revision | ||||||
| Merge Request Status | ||||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0011416: ad_update_table_identifier fails silently after a new table trigger change | |||||||
| Description | An extra check was added to table names in in rev 416ee338a145 [1] to avoid invalid characters like blank space ' ', dot and slash. There are modules built before this check was introduced and has some of the invalid characters, e.g. blank space. The trigger is executed on ad_update_table_identifier(null, 'N') function call, the trigger fails but the ad_update_table_identifier fails silently, and you end up with tables without the sql_record_identifier column. [1] https://code.openbravo.com/erp/devel/pi/annotate/416ee338a145/src-db/database/model/triggers/AD_TABLE_TRG.xml#l69 [^] | |||||||
| Steps To Reproduce | * Create a module with a table name containing an invalid character: '', '.', '/' in an previous 2.50 version like 2.50MP1 * Try to install that module in an latest pi based instance * Check for invalid sql_record_identifier values | |||||||
| Proposed Solution | * sql_record_identifier should fail * If you add a restriction like this one, you must check that a fallback is available | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0022023) mtaal (viewer) 2009-11-19 15:40 |
The idea is to make two changes: - only do the name change when the ad_table.name changes or a new table is created - ensure that illegal names are correctly caught when exporting/packaging a module gr. Martin |
|
(0022024) shuehner (administrator) 2009-11-19 15:55 |
first idea -> good second idea: we already tell people with a warning i think (at least in generate.entities)... but perhaps raise this to error on export module/package module |
|
(0022039) hgbot (developer) 2009-11-19 23:26 |
Repository: erp/devel/pi Changeset: 4887282d860c46b79f8bf8a629ff7268ddb386c2 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Thu Nov 19 23:25:51 2009 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/4887282d860c46b79f8bf8a629ff7268ddb386c2 [^] fixes issue 11416: ad_update_table_identifier fails silently after a new table trigger change --- M src-db/database/model/triggers/AD_TABLE_TRG.xml M src-test/org/openbravo/test/system/SystemValidatorTest.java M src/org/openbravo/base/model/NamingUtil.java M src/org/openbravo/service/system/ModuleValidator.java --- |
|
(0022134) iperdomo (viewer) 2009-11-24 12:34 |
Tested on pi @ rev 608ad05b9556 |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2009-11-19 14:19 | iperdomo | New Issue | |
| 2009-11-19 14:19 | iperdomo | Assigned To | => mtaal |
| 2009-11-19 14:19 | iperdomo | OBNetwork customer | => No |
| 2009-11-19 14:20 | iperdomo | Relationship added | related to 0008885 |
| 2009-11-19 14:20 | iperdomo | Status | new => scheduled |
| 2009-11-19 14:20 | iperdomo | fix_in_branch | => pi |
| 2009-11-19 14:53 | shuehner | Issue Monitored: shuehner | |
| 2009-11-19 15:40 | mtaal | Note Added: 0022023 | |
| 2009-11-19 15:55 | shuehner | Note Added: 0022024 | |
| 2009-11-19 23:26 | hgbot | Checkin | |
| 2009-11-19 23:26 | hgbot | Note Added: 0022039 | |
| 2009-11-19 23:26 | hgbot | Status | scheduled => resolved |
| 2009-11-19 23:26 | hgbot | Resolution | open => fixed |
| 2009-11-19 23:26 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/4887282d860c46b79f8bf8a629ff7268ddb386c2 [^] |
| 2009-11-24 12:34 | iperdomo | Note Added: 0022134 | |
| 2009-11-24 12:34 | iperdomo | Status | resolved => closed |
| 2009-11-25 00:00 | anonymous | sf_bug_id | 0 => 2903422 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |