Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0010624
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2009-09-16 13:012009-11-12 00:00
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PriorityurgentResolutionfixedFixed in Version2.50MP9
StatusclosedFix in branchFixed in SCM revisionf1dcd2224197
ProjectionnoneETAnoneTarget Versionpi
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0010624: Spaces in AD_TABLE.name should be handled better, currently the entity name contains a space resulting in errors in HQL

DescriptionWhen a AD_TABLE.name has a value then the entity name will also have a space. This will not work correctly in hql queries. The system should either not allow spaces in the AD_Table.name or repair the entity name.
Tagsmain
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0020109)
vmromanos (manager)
2009-09-16 13:17

Martin,

other problematic char could be '.'
(0020173)
rafaroda (developer)
2009-09-18 08:13

Martin,

Please provide some simple steps for QA team to reproduce this issue.

Thanks.
(0021320)
mtaal (manager)
2009-10-22 11:51

Hi,
To reproduce this change the name of a table (AD_Table.name so not the physical table name) and then try a DAL query on that.

I have made a change in the code to repair the name and log a warning if a name contains illegal characters.

I will contact Asier to see if/how I can add a check in the AD_Table.name field in the window also.

gr. Martin
(0021336)
hgbot (developer)
2009-10-22 14:53

Repository: erp/devel/pi
Changeset: 68ff104a46be91239b672e22137b6db748f7a240
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Oct 22 14:52:54 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/68ff104a46be91239b672e22137b6db748f7a240 [^]

fixes issue 10624: Spaces in AD_TABLE.name should be handled better

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-test/org/openbravo/test/model/RuntimeModelTest.java
M src/org/openbravo/base/model/Entity.java
M src/org/openbravo/base/model/NamingUtil.java
A src-db/database/model/triggers/AD_TABLE_NAME_TRG.xml
---
(0021347)
hgbot (developer)
2009-10-22 18:44

Repository: erp/devel/pi
Changeset: f1dcd22241974bccc619648ad8ab24dc85834133
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Oct 22 18:44:00 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f1dcd22241974bccc619648ad8ab24dc85834133 [^]

Fixed 10624: Fix syntax error in trigger definition

---
M src-db/database/model/triggers/AD_TABLE_NAME_TRG.xml
---
(0021709)
arunkumar (reporter)
2009-11-11 09:00

Tested & working fine.

- Issue History
Date Modified Username Field Change
2009-09-16 13:01 mtaal New Issue
2009-09-16 13:01 mtaal Assigned To => mtaal
2009-09-16 13:17 vmromanos Note Added: 0020109
2009-09-18 08:13 rafaroda Note Added: 0020173
2009-09-18 08:13 rafaroda Priority normal => urgent
2009-09-18 08:13 rafaroda Status new => scheduled
2009-10-22 11:51 mtaal Note Added: 0021320
2009-10-22 14:53 hgbot Checkin
2009-10-22 14:53 hgbot Note Added: 0021336
2009-10-22 14:53 hgbot Status scheduled => resolved
2009-10-22 14:53 hgbot Resolution open => fixed
2009-10-22 14:53 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/68ff104a46be91239b672e22137b6db748f7a240 [^]
2009-10-22 18:44 hgbot Checkin
2009-10-22 18:44 hgbot Note Added: 0021347
2009-10-22 18:44 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/68ff104a46be91239b672e22137b6db748f7a240 [^] => http://code.openbravo.com/erp/devel/pi/rev/f1dcd22241974bccc619648ad8ab24dc85834133 [^]
2009-10-22 19:26 psarobe Tag Attached: main
2009-11-11 09:00 arunkumar Status resolved => closed
2009-11-11 09:00 arunkumar Note Added: 0021709
2009-11-11 09:00 arunkumar Fixed in Version => 2.50MP9
2009-11-12 00:00 anonymous sf_bug_id 0 => 2896285


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker