Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010624Openbravo ERPA. Platformpublic2009-09-16 13:012009-11-12 00:00
Reportermtaal 
Assigned Tomtaal 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionpiFixed in Version2.50MP9 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0010624: Spaces in AD_TABLE.name should be handled better, currently the entity name contains a space resulting in errors in HQL
DescriptionWhen a AD_TABLE.name has a value then the entity name will also have a space. This will not work correctly in hql queries. The system should either not allow spaces in the AD_Table.name or repair the entity name.
Steps To Reproduce
Proposed Solution
Additional Information
Tagsmain
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-09-16 13:01mtaalNew Issue
2009-09-16 13:01mtaalAssigned To => mtaal
2009-09-16 13:01mtaalOBNetwork customer => No
2009-09-16 13:17vmromanosNote Added: 0020109
2009-09-18 08:13rafarodaNote Added: 0020173
2009-09-18 08:13rafarodaPrioritynormal => urgent
2009-09-18 08:13rafarodaStatusnew => scheduled
2009-10-22 11:51mtaalNote Added: 0021320
2009-10-22 14:53hgbotCheckin
2009-10-22 14:53hgbotNote Added: 0021336
2009-10-22 14:53hgbotStatusscheduled => resolved
2009-10-22 14:53hgbotResolutionopen => fixed
2009-10-22 14:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/68ff104a46be91239b672e22137b6db748f7a240 [^]
2009-10-22 18:44hgbotCheckin
2009-10-22 18:44hgbotNote Added: 0021347
2009-10-22 18:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/68ff104a46be91239b672e22137b6db748f7a240 [^] => http://code.openbravo.com/erp/devel/pi/rev/f1dcd22241974bccc619648ad8ab24dc85834133 [^]
2009-10-22 19:26psarobeTag Attached: main
2009-11-11 09:00arunkumarStatusresolved => closed
2009-11-11 09:00arunkumarNote Added: 0021709
2009-11-11 09:00arunkumarFixed in Version => 2.50MP9
2009-11-12 00:00anonymoussf_bug_id0 => 2896285

Notes
(0020109)
vmromanos   
2009-09-16 13:17   
Martin,

other problematic char could be '.'
(0020173)
rafaroda   
2009-09-18 08:13   
Martin,

Please provide some simple steps for QA team to reproduce this issue.

Thanks.
(0021320)
mtaal   
2009-10-22 11:51   
Hi,
To reproduce this change the name of a table (AD_Table.name so not the physical table name) and then try a DAL query on that.

I have made a change in the code to repair the name and log a warning if a name contains illegal characters.

I will contact Asier to see if/how I can add a check in the AD_Table.name field in the window also.

gr. Martin
(0021336)
hgbot   
2009-10-22 14:53   
Repository: erp/devel/pi
Changeset: 68ff104a46be91239b672e22137b6db748f7a240
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Oct 22 14:52:54 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/68ff104a46be91239b672e22137b6db748f7a240 [^]

fixes issue 10624: Spaces in AD_TABLE.name should be handled better

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-test/org/openbravo/test/model/RuntimeModelTest.java
M src/org/openbravo/base/model/Entity.java
M src/org/openbravo/base/model/NamingUtil.java
A src-db/database/model/triggers/AD_TABLE_NAME_TRG.xml
---
(0021347)
hgbot   
2009-10-22 18:44   
Repository: erp/devel/pi
Changeset: f1dcd22241974bccc619648ad8ab24dc85834133
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Oct 22 18:44:00 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f1dcd22241974bccc619648ad8ab24dc85834133 [^]

Fixed 10624: Fix syntax error in trigger definition

---
M src-db/database/model/triggers/AD_TABLE_NAME_TRG.xml
---
(0021709)
arunkumar   
2009-11-11 09:00   
Tested & working fine.