Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0010427
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2009-08-28 13:212009-10-06 11:50
ReporterdalsasuaView Statuspublic 
Assigned Toeduardo_Argal 
PriorityhighResolutionfixedFixed in Version2.50MP6
StatusclosedFix in branchFixed in SCM revision53d4c9a705d1
ProjectionnoneETAnoneTarget Versionpi
OSLinux 32 bitDatabaseOracleJava version1.5.0_15
OS VersionUbuntu 8.04HardyDatabase version10.2.0 SEAnt version1.7.0
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0010427: Purchase Invoices do not include c_tax_id value when being posted

DescriptionPurchase Invoices do not include c_tax_id value when being posted.

This is a problem because non of the tax reports will be reliable.
Steps To ReproduceCreate a purchase invoice
Add products with taxes
Post it
Check in database that none of the lines of the entry contain value for c_tax_id column
Proposed SolutionFor sales invoices is working fine. In DocInvoice.java, createFact function, exists this piece of code, when invoice to be posted is a sales invoice:

  // TaxDue CR
  for (int i = 0; m_taxes != null && i < m_taxes.length; i++) {
    //New docLine created to assign C_Tax_ID value to the entry
    DocLine docLine = new DocLine(DocumentType, Record_ID, "");
    docLine.m_C_Tax_ID = m_taxes[i].m_C_Tax_ID;
    fact.createLine(docLine, m_taxes[i].getAccount(DocTax.ACCTTYPE_TaxDue, as, conn),
        C_Currency_ID, "", m_taxes[i].m_amount, Fact_Acct_Group_ID, nextSeqNo(SeqNo),
      DocumentType, conn);
  }

and this code when the invoice is a purchase invoice:


// TaxCredit DR
for (int i = 0; m_taxes != null && i < m_taxes.length; i++)
  fact.createLine(null, m_taxes[i].getAccount(DocTax.ACCTTYPE_TaxCredit, as, conn),
      this.C_Currency_ID, m_taxes[i].getAmount(), "", Fact_Acct_Group_ID, nextSeqNo(SeqNo),
      DocumentType, conn);


It seems that in the second case, value taxes[i].m_C_Tax_ID is not provided to createLine function.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0020229)
hgbot (developer)
2009-09-21 11:55

 Repository: erp/devel/pi
Changeset: 53d4c9a705d1b5c6b8ad346fb5acc840d8d7d747
Author: David Alsasua <david.alsasua <at> openbravo.com>
Date: Mon Sep 21 11:55:15 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/53d4c9a705d1b5c6b8ad346fb5acc840d8d7d747 [^]

Fixes issue 10427: Purchase Invoices do not include c_tax_id
value when being posted

---
M src/org/openbravo/erpCommon/ad_forms/DocInvoice.java
---
(0020262)
psarobe (manager)
2009-09-22 12:02

 Tested working fine
(0020487)
hgbot (developer)
2009-09-29 14:14

 Repository: erp/devel/pi-pageddatagrid
Changeset: 53d4c9a705d1b5c6b8ad346fb5acc840d8d7d747
Author: David Alsasua <david.alsasua <at> openbravo.com>
Date: Mon Sep 21 11:55:15 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi-pageddatagrid/rev/53d4c9a705d1b5c6b8ad346fb5acc840d8d7d747 [^]

Fixes issue 10427: Purchase Invoices do not include c_tax_id
value when being posted

---
M src/org/openbravo/erpCommon/ad_forms/DocInvoice.java
---
(0020769)
psarobe (manager)
2009-10-06 11:50

 Closed again because hudson has reopened without no reason

- Issue History
Date Modified Username Field Change
2009-08-28 13:21 dalsasua New Issue
2009-08-28 13:21 dalsasua Assigned To => rafaroda
2009-08-28 13:22 dalsasua Assigned To rafaroda => eduardo_Argal
2009-08-28 15:02 rafaroda Priority normal => high
2009-08-28 15:02 rafaroda Status new => scheduled
2009-08-28 15:02 rafaroda version => pi
2009-09-21 11:55 hgbot Checkin
2009-09-21 11:55 hgbot Note Added: 0020229
2009-09-21 11:55 hgbot Status scheduled => resolved
2009-09-21 11:55 hgbot Resolution open => fixed
2009-09-21 11:55 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/53d4c9a705d1b5c6b8ad346fb5acc840d8d7d747 [^]
2009-09-22 12:02 psarobe Status resolved => closed
2009-09-22 12:02 psarobe Note Added: 0020262
2009-09-22 12:02 psarobe Fixed in Version => 2.50MP6
2009-09-23 00:00 anonymous sf_bug_id 0 => 2864615
2009-09-29 14:14 hgbot Checkin
2009-09-29 14:14 hgbot Note Added: 0020487
2009-09-29 14:14 hgbot Status closed => resolved
2009-09-29 14:14 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/53d4c9a705d1b5c6b8ad346fb5acc840d8d7d747 [^] => http://code.openbravo.com/erp/devel/pi-pageddatagrid/rev/53d4c9a705d1b5c6b8ad346fb5acc840d8d7d747 [^]
2009-10-06 11:50 psarobe Status resolved => closed
2009-10-06 11:50 psarobe Note Added: 0020769

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker